public inbox for linux-cxl@vger.kernel.org
 help / color / mirror / Atom feed
From: Alejandro Lucero Palau <alucerop@amd.com>
To: Dave Jiang <dave.jiang@intel.com>, linux-cxl@vger.kernel.org
Cc: alejandro.lucero-palau@amd.com, dan.j.williams@intel.com,
	ira.weiny@intel.com, vishal.l.verma@intel.com,
	alison.schofield@intel.com, Jonathan.Cameron@huawei.com,
	dave@stgolabs.net, fan.ni@samsung.com
Subject: Re: [PATCH v4 0/3] cxl: Pull out mailbox bits to be independent of cxl_dev_state
Date: Fri, 6 Sep 2024 08:23:24 +0100	[thread overview]
Message-ID: <59918a1c-5ebd-4255-ec5a-4d7a08b8cda2@amd.com> (raw)
In-Reply-To: <20240905223711.1990186-1-dave.jiang@intel.com>


On 9/5/24 23:35, Dave Jiang wrote:
> Hi Alejandro,
> Please feel free to pull in the patches in this series into your type2 series.
> Although I may just pull these into the 6.12 merge window to make things easier
> for you.
>
> The patches pulls out the related mailbox bits and form a 'struct cxl_mailbox'. In
> v2 Jonathan suggested that we keep cxl_mbox embedded. So I moved it back to be
> embedded. For the type2 devices that does not use mailbox, it can just not have
> the mailbox struct at all.


I've been using your v2 for my v3, so I'll adjust it to this v4. 
However, I do not think it has an impact on my work since the Type2 
support I'm adding is for our accel case which has not mailbox and 
therefore no accessor for initialising a mailbox from an accel driver is 
added. I guess that will need to wait until another accel driver 
requires it.


> v3
> - moved the other cxl headers into the linux/cxl directory.
> - Moved rcuwait.h header into mailbox.h (Alison)
>
> v4
> - Move headers to include/cxl (Dan)
> - Move header moving patch to 1/3 (Dan)
> - Fix cxl_mailbox_init input param check. (Alison)
>
> ---
>
> Dave Jiang (3):
>        cxl: move cxl headers to new linux/cxl/ directory
>        cxl: Move mailbox related bits to the same context
>        cxl: Convert cxl_internal_send_cmd() to use 'struct cxl_mailbox' as input
>
>   MAINTAINERS                                |  3 +-
>   drivers/acpi/apei/einj-cxl.c               |  2 +-
>   drivers/acpi/apei/ghes.c                   |  2 +-
>   drivers/cxl/core/mbox.c                    | 91 ++++++++++++++++++++++++++++++++------------------
>   drivers/cxl/core/memdev.c                  | 41 +++++++++++++----------
>   drivers/cxl/core/port.c                    |  2 +-
>   drivers/cxl/cxlmem.h                       | 25 ++++++--------
>   drivers/cxl/pci.c                          | 82 ++++++++++++++++++++++++++++++---------------
>   drivers/cxl/pmem.c                         | 10 ++++--
>   drivers/cxl/security.c                     | 23 +++++++------
>   include/{linux/einj-cxl.h => cxl/einj.h}   |  0
>   include/{linux/cxl-event.h => cxl/event.h} |  0
>   include/cxl/mailbox.h                      | 28 ++++++++++++++++
>   tools/testing/cxl/test/mem.c               | 44 ++++++++++++++++++------
>   14 files changed, 233 insertions(+), 120 deletions(-)
>

      parent reply	other threads:[~2024-09-06  7:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-05 22:35 [PATCH v4 0/3] cxl: Pull out mailbox bits to be independent of cxl_dev_state Dave Jiang
2024-09-05 22:35 ` [PATCH v4 1/3] cxl: move cxl headers to new include/cxl/ directory Dave Jiang
2024-09-06  0:17   ` Alison Schofield
2024-09-09 22:38   ` Ira Weiny
2024-10-14 14:52   ` Jonathan Cameron
2024-09-05 22:35 ` [PATCH v4 2/3] cxl: Move mailbox related bits to the same context Dave Jiang
2024-09-09 23:18   ` Ira Weiny
2024-09-09 23:40     ` Dave Jiang
2024-09-10 15:37       ` Ira Weiny
2024-10-14 14:51   ` Jonathan Cameron
2024-10-14 18:36     ` Alison Schofield
2024-10-16 14:47       ` Jonathan Cameron
2024-09-05 22:35 ` [PATCH v4 3/3] cxl: Convert cxl_internal_send_cmd() to use 'struct cxl_mailbox' as input Dave Jiang
2024-09-09 23:23   ` Ira Weiny
2024-09-06  7:23 ` Alejandro Lucero Palau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59918a1c-5ebd-4255-ec5a-4d7a08b8cda2@amd.com \
    --to=alucerop@amd.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=alejandro.lucero-palau@amd.com \
    --cc=alison.schofield@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=fan.ni@samsung.com \
    --cc=ira.weiny@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox