From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Alison Schofield <alison.schofield@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>, <linux-cxl@vger.kernel.org>,
<alejandro.lucero-palau@amd.com>, <dan.j.williams@intel.com>,
<ira.weiny@intel.com>, <vishal.l.verma@intel.com>,
<dave@stgolabs.net>, <fan.ni@samsung.com>,
Alejandro Lucero <alucerop@amd.com>, <shiju.jose@huawei.com>
Subject: Re: [PATCH v4 2/3] cxl: Move mailbox related bits to the same context
Date: Wed, 16 Oct 2024 15:47:27 +0100 [thread overview]
Message-ID: <20241016154727.000027f8@Huawei.com> (raw)
In-Reply-To: <Zw1kr5-99J_nKPyl@aschofie-mobl2.lan>
On Mon, 14 Oct 2024 11:36:31 -0700
Alison Schofield <alison.schofield@intel.com> wrote:
> On Mon, Oct 14, 2024 at 03:51:54PM +0100, Jonathan Cameron wrote:
> > On Thu, 5 Sep 2024 15:35:46 -0700
> > Dave Jiang <dave.jiang@intel.com> wrote:
> >
> > > Create a new 'struct cxl_mailbox' and move all mailbox related bits to
> > > it. This allows isolation of all CXL mailbox data in order to export
> > > some of the calls to external kernel callers and avoid exporting of CXL
> > > driver specific bits such has device states. The allocation of
> > > 'struct cxl_mailbox' is also split out with cxl_mailbox_create() so the
> > > mailbox can be created independently.
> > >
> > > Reviewed-by: Fan Ni <fan.ni@samsung.com>
> > > Reviewed-by: Alejandro Lucero <alucerop@amd.com>
> > > Reviewed-by: Alison Schofield <alison.schofield@intel.com>
> > > Link: https://patch.msgid.link/20240724185649.2574627-2-dave.jiang@intel.com
> > > Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> >
> > LGTM.
> > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > Note this is currently being carried in Shiju's RAS features set
> > as well. What is the merge plan? My preference is an immutable branch
> > that Borislav could pull into the EDAC tree and on which we can base
> > other stuff in CXL
> > That is a branch based on 6.12-rc1 directly with an appropriate tag
> > that Shiju's patch set can refer to.
>
>
> This set was merged in 6.12.
Ah. Shiju, seems you have an old base. Fix that for next version of the
RAS features
>
> >
> > Thanks,
> >
> > Jonathan
>
>
next prev parent reply other threads:[~2024-10-16 14:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 22:35 [PATCH v4 0/3] cxl: Pull out mailbox bits to be independent of cxl_dev_state Dave Jiang
2024-09-05 22:35 ` [PATCH v4 1/3] cxl: move cxl headers to new include/cxl/ directory Dave Jiang
2024-09-06 0:17 ` Alison Schofield
2024-09-09 22:38 ` Ira Weiny
2024-10-14 14:52 ` Jonathan Cameron
2024-09-05 22:35 ` [PATCH v4 2/3] cxl: Move mailbox related bits to the same context Dave Jiang
2024-09-09 23:18 ` Ira Weiny
2024-09-09 23:40 ` Dave Jiang
2024-09-10 15:37 ` Ira Weiny
2024-10-14 14:51 ` Jonathan Cameron
2024-10-14 18:36 ` Alison Schofield
2024-10-16 14:47 ` Jonathan Cameron [this message]
2024-09-05 22:35 ` [PATCH v4 3/3] cxl: Convert cxl_internal_send_cmd() to use 'struct cxl_mailbox' as input Dave Jiang
2024-09-09 23:23 ` Ira Weiny
2024-09-06 7:23 ` [PATCH v4 0/3] cxl: Pull out mailbox bits to be independent of cxl_dev_state Alejandro Lucero Palau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241016154727.000027f8@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alejandro.lucero-palau@amd.com \
--cc=alison.schofield@intel.com \
--cc=alucerop@amd.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=fan.ni@samsung.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=shiju.jose@huawei.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox