Re: [PATCH 1/2] cxl/memdev: Introduce wait-sanitize functionality

["Verma, Vishal L" <vishal.l.verma@intel.com>]

On Wed, 2023-04-26 at 11:25 -0700, Davidlohr Bueso wrote:
> On Wed, 26 Apr 2023, Verma, Vishal L wrote:
> 
> > These mostly look good - just one thing about the symbol script
> > additions in both this patch and the next one -  The different LIBCXL_N
> > sections in this correspond to a library release, and are used for
> > libtool versioning.
> > 
> > New symbols in a new release all go together in a new section in this
> > file. e.g. the pending branch has a 'LIBCXL_5' section for symbols
> > going in the v77 release (corresponding to kernel v6.3). Assuming these
> > patches are targeting v78 / v6.4, its new symbols should go in a new
> > LIBCXL_6 section.
> 
> I really have no specific version of ndctl in mind here, and for the kernel
> I'm "targeting" v6.5, so no hurry with this. It was mostly have the cxl
> tool support there for whenever the kernel bits landed (plus recycle testing
> to exercise the sysfs poll(2) support).
> 
> Would it make sense for you to update the libcxl.sym file for whenever you
> pick this up? If so I can just get rid of the entries in a v2.

Ah right - agreed on 6.5 as I think that's the target for mw-update as
well, 6.4 stuff is already 'frozen'.

Don't remove the .sym entries - I think the build might even complain -
but it is a safe bet to base on the last released version (v76), and
then just add a new section for your entries. And I can fix up the
inevitable merge-conflicts arising from this (which happens pretty
frequently for these anyway).

> 
> Thanks,
> Davidlohr