Re: [PATCH 1/2] cxl/memdev: Introduce wait-sanitize functionality

["Verma, Vishal L" <vishal.l.verma@intel.com>]

On Sat, 2023-04-22 at 18:59 -0700, Davidlohr Bueso wrote:
> Add a new cxl_memdev_wait_sanitize() to libcxl to support
> waiting for sanitation operation to be done in the background,
> if any.
> 
> This is analogous to 'ndctl wait-overwrite'.
> 
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
> ---
>  Documentation/cxl/cxl-wait-sanitize.txt | 35 +++++++++++
>  Documentation/cxl/lib/libcxl.txt        |  1 +
>  Documentation/cxl/meson.build           |  1 +
>  cxl/builtin.h                           |  1 +
>  cxl/cxl.c                               |  1 +
>  cxl/lib/libcxl.c                        | 78 +++++++++++++++++++++++++
>  cxl/lib/libcxl.sym                      |  1 +
>  cxl/libcxl.h                            |  1 +
>  cxl/memdev.c                            | 26 +++++++++
>  9 files changed, 145 insertions(+)
>  create mode 100644 Documentation/cxl/cxl-wait-sanitize.txt
> 
<..>

> diff --git a/cxl/lib/libcxl.sym b/cxl/lib/libcxl.sym
> index 6bc0810152e0..bf7d38f7e6fe 100644
> --- a/cxl/lib/libcxl.sym
> +++ b/cxl/lib/libcxl.sym
> @@ -70,6 +70,7 @@ global:
>         cxl_memdev_zero_label;
>         cxl_memdev_write_label;
>         cxl_memdev_read_label;
> +       cxl_memdev_wait_sanitize;
>  local:
>          *;
>  };

Hi Davidlohr,

These mostly look good - just one thing about the symbol script
additions in both this patch and the next one -  The different LIBCXL_N
sections in this correspond to a library release, and are used for
libtool versioning.

New symbols in a new release all go together in a new section in this
file. e.g. the pending branch has a 'LIBCXL_5' section for symbols
going in the v77 release (corresponding to kernel v6.3). Assuming these
patches are targeting v78 / v6.4, its new symbols should go in a new
LIBCXL_6 section.