Re: [PATCH v5 1/6] cxl/test: Add test for module parameters

[Dave Jiang <dave.jiang@intel.com>]

On 6/11/26 7:33 PM, Richard Cheng wrote:
> On Thu, Jun 11, 2026 at 04:44:04PM +0800, Dave Jiang wrote:
>> Add a test for module paraters during module init to make sure that
>> only one is activated.
> 
> "paraters" -> "parameters".

ok

> 
>>
>> Suggested-by: Alison Schofield <alison.schofield@intel.com>
>> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
>> ---
>> v5:
>> - Add test for hmem_test module parameters. (sashiko)
>> ---
>>  tools/testing/cxl/test/cxl.c       | 20 ++++++++++++++++++++
>>  tools/testing/cxl/test/hmem_test.c |  3 ++-
>>  tools/testing/cxl/test/mock.h      |  2 ++
>>  3 files changed, 24 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
>> index 296516eecfd6..1c8ac8bdd8f7 100644
>> --- a/tools/testing/cxl/test/cxl.c
>> +++ b/tools/testing/cxl/test/cxl.c
>> @@ -1814,11 +1814,31 @@ static struct attribute *cxl_acpi_attrs[] = {
>>  };
>>  ATTRIBUTE_GROUPS(cxl_acpi);
>>  
>> +static bool __init have_multiple_modparms(void)
>> +{
>> +	int count = 0;
>> +
>> +	if (interleave_arithmetic)
>> +		count++;
> 
> Should we make it a boolean ?
> It should only work with 0 or 1 right ?

I don't follow. The intention is that if there are >1 parameters then it fails.

DJ

> 
> --Richard
> 
>> +	if (extended_linear_cache)
>> +		count++;
>> +	if (fail_autoassemble)
>> +		count++;
>> +	if (hmem_test)
>> +		count++;
>> +
>> +	return count > 1;
>> +}
>> +
>>  static __init int cxl_test_init(void)
>>  {
>>  	int rc, i;
>>  	struct range mappable;
>>  
>> +	/* Enforce a single module param active at a time */
>> +	if (have_multiple_modparms())
>> +		return -EINVAL;
>> +
>>  	cxl_acpi_test();
>>  	cxl_core_test();
>>  	cxl_mem_test();
>> diff --git a/tools/testing/cxl/test/hmem_test.c b/tools/testing/cxl/test/hmem_test.c
>> index 3a1a089e1721..0fa00f7e16db 100644
>> --- a/tools/testing/cxl/test/hmem_test.c
>> +++ b/tools/testing/cxl/test/hmem_test.c
>> @@ -3,8 +3,9 @@
>>  #include <linux/moduleparam.h>
>>  #include <linux/workqueue.h>
>>  #include "../../../drivers/dax/bus.h"
>> +#include "mock.h"
>>  
>> -static bool hmem_test;
>> +bool hmem_test;
>>  
>>  static void hmem_test_work(struct work_struct *work)
>>  {
>> diff --git a/tools/testing/cxl/test/mock.h b/tools/testing/cxl/test/mock.h
>> index 4f57dc80ae7d..846d7c5d6eaa 100644
>> --- a/tools/testing/cxl/test/mock.h
>> +++ b/tools/testing/cxl/test/mock.h
>> @@ -5,6 +5,8 @@
>>  #include <linux/dax.h>
>>  #include <cxl.h>
>>  
>> +extern bool hmem_test;
>> +
>>  struct cxl_mock_ops {
>>  	struct list_head list;
>>  	bool (*is_mock_adev)(struct acpi_device *dev);
>> -- 
>> 2.54.0
>>
>>