Linux CXL
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: linux-cxl@vger.kernel.org, djbw@kernel.org, dave@stgolabs.net,
	 jic23@kernel.org, alison.schofield@intel.com,
	vishal.l.verma@intel.com
Subject: Re: [PATCH v5 6/6] cxl/test: Add cxl_test accelerator driver
Date: Wed, 17 Jun 2026 16:24:24 +0200	[thread overview]
Message-ID: <ajKt3db8vA_SEvSX@monoceros> (raw)
In-Reply-To: <20260611234409.256765-7-dave.jiang@intel.com>

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

Hello,

On Thu, Jun 11, 2026 at 04:44:09PM -0700, Dave Jiang wrote:
> +static const struct platform_device_id cxl_mock_accel_ids[] = {
> +	{ .name = "cxl_type2_accel", 0 },

Please drop the 0 here (and the comma before it).

> +	{ }
> +};

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2026-06-17 14:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-11 23:44 [PATCH v5 0/6] cxl: Add CXL type2 accelerator support for cxl_test Dave Jiang
2026-06-11 23:44 ` [PATCH v5 1/6] cxl/test: Add test for module parameters Dave Jiang
2026-06-11 23:59   ` sashiko-bot
2026-06-12  2:33   ` Richard Cheng
2026-06-12 15:35     ` Dave Jiang
2026-06-11 23:44 ` [PATCH v5 2/6] cxl/test: Add type2 support for mock CFMWS0 Dave Jiang
2026-06-11 23:56   ` sashiko-bot
2026-06-11 23:44 ` [PATCH v5 3/6] cxl/test: Refactor platform device enumerations Dave Jiang
2026-06-11 23:44 ` [PATCH v5 4/6] cxl/test: Add hierarchy enumeration support for type2 device Dave Jiang
2026-06-11 23:44 ` [PATCH v5 5/6] cxl/test: Fixup hdm init for auto region to support type2 Dave Jiang
2026-06-11 23:44 ` [PATCH v5 6/6] cxl/test: Add cxl_test accelerator driver Dave Jiang
2026-06-11 23:58   ` sashiko-bot
2026-06-12  2:44     ` Richard Cheng
2026-06-12 15:38       ` Dave Jiang
2026-06-17 14:24   ` Uwe Kleine-König [this message]
2026-06-17 17:28     ` Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ajKt3db8vA_SEvSX@monoceros \
    --to=u.kleine-koenig@baylibre.com \
    --cc=alison.schofield@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=djbw@kernel.org \
    --cc=jic23@kernel.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox