* [PATCH] dax: include bus.h for definition of run_dax()
@ 2023-06-16 16:13 Ben Dooks
2023-06-16 18:25 ` Ira Weiny
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2023-06-16 16:13 UTC (permalink / raw)
To: nvdimm
Cc: linux-kernel, dan.j.williams, vishal.l.verma, dave.jiang,
ira.weiny, linux-cxl, Ben Dooks
The run_dax() prototype is defined in "bus.h" but drivers/dax/super.c
does not include this. Include bus.h to silece the following sparse
warning:
drivers/dax/super.c:337:6: warning: symbol 'run_dax' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
drivers/dax/super.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dax/super.c b/drivers/dax/super.c
index c4c4728a36e4..8c05dae19bfe 100644
--- a/drivers/dax/super.c
+++ b/drivers/dax/super.c
@@ -14,6 +14,7 @@
#include <linux/dax.h>
#include <linux/fs.h>
#include "dax-private.h"
+#include "bus.h"
/**
* struct dax_device - anchor object for dax services
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dax: include bus.h for definition of run_dax()
2023-06-16 16:13 [PATCH] dax: include bus.h for definition of run_dax() Ben Dooks
@ 2023-06-16 18:25 ` Ira Weiny
0 siblings, 0 replies; 2+ messages in thread
From: Ira Weiny @ 2023-06-16 18:25 UTC (permalink / raw)
To: Ben Dooks, nvdimm
Cc: linux-kernel, dan.j.williams, vishal.l.verma, dave.jiang,
ira.weiny, linux-cxl, Ben Dooks
Ben Dooks wrote:
> The run_dax() prototype is defined in "bus.h" but drivers/dax/super.c
> does not include this. Include bus.h to silece the following sparse
> warning:
>
> drivers/dax/super.c:337:6: warning: symbol 'run_dax' was not declared. Should it be static?
A different version of this fix has already been queued up.
https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git/commit/?h=libnvdimm-fixes&id=2d5153526f929838b0912ded26862840f72745f4
Thank you anyway,
Ira
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-16 18:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-16 16:13 [PATCH] dax: include bus.h for definition of run_dax() Ben Dooks
2023-06-16 18:25 ` Ira Weiny
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox