Linux CXL
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Jim Harris <jim.harris@samsung.com>,
	Dan Williams <dan.j.williams@intel.com>
Cc: Jim Harris <jim.harris@samsung.com>,
	"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>
Subject: Re: [PATCH] cxl: set root decoder granularity based on region params
Date: Thu, 5 Oct 2023 11:08:32 -0700	[thread overview]
Message-ID: <651efba08a32e_ae7e72942b@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <A9AA55AC-F925-4B7F-866B-7AB849CB6F36@ssi.samsung.com>

Jim Harris wrote:
[..]
> > If a BIOS tries to ship such a config in production that's when I expect
> > that policy needs to be revisited, but outside of being forced to
> > reconsider that stance the complexity reduction is the benefit.
> > 
> > In the meantime maybe add an "effective granularity" concept for x1 root
> > decoders and x1 switches so the math can use that value?
> 
> Ack. Use “effective_granularity” (EG) for the topology math and
> “interleave_granularity” (IG) for programming the decoders.
> 
> For the x1 switches, is your intent here to set IG = 256 since the IG is
> really a don’t care from the decoder’s perspective? Or is there another
> reason we would need to track different IG v. EG for x1 switches?

Hmm, I see what you are saying. If the value is a don't care, might as well
just update interleave_granularity to make the math friendly. So "effective
granularity" is probably just a documentation update to the 'struct
cxl_decoder' kdoc so people are not surprised about why this may differ
from CFMWS value.

  reply	other threads:[~2023-10-05 18:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20231004230826uscas1p2f7957bf868a609211271e30ad8ff551f@uscas1p2.samsung.com>
2023-10-04 23:08 ` [PATCH] cxl: set root decoder granularity based on region params Jim Harris
2023-10-05  1:18   ` Dan Williams
2023-10-05 16:52     ` Jim Harris
2023-10-05 18:08       ` Dan Williams [this message]
2023-10-25  0:55       ` Dan Williams
2023-10-25  1:33         ` Jim Harris
2023-10-25  1:58           ` Dan Williams
2023-10-06 16:21   ` [PATCH] cxl/region: use region (not root decoder) granularity for calculations Jim Harris
2023-10-25  2:11     ` Dan Williams
2023-10-25 15:48       ` Jim Harris
2023-10-25 15:48     ` [PATCH v2] " Jim Harris
2023-10-26  0:11       ` Dan Williams
2023-10-26 17:11       ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=651efba08a32e_ae7e72942b@dwillia2-xfh.jf.intel.com.notmuch \
    --to=dan.j.williams@intel.com \
    --cc=jim.harris@samsung.com \
    --cc=linux-cxl@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox