From: Jim Harris <jim.harris@samsung.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>
Subject: Re: [PATCH] cxl: set root decoder granularity based on region params
Date: Wed, 25 Oct 2023 01:33:56 +0000 [thread overview]
Message-ID: <ZThwgJM2pSyTFaXQ@ubuntu> (raw)
In-Reply-To: <6538679925e75_72583294bb@dwillia2-xfh.jf.intel.com.notmuch>
On Tue, Oct 24, 2023 at 05:55:53PM -0700, Dan Williams wrote:
> Jim Harris wrote:
> [..]
> > > So I think this is only valid in the cxlrd->cxlsd.cxld.interleave_ways == 1
> > > case as interleave_granularity_store() forbids regions that do not match
> > > the granularity of the root.
> >
> > That’s correct. And now I think it’s better to put this assignment in
> > interleave_granularity_store() instead since we are already doing
> > root decoder related checking there, and we would then just be setting
> > this granularity once instead of once per memdev.
>
> Did you ever send the interleave_granularity_store() version of this
> patch? I can't seem to find it.
I found a third approach that was much simpler than the effective_granularity
approach. It's in this thread with a completely different title.
Should I have still marked it v2, even though the commit title and patch was
radically different?
next prev parent reply other threads:[~2023-10-25 1:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20231004230826uscas1p2f7957bf868a609211271e30ad8ff551f@uscas1p2.samsung.com>
2023-10-04 23:08 ` [PATCH] cxl: set root decoder granularity based on region params Jim Harris
2023-10-05 1:18 ` Dan Williams
2023-10-05 16:52 ` Jim Harris
2023-10-05 18:08 ` Dan Williams
2023-10-25 0:55 ` Dan Williams
2023-10-25 1:33 ` Jim Harris [this message]
2023-10-25 1:58 ` Dan Williams
2023-10-06 16:21 ` [PATCH] cxl/region: use region (not root decoder) granularity for calculations Jim Harris
2023-10-25 2:11 ` Dan Williams
2023-10-25 15:48 ` Jim Harris
2023-10-25 15:48 ` [PATCH v2] " Jim Harris
2023-10-26 0:11 ` Dan Williams
2023-10-26 17:11 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZThwgJM2pSyTFaXQ@ubuntu \
--to=jim.harris@samsung.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox