From: Dan Williams <dan.j.williams@intel.com>
To: Li Zhijian <lizhijian@fujitsu.com>, <linux-cxl@vger.kernel.org>
Cc: Li Zhijian <lizhijian@fujitsu.com>
Subject: RE: [ndctl PATCH] test/security.sh: test keyctl before excuting
Date: Thu, 7 Dec 2023 14:20:01 -0800 [thread overview]
Message-ID: <657245118201e_45e01294fb@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20231117083947.2211323-1-lizhijian@fujitsu.com>
Li Zhijian wrote:
> test keyctl command before executing
The "why" is missing here. Yes, someone can read the patch and go read
the code to see that this is probably a good idea. But what is the
effect of not doing this? Doesn't the existing "trap" result in the same
skipping of the test?
prev parent reply other threads:[~2023-12-07 22:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 8:39 [ndctl PATCH] test/security.sh: test keyctl before excuting Li Zhijian
2023-11-17 15:51 ` Dave Jiang
2023-12-07 22:20 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=657245118201e_45e01294fb@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox