Linux CXL
 help / color / mirror / Atom feed
From: Dave Jiang <dave.jiang@intel.com>
To: Li Zhijian <lizhijian@fujitsu.com>, <linux-cxl@vger.kernel.org>,
	"Vishal Verma" <vishal.l.verma@intel.com>
Subject: Re: [ndctl PATCH] test/security.sh: test keyctl before excuting
Date: Fri, 17 Nov 2023 08:51:13 -0700	[thread overview]
Message-ID: <ef0c8b12-260c-48fa-9d6f-fa750d8ed18c@intel.com> (raw)
In-Reply-To: <20231117083947.2211323-1-lizhijian@fujitsu.com>



On 11/17/23 01:39, Li Zhijian wrote:
> test keyctl command before executing
> 
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>

> ---
>  test/security.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/test/security.sh b/test/security.sh
> index 4713288..f954aec 100755
> --- a/test/security.sh
> +++ b/test/security.sh
> @@ -219,6 +219,8 @@ else
>  	do_skip "Missing input parameters"
>  fi
>  
> +check_prereq "keyctl"
> +
>  uid="$(keyctl show | grep -Eo "_uid.[0-9]+" | head -1 | cut -d. -f2-)"
>  if [ "$uid" -ne 0 ]; then
>  	do_skip "run as root or with a sudo login shell for test to work"
> @@ -227,7 +229,6 @@ fi
>  modprobe "$KMOD_TEST"
>  $CXL list
>  setup
> -check_prereq "keyctl"
>  rc=1
>  detect
>  test_cleanup

  reply	other threads:[~2023-11-17 15:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-17  8:39 [ndctl PATCH] test/security.sh: test keyctl before excuting Li Zhijian
2023-11-17 15:51 ` Dave Jiang [this message]
2023-12-07 22:20 ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef0c8b12-260c-48fa-9d6f-fa750d8ed18c@intel.com \
    --to=dave.jiang@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=lizhijian@fujitsu.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox