Linux CXL
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Dan Williams <dan.j.williams@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>, <linux-cxl@vger.kernel.org>,
	"Robert Richter" <rrichter@amd.com>,
	Ira Weiny <ira.weiny@intel.com>, <vishal.l.verma@intel.com>,
	<alison.schofield@intel.com>, <dave@stgolabs.net>
Subject: Re: [PATCH v6 0/5] cxl: find_cxl_root() related cleanups
Date: Mon, 8 Jan 2024 13:05:11 -0800	[thread overview]
Message-ID: <659c6387945ba_127da229429@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20240108115326.00006844@Huawei.com>

Jonathan Cameron wrote:
> On Fri, 5 Jan 2024 14:35:14 -0800
> Dan Williams <dan.j.williams@intel.com> wrote:
> 
> > Dave Jiang wrote:
> > > v6:
> > > - Fix breakage in previous series for device_find_child() (Dan)
> > > - Move DEFINE_FREE() for put_cxl_root() to first patch (Dan)
> > > - Don't touch put_device() until final cleanup. (Dan)
> > > - Add review tag from Ira.
> > > 
> > > This series provides a number of small cleanups to make fix_cxl_root()
> > > and related code more readable and safer.  
> > 
> > Looks good, Dave! Thanks for the spins.
> > 
> Subject to Robert's note on removing the root variable in patch 5 as it
> now appears unused, this series looks fine to me (and I guess Dan can
> probably just fix that up in the tree)
> 
> FWIW given this is already queued in in cxl/next
> 
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Thanks Jonathan, will add that to the pull request.

  reply	other threads:[~2024-01-08 21:05 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-05 22:07 [PATCH v6 0/5] cxl: find_cxl_root() related cleanups Dave Jiang
2024-01-05 22:07 ` [PATCH v6 1/5] cxl: Introduce put_cxl_root() helper Dave Jiang
2024-01-05 22:14   ` Robert Richter
2024-01-05 22:07 ` [PATCH v6 2/5] cxl: Convert find_cxl_root() to return a 'struct cxl_root *' Dave Jiang
2024-01-05 22:51   ` Robert Richter
2024-01-05 23:08     ` Dave Jiang
2024-01-05 23:34     ` Dave Jiang
2024-01-08 20:43     ` Dan Williams
2024-01-08 22:30       ` Robert Richter
2024-01-05 22:07 ` [PATCH v6 3/5] cxl: Fix device reference leak in cxl_port_perf_data_calculate() Dave Jiang
2024-01-05 22:56   ` Robert Richter
2024-01-05 23:59     ` Dave Jiang
2024-01-08 21:03       ` Dan Williams
2024-01-05 22:07 ` [PATCH v6 4/5] cxl: Refactor to use __free() for cxl_root allocation in cxl_find_nvdimm_bridge() Dave Jiang
2024-01-05 23:06   ` Robert Richter
2024-01-05 22:07 ` [PATCH v6 5/5] cxl: Refactor to use __free() for cxl_root allocation in cxl_endpoint_port_probe() Dave Jiang
2024-01-05 23:09   ` Robert Richter
2024-01-05 22:35 ` [PATCH v6 0/5] cxl: find_cxl_root() related cleanups Dan Williams
2024-01-08 11:53   ` Jonathan Cameron
2024-01-08 21:05     ` Dan Williams [this message]
2024-01-09  1:07 ` [PATCH 1/3] cxl: Remove cxl_root check after find_cxl_root Dave Jiang
2024-01-09  1:16   ` Dan Williams
2024-01-09  1:07 ` [PATCH 2/3] cxl: Cleanup unnecessary uages of cxl_port local vars from cxl_root Dave Jiang
2024-01-09  1:17   ` Dan Williams
2024-01-09 15:29   ` Jonathan Cameron
2024-01-09 15:38     ` Dave Jiang
2024-01-09  1:07 ` [PATCH 3/3] cxl: Make calling of find_cxl_root() declaration uniform Dave Jiang
2024-01-09  1:37   ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=659c6387945ba_127da229429@dwillia2-xfh.jf.intel.com.notmuch \
    --to=dan.j.williams@intel.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=alison.schofield@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=ira.weiny@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=rrichter@amd.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox