Re: [PATCH 2/3] cxl: Cleanup unnecessary uages of cxl_port local vars from cxl_root

[Dave Jiang <dave.jiang@intel.com>]

On 1/9/24 08:29, Jonathan Cameron wrote:
> On Mon, 08 Jan 2024 18:07:14 -0700
> Dave Jiang <dave.jiang@intel.com> wrote:
> 
>> Remove the local vars that points to the 'struct cxl_port' withint 'struct
>> cxl_root' and refer to the port directly.
>>
>> Suggested-by: Robert Richter <rrichter@amd.com>
>> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> A comment on existing code inline.  Otherwise LGTM
> 
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
>> ---
>>  drivers/cxl/core/cdat.c |   13 +++++--------
>>  drivers/cxl/port.c      |    5 +----
>>  2 files changed, 6 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c
>> index f7ba7bd2e459..140935511bab 100644
>> --- a/drivers/cxl/core/cdat.c
>> +++ b/drivers/cxl/core/cdat.c
>> @@ -290,7 +290,7 @@ static int match_cxlrd_qos_class(struct device *dev, void *data)
>>  	return 0;
>>  }
>>  
>> -static void cxl_qos_match(struct cxl_port *root_port,
>> +static void cxl_qos_match(struct cxl_root *cxl_root,
>>  			  struct list_head *work_list,
>>  			  struct list_head *discard_list)
>>  {
>> @@ -302,7 +302,7 @@ static void cxl_qos_match(struct cxl_port *root_port,
>>  		if (dpa_perf->qos_class == CXL_QOS_CLASS_INVALID)
>>  			return;
>>  
>> -		rc = device_for_each_child(&root_port->dev,
>> +		rc = device_for_each_child(&cxl_root->port.dev,
>>  					   (void *)&dpa_perf->qos_class,
> 
> Whilst we are here: Why is the (void *) needed or useful?

It's not. We can remove it. 
> 
>>  					   match_cxlrd_qos_class);
>>  		if (!rc)
> 
>>
> 
>