From: Dan Williams <dan.j.williams@intel.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Dan Williams <dan.j.williams@intel.com>
Cc: Kwangjin Ko <kwangjin.ko@sk.com>, <dave@stgolabs.net>,
<dave.jiang@intel.com>, <alison.schofield@intel.com>,
<vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel_team@skhynix.com>
Subject: Re: [PATCH v2 1/1] cxl/core: Fix initialization of mbox_cmd.size_out in get event
Date: Thu, 4 Apr 2024 10:35:44 -0700 [thread overview]
Message-ID: <660ee4f023cd7_7702a294d0@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20240404143049.00005635@Huawei.com>
Jonathan Cameron wrote:
[..]
> >
> > Fix looks correct, but I am concerned it is a band-aid for a more
> > general problem. For example, if I am not mistaken, we have a similar
> > bug in cxl_mem_get_poison().
> >
> > So perhaps a convention to always define @mbox_cmd immediately before
> > cxl_internal_send_cmd() like this:
>
> Makes sense to me. These aren't hot paths, so safe code is worth the
> possible extra writes.
Yeah, the before and after size wise is small:
text data bss dec hex filename
15407 2129 49 17585 44b1 drivers/cxl/core/mbox.o
text data bss dec hex filename
15461 2129 49 17639 44e7 drivers/cxl/core/mbox.o
...which I think is worth the peace of mind, and it matches what is
currently done in cxl_xfer_log()
I will send a follow on with this since this patch is already in
cxl-fixes.
next prev parent reply other threads:[~2024-04-04 17:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 8:14 [PATCH v2 0/1] cxl/core: Fix initialization of mbox_cmd.size_out in get event Kwangjin Ko
2024-04-02 8:14 ` [PATCH v2 1/1] " Kwangjin Ko
2024-04-02 14:38 ` Jonathan Cameron
2024-04-02 16:25 ` Ira Weiny
2024-04-03 14:53 ` Dan Williams
2024-04-04 13:30 ` Jonathan Cameron
2024-04-04 17:35 ` Dan Williams [this message]
2024-04-04 20:20 ` Ira Weiny
2024-04-05 16:04 ` Alison Schofield
2024-04-05 16:40 ` Jonathan Cameron
2024-04-05 17:37 ` Alison Schofield
2024-04-05 17:45 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=660ee4f023cd7_7702a294d0@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=kernel_team@skhynix.com \
--cc=kwangjin.ko@sk.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox