From: Dan Williams <dan.j.williams@intel.com>
To: "Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com>,
"Alison Schofield" <alison.schofield@intel.com>,
Dan Williams <dan.j.williams@intel.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Dave Jiang <dave.jiang@intel.com>,
"Vishal Verma" <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
"Dan Williams" <dan.j.williams@intel.com>,
<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cxl/acpi: Warn on unsupported platform config detection
Date: Wed, 26 Jun 2024 18:09:55 -0700 [thread overview]
Message-ID: <667cbbe3139b7_4fe7f294b5@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <5714543.ZASKD2KPVS@fdefranc-mobl3>
Fabio M. De Francesco wrote:
> On Wednesday, June 26, 2024 2:45:14 AM GMT+2 Dan Williams wrote:
> > Alison Schofield wrote:
> > > On Wed, Jun 19, 2024 at 02:59:41PM +0200, Fabio M. De Francesco wrote:
> > >
> > > Fabio,
> > >
> > > cxl/acpi does a lot of platform config work. "...unsupported platform
> > > config detection" gives no hint that this is about CHBS's or an eRCD.
> > > Please offer something more specific. Thanks.
> >
> > The message specifies "mixed Virtual Host and Restricted CXL Host
> > hierarchy" as the conflict. The relationship between RCH and eRCDs is an
> > exercise for the reader, and CHBS is an ACPI detail that really should
> > not be emitted in an error message. So I am struggling to imagine what a
> > more specific error message would be without paragraphs of backstory.
> >
> > All that is needed here is just enough words for when someone posts a
> > problem to the list that someone savvy can go "ah, you fell into this
> > specification hole where CXL 2.0 root port registers are difficult to
> > associate with an RCH config, thanks for the report now we know that
> > Linux needs to worry about this case".
> >
> I think that Alison raised a good point.
>
> If you have nothing against it, I'll change the subject line to: "cxl/acpi:
> Warn on mixed VH and eRCH hierarchies"
>
> How about that change?
Just, s/eRCH/RCH/, but other than that looks fine to me.
However, I thought this comment was about the error message not the patch subject.
prev parent reply other threads:[~2024-06-27 1:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 12:59 [PATCH] cxl/acpi: Warn on unsupported platform config detection Fabio M. De Francesco
2024-06-21 20:57 ` Alison Schofield
2024-06-25 23:41 ` Dan Williams
2024-06-26 10:00 ` Fabio M. De Francesco
2024-06-25 23:14 ` Dan Williams
2024-06-26 10:28 ` Fabio M. De Francesco
2024-06-26 0:10 ` Alison Schofield
2024-06-26 0:45 ` Dan Williams
2024-06-26 10:31 ` Fabio M. De Francesco
2024-06-27 1:09 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=667cbbe3139b7_4fe7f294b5@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=alison.schofield@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=fabio.m.de.francesco@linux.intel.com \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox