Linux CXL
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: <alison.schofield@intel.com>, Davidlohr Bueso <dave@stgolabs.net>,
	Jonathan Cameron <jonathan.cameron@huawei.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Ira Weiny <ira.weiny@intel.com>,
	Dan Williams <dan.j.williams@intel.com>
Cc: <linux-cxl@vger.kernel.org>
Subject: Re: [PATCH v3 1/4] cxl/core: Rename cxl_trace_hpa() to cxl_dpa_to_hpa()
Date: Wed, 26 Jun 2024 18:45:49 -0700	[thread overview]
Message-ID: <667cc44da5af8_563929489@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <3ed59646c9f1400432520845e482fb0341af4d56.1719275633.git.alison.schofield@intel.com>

alison.schofield@ wrote:
> From: Alison Schofield <alison.schofield@intel.com>
> 
> Although cxl_trace_hpa() is used to populate TRACE EVENTs with HPA
> addresses, the work it performs is a DPA to HPA translation, not a
> trace. Rename it.
> 
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>

Looks good,

Reviewed-by: Dan Williams <dan.j.williams@intel.com>

  reply	other threads:[~2024-06-27  1:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-25  0:55 [PATCH v3 0/4] XOR Math Fixups: translation & position alison.schofield
2024-06-25  0:55 ` [PATCH v3 1/4] cxl/core: Rename cxl_trace_hpa() to cxl_dpa_to_hpa() alison.schofield
2024-06-27  1:45   ` Dan Williams [this message]
2024-06-25  0:55 ` [PATCH v3 2/4] cxl: Restore XOR'd position bits during address translation alison.schofield
2024-06-27  2:04   ` Dan Williams
2024-07-01  9:28   ` Fabio M. De Francesco
2024-07-01  9:42     ` Fabio M. De Francesco
2024-07-01 22:48     ` Alison Schofield
2024-06-25  0:55 ` [PATCH v3 3/4] cxl/region: Verify target positions using the ordered target list alison.schofield
2024-06-25  0:55 ` [PATCH v3 4/4] cxl: Remove defunct code calculating host bridge target positions alison.schofield
2024-06-27  1:52 ` [PATCH v3 0/4] XOR Math Fixups: translation & position Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=667cc44da5af8_563929489@dwillia2-xfh.jf.intel.com.notmuch \
    --to=dan.j.williams@intel.com \
    --cc=alison.schofield@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=ira.weiny@intel.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox