From: Dan Williams <dan.j.williams@intel.com>
To: Robert Richter <rrichter@amd.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
"Ira Weiny" <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Dave Jiang <dave.jiang@intel.com>,
Davidlohr Bueso <dave@stgolabs.net>
Cc: <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Robert Richter" <rrichter@amd.com>
Subject: Re: [PATCH v2 1/5] cxl/hdm: Moving HDM specific code to core/hdm.c.
Date: Thu, 11 Jul 2024 17:32:06 -0700 [thread overview]
Message-ID: <669079864eb84_5fffa294b8@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20240701174754.967954-2-rrichter@amd.com>
Robert Richter wrote:
> Code to handle HDM specifics is implemented in core/pci.c and
> core/hdm.c. In both files helper functions will be needed for address
> translation. To simplify the introduction of static helper functions,
> move all HDM code to core/hdm.c.
>
> The function devm_cxl_enable_mem() is no longer static and is shared
> now within the core module. No functional changes otherwise.
Looks ok.
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
next prev parent reply other threads:[~2024-07-12 0:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 17:47 [PATCH v2 0/5] Address translation for HDM decoding Robert Richter
2024-07-01 17:47 ` [PATCH v2 1/5] cxl/hdm: Moving HDM specific code to core/hdm.c Robert Richter
2024-07-12 0:32 ` Dan Williams [this message]
2024-07-01 17:47 ` [PATCH v2 2/5] cxl/hdm: Implement address translation for HDM decoding Robert Richter
2024-07-12 1:03 ` Dan Williams
2024-07-13 7:40 ` Robert Richter
2024-07-01 17:47 ` [PATCH v2 3/5] cxl/acpi: Add platform flag for HPA address translation Robert Richter
2024-07-12 1:27 ` Dan Williams
2024-07-13 7:41 ` Robert Richter
2024-07-01 17:47 ` [PATCH v2 4/5] cxl/hdm: Setup HPA base for address translation using the HPA window in CFMWS Robert Richter
2024-07-01 17:47 ` [PATCH v2 5/5] cxl/acpi: Enable address translation for Zen4 platforms Robert Richter
2024-07-11 0:02 ` [PATCH v2 0/5] Address translation for HDM decoding Alison Schofield
2024-07-11 0:26 ` Alison Schofield
2024-07-11 19:03 ` Robert Richter
2024-07-25 22:00 ` Gregory Price
2024-08-06 10:54 ` Robert Richter
2024-08-16 18:32 ` Gregory Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=669079864eb84_5fffa294b8@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=alison.schofield@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rrichter@amd.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox