public inbox for linux-cxl@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Alejandro Lucero Palau <alucerop@amd.com>,
	Dave Jiang <dave.jiang@intel.com>, <linux-cxl@vger.kernel.org>
Cc: <alejandro.lucero-palau@amd.com>, <dan.j.williams@intel.com>,
	<ira.weiny@intel.com>, <vishal.l.verma@intel.com>,
	<alison.schofield@intel.com>, <Jonathan.Cameron@huawei.com>,
	<dave@stgolabs.net>, <fan.ni@samsung.com>
Subject: Re: [PATCH v3 3/3] cxl: move cxl headers to new linux/cxl/ directory
Date: Wed, 4 Sep 2024 19:55:00 -0700	[thread overview]
Message-ID: <66d91d844003d_286b294cf@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <e6cdb731-c2f1-5791-79ff-ff5835009475@amd.com>

Alejandro Lucero Palau wrote:
> 
> On 9/4/24 00:59, Dave Jiang wrote:
> > Group all cxl related kernel headers into include/linux/cxl directory.
> 
> 
> I tried to do this in the RFC for Type2 support.
> 
> I was told to just move the required bits for accel drivers able to do 
> CXL initialization,
> 
> What has changed since then?

I saw this subject line fly by and had the same thought, but now that I
come to read it there is a significant difference.

This is not "move cxl headers to new linux/cxl/ directory" this is
"rename existing cxl headers in include/linux/ to include/linux/cxl/".

Compare that to the proposal to move all drivers/cxl/*.h headers to
include/linux/.

Now, I do not think it makes sense to place these cross-driver cxl headers under
include/linux/cxl/, just place them under include/cxl/.

However, I do not understand the motivation. It's not like a new header
is being added and that is the final straw that merits moving the
existing headers. Most include/$subsys/ directories have more than 2
header files.

So what is the pain motivating this move?

  parent reply	other threads:[~2024-09-05  2:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-03 23:59 [PATCH 0/3 v3] cxl: Pull out mailbox bits to be independent of cxl_dev_state Dave Jiang
2024-09-03 23:59 ` [PATCH v3 1/3] cxl: Move mailbox related bits to the same context Dave Jiang
2024-09-04 16:30   ` Alison Schofield
2024-09-04 16:49     ` Dave Jiang
2024-09-03 23:59 ` [PATCH v3 2/3] cxl: Convert cxl_internal_send_cmd() to use 'struct cxl_mailbox' as input Dave Jiang
2024-09-03 23:59 ` [PATCH v3 3/3] cxl: move cxl headers to new linux/cxl/ directory Dave Jiang
2024-09-04  6:52   ` Alejandro Lucero Palau
2024-09-04 15:35     ` Dave Jiang
2024-09-05  2:55     ` Dan Williams [this message]
2024-09-05  6:51       ` Alejandro Lucero Palau
2024-09-05 20:21         ` Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66d91d844003d_286b294cf@dwillia2-xfh.jf.intel.com.notmuch \
    --to=dan.j.williams@intel.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=alejandro.lucero-palau@amd.com \
    --cc=alison.schofield@intel.com \
    --cc=alucerop@amd.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=fan.ni@samsung.com \
    --cc=ira.weiny@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox