Re: [PATCH v3 3/3] cxl: move cxl headers to new linux/cxl/ directory

[Alejandro Lucero Palau <alucerop@amd.com>]

On 9/5/24 03:55, Dan Williams wrote:
> Alejandro Lucero Palau wrote:
>> On 9/4/24 00:59, Dave Jiang wrote:
>>> Group all cxl related kernel headers into include/linux/cxl directory.
>>
>> I tried to do this in the RFC for Type2 support.
>>
>> I was told to just move the required bits for accel drivers able to do
>> CXL initialization,
>>
>> What has changed since then?
> I saw this subject line fly by and had the same thought, but now that I
> come to read it there is a significant difference.
>
> This is not "move cxl headers to new linux/cxl/ directory" this is
> "rename existing cxl headers in include/linux/ to include/linux/cxl/".
>
> Compare that to the proposal to move all drivers/cxl/*.h headers to
> include/linux/.


Right. My bad. I did just pay attention to the commit message.


>
> Now, I do not think it makes sense to place these cross-driver cxl headers under
> include/linux/cxl/, just place them under include/cxl/.


Not sure you are telling this to me or to Dave.

FWIW:

I have almost ready v3 and I'm adding headers to include/linux/cxl after 
this directory was created after v2.

As I understand it, include/linux implies headers to be used by kernel 
code, with headers to just include those to be used by user space.

The headers added in v3 are for accel drivers so it makes sense to me to 
be include/linux/cxl.


> However, I do not understand the motivation. It's not like a new header
> is being added and that is the final straw that merits moving the
> existing headers. Most include/$subsys/ directories have more than 2
> header files.
>
> So what is the pain motivating this move?