Linux CXL
 help / color / mirror / Atom feed
From: <dan.j.williams@intel.com>
To: Dave Jiang <dave.jiang@intel.com>, <linux-cxl@vger.kernel.org>
Cc: <dave@stgolabs.net>, <jonathan.cameron@huawei.com>,
	<alison.schofield@intel.com>, <vishal.l.verma@intel.com>,
	<ira.weiny@intel.com>, <dan.j.williams@intel.com>
Subject: Re: [PATCH] cxl/test: Address missing MODULE_DESCRIPTION warnings for cxl_test
Date: Thu, 1 May 2025 08:32:59 -0700	[thread overview]
Message-ID: <6813942baf2cb_29cd51007c@dwillia2-mobl4.notmuch> (raw)
In-Reply-To: <20250429235953.4175408-1-dave.jiang@intel.com>

Dave Jiang wrote:
> Add MODULE_DESCRIPTION() to address the following warnings:
> WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_mock.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_mock_mem.o
> 
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  tools/testing/cxl/test/cxl.c  | 1 +
>  tools/testing/cxl/test/mem.c  | 1 +
>  tools/testing/cxl/test/mock.c | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
> index 1c3336095923..eb36408d287a 100644
> --- a/tools/testing/cxl/test/cxl.c
> +++ b/tools/testing/cxl/test/cxl.c
> @@ -1527,5 +1527,6 @@ MODULE_PARM_DESC(interleave_arithmetic, "Modulo:0, XOR:1");
>  module_init(cxl_test_init);
>  module_exit(cxl_test_exit);
>  MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("CXL test setup module");

In all of these I would s/CXL test/cxl_test:/ to clarify the
relationship. Other than that:

Reviewed-by: Dan Williams <dan.j.williams@intel.com>

  parent reply	other threads:[~2025-05-01 15:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-29 23:59 [PATCH] cxl/test: Address missing MODULE_DESCRIPTION warnings for cxl_test Dave Jiang
2025-04-30  0:47 ` Alison Schofield
2025-05-01 15:32 ` dan.j.williams [this message]
2025-05-09 15:38 ` Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6813942baf2cb_29cd51007c@dwillia2-mobl4.notmuch \
    --to=dan.j.williams@intel.com \
    --cc=alison.schofield@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=ira.weiny@intel.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox