* [PATCH] cxl/test: Address missing MODULE_DESCRIPTION warnings for cxl_test
@ 2025-04-29 23:59 Dave Jiang
2025-04-30 0:47 ` Alison Schofield
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dave Jiang @ 2025-04-29 23:59 UTC (permalink / raw)
To: linux-cxl
Cc: dave, jonathan.cameron, alison.schofield, vishal.l.verma,
ira.weiny, dan.j.williams
Add MODULE_DESCRIPTION() to address the following warnings:
WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_test.o
WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_mock.o
WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_mock_mem.o
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
tools/testing/cxl/test/cxl.c | 1 +
tools/testing/cxl/test/mem.c | 1 +
tools/testing/cxl/test/mock.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
index 1c3336095923..eb36408d287a 100644
--- a/tools/testing/cxl/test/cxl.c
+++ b/tools/testing/cxl/test/cxl.c
@@ -1527,5 +1527,6 @@ MODULE_PARM_DESC(interleave_arithmetic, "Modulo:0, XOR:1");
module_init(cxl_test_init);
module_exit(cxl_test_exit);
MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("CXL test setup module");
MODULE_IMPORT_NS("ACPI");
MODULE_IMPORT_NS("CXL");
diff --git a/tools/testing/cxl/test/mem.c b/tools/testing/cxl/test/mem.c
index bf9caa908f89..32d47e3df22a 100644
--- a/tools/testing/cxl/test/mem.c
+++ b/tools/testing/cxl/test/mem.c
@@ -1909,4 +1909,5 @@ static struct platform_driver cxl_mock_mem_driver = {
module_platform_driver(cxl_mock_mem_driver);
MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("CXL test mem device mock module");
MODULE_IMPORT_NS("CXL");
diff --git a/tools/testing/cxl/test/mock.c b/tools/testing/cxl/test/mock.c
index af2594e4f35d..6147f0966ffd 100644
--- a/tools/testing/cxl/test/mock.c
+++ b/tools/testing/cxl/test/mock.c
@@ -312,5 +312,6 @@ void __wrap_cxl_dport_init_ras_reporting(struct cxl_dport *dport, struct device
EXPORT_SYMBOL_NS_GPL(__wrap_cxl_dport_init_ras_reporting, "CXL");
MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("CXL test emulation module");
MODULE_IMPORT_NS("ACPI");
MODULE_IMPORT_NS("CXL");
--
2.49.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] cxl/test: Address missing MODULE_DESCRIPTION warnings for cxl_test
2025-04-29 23:59 [PATCH] cxl/test: Address missing MODULE_DESCRIPTION warnings for cxl_test Dave Jiang
@ 2025-04-30 0:47 ` Alison Schofield
2025-05-01 15:32 ` dan.j.williams
2025-05-09 15:38 ` Dave Jiang
2 siblings, 0 replies; 4+ messages in thread
From: Alison Schofield @ 2025-04-30 0:47 UTC (permalink / raw)
To: Dave Jiang
Cc: linux-cxl, dave, jonathan.cameron, vishal.l.verma, ira.weiny,
dan.j.williams
On Tue, Apr 29, 2025 at 04:59:53PM -0700, Dave Jiang wrote:
> Add MODULE_DESCRIPTION() to address the following warnings:
> WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_mock.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_mock_mem.o
>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
snip
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cxl/test: Address missing MODULE_DESCRIPTION warnings for cxl_test
2025-04-29 23:59 [PATCH] cxl/test: Address missing MODULE_DESCRIPTION warnings for cxl_test Dave Jiang
2025-04-30 0:47 ` Alison Schofield
@ 2025-05-01 15:32 ` dan.j.williams
2025-05-09 15:38 ` Dave Jiang
2 siblings, 0 replies; 4+ messages in thread
From: dan.j.williams @ 2025-05-01 15:32 UTC (permalink / raw)
To: Dave Jiang, linux-cxl
Cc: dave, jonathan.cameron, alison.schofield, vishal.l.verma,
ira.weiny, dan.j.williams
Dave Jiang wrote:
> Add MODULE_DESCRIPTION() to address the following warnings:
> WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_mock.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_mock_mem.o
>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
> tools/testing/cxl/test/cxl.c | 1 +
> tools/testing/cxl/test/mem.c | 1 +
> tools/testing/cxl/test/mock.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
> index 1c3336095923..eb36408d287a 100644
> --- a/tools/testing/cxl/test/cxl.c
> +++ b/tools/testing/cxl/test/cxl.c
> @@ -1527,5 +1527,6 @@ MODULE_PARM_DESC(interleave_arithmetic, "Modulo:0, XOR:1");
> module_init(cxl_test_init);
> module_exit(cxl_test_exit);
> MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("CXL test setup module");
In all of these I would s/CXL test/cxl_test:/ to clarify the
relationship. Other than that:
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] cxl/test: Address missing MODULE_DESCRIPTION warnings for cxl_test
2025-04-29 23:59 [PATCH] cxl/test: Address missing MODULE_DESCRIPTION warnings for cxl_test Dave Jiang
2025-04-30 0:47 ` Alison Schofield
2025-05-01 15:32 ` dan.j.williams
@ 2025-05-09 15:38 ` Dave Jiang
2 siblings, 0 replies; 4+ messages in thread
From: Dave Jiang @ 2025-05-09 15:38 UTC (permalink / raw)
To: linux-cxl
Cc: dave, jonathan.cameron, alison.schofield, vishal.l.verma,
ira.weiny, dan.j.williams
On 4/29/25 4:59 PM, Dave Jiang wrote:
> Add MODULE_DESCRIPTION() to address the following warnings:
> WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_mock.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in test/cxl_mock_mem.o
>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Applied to cxl/next
> ---
> tools/testing/cxl/test/cxl.c | 1 +
> tools/testing/cxl/test/mem.c | 1 +
> tools/testing/cxl/test/mock.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
> index 1c3336095923..eb36408d287a 100644
> --- a/tools/testing/cxl/test/cxl.c
> +++ b/tools/testing/cxl/test/cxl.c
> @@ -1527,5 +1527,6 @@ MODULE_PARM_DESC(interleave_arithmetic, "Modulo:0, XOR:1");
> module_init(cxl_test_init);
> module_exit(cxl_test_exit);
> MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("CXL test setup module");
> MODULE_IMPORT_NS("ACPI");
> MODULE_IMPORT_NS("CXL");
> diff --git a/tools/testing/cxl/test/mem.c b/tools/testing/cxl/test/mem.c
> index bf9caa908f89..32d47e3df22a 100644
> --- a/tools/testing/cxl/test/mem.c
> +++ b/tools/testing/cxl/test/mem.c
> @@ -1909,4 +1909,5 @@ static struct platform_driver cxl_mock_mem_driver = {
>
> module_platform_driver(cxl_mock_mem_driver);
> MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("CXL test mem device mock module");
> MODULE_IMPORT_NS("CXL");
> diff --git a/tools/testing/cxl/test/mock.c b/tools/testing/cxl/test/mock.c
> index af2594e4f35d..6147f0966ffd 100644
> --- a/tools/testing/cxl/test/mock.c
> +++ b/tools/testing/cxl/test/mock.c
> @@ -312,5 +312,6 @@ void __wrap_cxl_dport_init_ras_reporting(struct cxl_dport *dport, struct device
> EXPORT_SYMBOL_NS_GPL(__wrap_cxl_dport_init_ras_reporting, "CXL");
>
> MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("CXL test emulation module");
> MODULE_IMPORT_NS("ACPI");
> MODULE_IMPORT_NS("CXL");
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-09 15:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-29 23:59 [PATCH] cxl/test: Address missing MODULE_DESCRIPTION warnings for cxl_test Dave Jiang
2025-04-30 0:47 ` Alison Schofield
2025-05-01 15:32 ` dan.j.williams
2025-05-09 15:38 ` Dave Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox