* [PATCH] cxl/test: remove unused function
@ 2025-11-18 18:22 alejandro.lucero-palau
2025-11-18 18:24 ` Dave Jiang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: alejandro.lucero-palau @ 2025-11-18 18:22 UTC (permalink / raw)
To: linux-cxl, dan.j.williams, dave.jiang; +Cc: Alejandro Lucero
From: Alejandro Lucero <alucerop@amd.com>
Since commit 733b57f262b0 __wrap_cxl_rcd_component_reg_phys()
is not necessary under mocking tests.
Signed-off-by: Alejandro Lucero <alucerop@amd.com>
---
tools/testing/cxl/Kbuild | 1 -
tools/testing/cxl/test/mock.c | 17 -----------------
2 files changed, 18 deletions(-)
diff --git a/tools/testing/cxl/Kbuild b/tools/testing/cxl/Kbuild
index d07f14cb7aa4..52736f611ea9 100644
--- a/tools/testing/cxl/Kbuild
+++ b/tools/testing/cxl/Kbuild
@@ -12,7 +12,6 @@ ldflags-y += --wrap=cxl_await_media_ready
ldflags-y += --wrap=cxl_hdm_decode_init
ldflags-y += --wrap=cxl_dvsec_rr_decode
ldflags-y += --wrap=devm_cxl_add_rch_dport
-ldflags-y += --wrap=cxl_rcd_component_reg_phys
ldflags-y += --wrap=cxl_endpoint_parse_cdat
ldflags-y += --wrap=cxl_dport_init_ras_reporting
diff --git a/tools/testing/cxl/test/mock.c b/tools/testing/cxl/test/mock.c
index 1989ae020df3..c471400116a1 100644
--- a/tools/testing/cxl/test/mock.c
+++ b/tools/testing/cxl/test/mock.c
@@ -268,23 +268,6 @@ struct cxl_dport *__wrap_devm_cxl_add_rch_dport(struct cxl_port *port,
}
EXPORT_SYMBOL_NS_GPL(__wrap_devm_cxl_add_rch_dport, "CXL");
-resource_size_t __wrap_cxl_rcd_component_reg_phys(struct device *dev,
- struct cxl_dport *dport)
-{
- int index;
- resource_size_t component_reg_phys;
- struct cxl_mock_ops *ops = get_cxl_mock_ops(&index);
-
- if (ops && ops->is_mock_port(dev))
- component_reg_phys = CXL_RESOURCE_NONE;
- else
- component_reg_phys = cxl_rcd_component_reg_phys(dev, dport);
- put_cxl_mock_ops(index);
-
- return component_reg_phys;
-}
-EXPORT_SYMBOL_NS_GPL(__wrap_cxl_rcd_component_reg_phys, "CXL");
-
void __wrap_cxl_endpoint_parse_cdat(struct cxl_port *port)
{
int index;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] cxl/test: remove unused function
2025-11-18 18:22 [PATCH] cxl/test: remove unused function alejandro.lucero-palau
@ 2025-11-18 18:24 ` Dave Jiang
2025-11-18 22:28 ` Ira Weiny
2025-11-18 22:49 ` Dave Jiang
2 siblings, 0 replies; 4+ messages in thread
From: Dave Jiang @ 2025-11-18 18:24 UTC (permalink / raw)
To: alejandro.lucero-palau, linux-cxl, dan.j.williams; +Cc: Alejandro Lucero
On 11/18/25 11:22 AM, alejandro.lucero-palau@amd.com wrote:
> From: Alejandro Lucero <alucerop@amd.com>
>
> Since commit 733b57f262b0 __wrap_cxl_rcd_component_reg_phys()
> is not necessary under mocking tests.
>
> Signed-off-by: Alejandro Lucero <alucerop@amd.com>
Thanks Alejandro
Reviewed-by: Dave Jiang <dave.jiang@intel.com>> ---
> tools/testing/cxl/Kbuild | 1 -
> tools/testing/cxl/test/mock.c | 17 -----------------
> 2 files changed, 18 deletions(-)
>
> diff --git a/tools/testing/cxl/Kbuild b/tools/testing/cxl/Kbuild
> index d07f14cb7aa4..52736f611ea9 100644
> --- a/tools/testing/cxl/Kbuild
> +++ b/tools/testing/cxl/Kbuild
> @@ -12,7 +12,6 @@ ldflags-y += --wrap=cxl_await_media_ready
> ldflags-y += --wrap=cxl_hdm_decode_init
> ldflags-y += --wrap=cxl_dvsec_rr_decode
> ldflags-y += --wrap=devm_cxl_add_rch_dport
> -ldflags-y += --wrap=cxl_rcd_component_reg_phys
> ldflags-y += --wrap=cxl_endpoint_parse_cdat
> ldflags-y += --wrap=cxl_dport_init_ras_reporting
>
> diff --git a/tools/testing/cxl/test/mock.c b/tools/testing/cxl/test/mock.c
> index 1989ae020df3..c471400116a1 100644
> --- a/tools/testing/cxl/test/mock.c
> +++ b/tools/testing/cxl/test/mock.c
> @@ -268,23 +268,6 @@ struct cxl_dport *__wrap_devm_cxl_add_rch_dport(struct cxl_port *port,
> }
> EXPORT_SYMBOL_NS_GPL(__wrap_devm_cxl_add_rch_dport, "CXL");
>
> -resource_size_t __wrap_cxl_rcd_component_reg_phys(struct device *dev,
> - struct cxl_dport *dport)
> -{
> - int index;
> - resource_size_t component_reg_phys;
> - struct cxl_mock_ops *ops = get_cxl_mock_ops(&index);
> -
> - if (ops && ops->is_mock_port(dev))
> - component_reg_phys = CXL_RESOURCE_NONE;
> - else
> - component_reg_phys = cxl_rcd_component_reg_phys(dev, dport);
> - put_cxl_mock_ops(index);
> -
> - return component_reg_phys;
> -}
> -EXPORT_SYMBOL_NS_GPL(__wrap_cxl_rcd_component_reg_phys, "CXL");
> -
> void __wrap_cxl_endpoint_parse_cdat(struct cxl_port *port)
> {
> int index;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cxl/test: remove unused function
2025-11-18 18:22 [PATCH] cxl/test: remove unused function alejandro.lucero-palau
2025-11-18 18:24 ` Dave Jiang
@ 2025-11-18 22:28 ` Ira Weiny
2025-11-18 22:49 ` Dave Jiang
2 siblings, 0 replies; 4+ messages in thread
From: Ira Weiny @ 2025-11-18 22:28 UTC (permalink / raw)
To: alejandro.lucero-palau, linux-cxl, dan.j.williams, dave.jiang
Cc: Alejandro Lucero
alejandro.lucero-palau@ wrote:
> From: Alejandro Lucero <alucerop@amd.com>
>
> Since commit 733b57f262b0 __wrap_cxl_rcd_component_reg_phys()
> is not necessary under mocking tests.
>
> Signed-off-by: Alejandro Lucero <alucerop@amd.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
[snip]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cxl/test: remove unused function
2025-11-18 18:22 [PATCH] cxl/test: remove unused function alejandro.lucero-palau
2025-11-18 18:24 ` Dave Jiang
2025-11-18 22:28 ` Ira Weiny
@ 2025-11-18 22:49 ` Dave Jiang
2 siblings, 0 replies; 4+ messages in thread
From: Dave Jiang @ 2025-11-18 22:49 UTC (permalink / raw)
To: alejandro.lucero-palau, linux-cxl, dan.j.williams; +Cc: Alejandro Lucero
On 11/18/25 11:22 AM, alejandro.lucero-palau@amd.com wrote:
> From: Alejandro Lucero <alucerop@amd.com>
>
> Since commit 733b57f262b0 __wrap_cxl_rcd_component_reg_phys()
> is not necessary under mocking tests.
>
> Signed-off-by: Alejandro Lucero <alucerop@amd.com>
Applied to cxl/next:
26c5b0d9c080 (for-6.19/cxl-misc) cxl/test: remove unused mock function for cxl_rcd_component_reg_phys()
> ---
> tools/testing/cxl/Kbuild | 1 -
> tools/testing/cxl/test/mock.c | 17 -----------------
> 2 files changed, 18 deletions(-)
>
> diff --git a/tools/testing/cxl/Kbuild b/tools/testing/cxl/Kbuild
> index d07f14cb7aa4..52736f611ea9 100644
> --- a/tools/testing/cxl/Kbuild
> +++ b/tools/testing/cxl/Kbuild
> @@ -12,7 +12,6 @@ ldflags-y += --wrap=cxl_await_media_ready
> ldflags-y += --wrap=cxl_hdm_decode_init
> ldflags-y += --wrap=cxl_dvsec_rr_decode
> ldflags-y += --wrap=devm_cxl_add_rch_dport
> -ldflags-y += --wrap=cxl_rcd_component_reg_phys
> ldflags-y += --wrap=cxl_endpoint_parse_cdat
> ldflags-y += --wrap=cxl_dport_init_ras_reporting
>
> diff --git a/tools/testing/cxl/test/mock.c b/tools/testing/cxl/test/mock.c
> index 1989ae020df3..c471400116a1 100644
> --- a/tools/testing/cxl/test/mock.c
> +++ b/tools/testing/cxl/test/mock.c
> @@ -268,23 +268,6 @@ struct cxl_dport *__wrap_devm_cxl_add_rch_dport(struct cxl_port *port,
> }
> EXPORT_SYMBOL_NS_GPL(__wrap_devm_cxl_add_rch_dport, "CXL");
>
> -resource_size_t __wrap_cxl_rcd_component_reg_phys(struct device *dev,
> - struct cxl_dport *dport)
> -{
> - int index;
> - resource_size_t component_reg_phys;
> - struct cxl_mock_ops *ops = get_cxl_mock_ops(&index);
> -
> - if (ops && ops->is_mock_port(dev))
> - component_reg_phys = CXL_RESOURCE_NONE;
> - else
> - component_reg_phys = cxl_rcd_component_reg_phys(dev, dport);
> - put_cxl_mock_ops(index);
> -
> - return component_reg_phys;
> -}
> -EXPORT_SYMBOL_NS_GPL(__wrap_cxl_rcd_component_reg_phys, "CXL");
> -
> void __wrap_cxl_endpoint_parse_cdat(struct cxl_port *port)
> {
> int index;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-11-18 22:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-18 18:22 [PATCH] cxl/test: remove unused function alejandro.lucero-palau
2025-11-18 18:24 ` Dave Jiang
2025-11-18 22:28 ` Ira Weiny
2025-11-18 22:49 ` Dave Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox