Re: [PATCH] cxl/core/region_dax.c: fix missing assignment in cxl_dax_region_alloc()

[Ira Weiny <ira.weiny@intel.com>]

Anisa Su wrote:
> cxlr->cxlr_dax assignment was dropped during refactor.
> 
> Fixes: d747cf98f091 cxl/core/region: move dax region device logic into
> region_dax.c

I don't believe this is a valid fixes tag.

Looking only at commit d747cf98f091, this line does not appear in the
original function...

-static struct cxl_dax_region *cxl_dax_region_alloc(struct cxl_region *cxlr)
-{
-       struct cxl_region_params *p = &cxlr->params;
-       struct cxl_dax_region *cxlr_dax;
-       struct device *dev;
-
-       guard(rwsem_read)(&cxl_rwsem.region);
-       if (p->state != CXL_CONFIG_COMMIT)
-               return ERR_PTR(-ENXIO);
-
-       cxlr_dax = kzalloc_obj(*cxlr_dax);
-       if (!cxlr_dax)
-               return ERR_PTR(-ENOMEM);
-
-       cxlr_dax->hpa_range.start = p->res->start;
-       cxlr_dax->hpa_range.end = p->res->end;
-
-       dev = &cxlr_dax->dev;
-       cxlr_dax->cxlr = cxlr;
-       device_initialize(dev);
-       lockdep_set_class(&dev->mutex, &cxl_dax_region_key);
-       device_set_pm_not_required(dev);
-       dev->parent = &cxlr->dev;
-       dev->bus = &cxl_bus_type;
-       dev->type = &cxl_dax_region_type;
-
-       return cxlr_dax;
-}


Furthermore, I don't see where this line ever appeared in
cxl_dax_region_alloc() prior to commit d747cf98f091.

So what is the purpose of this change?

Ira


> Signed-off-by: Anisa Su <anisa.su@samsung.com>
> ---
>  drivers/cxl/core/region_dax.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cxl/core/region_dax.c b/drivers/cxl/core/region_dax.c
> index de04f78f6ad8..068690d02c8c 100644
> --- a/drivers/cxl/core/region_dax.c
> +++ b/drivers/cxl/core/region_dax.c
> @@ -62,6 +62,7 @@ static struct cxl_dax_region *cxl_dax_region_alloc(struct cxl_region *cxlr)
>  
>  	dev = &cxlr_dax->dev;
>  	cxlr_dax->cxlr = cxlr;
> +	cxlr->cxlr_dax = cxlr_dax;
>  	device_initialize(dev);
>  	lockdep_set_class(&dev->mutex, &cxl_dax_region_key);
>  	device_set_pm_not_required(dev);
> -- 
> 2.43.0
>