public inbox for linux-cxl@vger.kernel.org
 help / color / mirror / Atom feed
From: Ira Weiny <ira.weiny@intel.com>
To: Anisa Su <anisa.su887@gmail.com>, Ira Weiny <ira.weiny@intel.com>
Cc: Anisa Su <anisa.su887@gmail.com>, <dave.jiang@intel.com>,
	<gourry@gourry.net>, <dave@stgolabs.net>,
	<jonathan.cameron@huawei.com>, <alison.schofield@intel.com>,
	<linux-cxl@vger.kernel.org>, <djbw@kernel.org>
Subject: Re: [PATCH] cxl/core/region_dax.c: fix missing assignment in cxl_dax_region_alloc()
Date: Fri, 17 Apr 2026 15:39:38 -0500	[thread overview]
Message-ID: <69e29a8a9264b_5c5981005@iweiny-mobl.notmuch> (raw)
In-Reply-To: <aeJrI1S5omou28MQ@4470NRD-ASU.ssi.samsung.com>

Anisa Su wrote:
> On Thu, Apr 16, 2026 at 07:23:58PM -0500, Ira Weiny wrote:
> >> Anisa Su wrote:
> > > cxlr->cxlr_dax assignment was dropped during refactor.
> > > 
> > > Fixes: d747cf98f091 cxl/core/region: move dax region device logic into
> > > region_dax.c
> > 
> > I don't believe this is a valid fixes tag.
> > 
> > Looking only at commit d747cf98f091, this line does not appear in the
> > original function...
> > 
> yeah it's not, sorry :((( the assignment was added in the dcd patches and I
> dropped it while resolving the conflicts during the rebase cuz I was just in a
> rush to finish it
> 
> I realized the error and said "pls ignore it I was wrong" in the original thread here:
> https://lore.kernel.org/linux-cxl/ad0hJ1q5Lp5mckt1@4470NRD-ASU.ssi.samsung.com/T/#u
> 
> but I definitely should have mentioned it here too. anyway sorry, just pretend
> I never said anything

Got it, no problem.

Thanks,
Ira

  parent reply	other threads:[~2026-04-17 20:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-11  1:11 [PATCH] cxl/core/region_dax.c: fix missing assignment in cxl_dax_region_alloc() Anisa Su
2026-04-17  0:23 ` Ira Weiny
2026-04-17 17:17   ` Anisa Su
2026-04-17 20:38     ` Ira Weiny
2026-04-17 20:39     ` Ira Weiny [this message]
2026-04-17 20:35 ` kernel test robot
2026-04-18  4:09 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69e29a8a9264b_5c5981005@iweiny-mobl.notmuch \
    --to=ira.weiny@intel.com \
    --cc=alison.schofield@intel.com \
    --cc=anisa.su887@gmail.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=djbw@kernel.org \
    --cc=gourry@gourry.net \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox