Linux CXL
 help / color / mirror / Atom feed
From: Gregory Price <gregory.price@memverge.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Gregory Price <gourry.memverge@gmail.com>,
	qemu-devel@nongnu.org, linux-cxl@vger.kernel.org,
	Alison Schofield <alison.schofield@intel.com>,
	"a.manzanares@samsung.com" <a.manzanares@samsung.com>,
	Ben Widawsky <bwidawsk@kernel.org>
Subject: Re: [PATCH RFC] hw/cxl: type 3 devices can now present volatile or persistent memory
Date: Tue, 11 Oct 2022 13:22:40 -0400	[thread overview]
Message-ID: <Y0WmYNcVHhVHeyH+@memverge.com> (raw)
In-Reply-To: <20221011171438.fwlgobgaegns3p7t@offworld>


I'll push the patches to qemu-cxl and linux-cxl today or tomorrow, I
wanted to get them into a state on gitlab for Jonathan to rebase and
merge into his work.  He'll likely end up pushing the entire series at
the end of the day.

Will update the tests/docs accordingly.

re: changelog - i'm new to mailing list contributions, where would these
go exactly?


On Tue, Oct 11, 2022 at 10:14:38AM -0700, Davidlohr Bueso wrote:
> On Mon, 10 Oct 2022, Gregory Price wrote:
> 
> > I've pushed 5 new commits to this branch here (@Jonathan I've also made
> > a merge request to pull them into your branch).
> > 
> > https://gitlab.com/gourry.memverge/qemu/-/commits/cxl-2022-10-09
> 
> This series could perhaps be posted as a reply to the CDAT extensions
> cover letter. But regardless, at some point it should be in linux-cxl@.
> 
> > 
> > They're built on top of Jonathan's extensions for the CDAT since the
> > CDAT has memory region relevant entries and trying to do this separate
> > would be unwise.
> > 
> > 1/5: PCI_CLASS_MEMORY_CXL patch
> > 2/5: CXL_CAPACITY_MULTIPLIER pullout patch (@Davidlohr request)
> 
> Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
> 
> However this needs a changelog; for however redundant it may be.
> 
> > 3/5: Generalizes CDATDsmas intialization ahead of multi-region
> 
> > 4/5: Multi-region support w/ backward compatibility
> >     * Requires extra eyes for CDAT and Read/Write Change Validation*
> 
> I'm still eyeballing this but it certainly looks much more complete now -
> at least with the minimal support I was hoping for.
> 
> > 5/5: Test and documentation update
> 
> I think that there should two examples here with volatile and LSA usage.
> The first is without as it is quite unintuitive otherwise, then a
> second example with specifying the lba. Also in these cases you want
> id=cxl-vmem0. And the documentation should be updated to mention that
> memdev is deprecated and {persistent/volatile}-memdev should be used.
> 
> Thanks,
> Davidlohr

  reply	other threads:[~2022-10-11 17:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20221006000103.49542-1-gregory.price@memverge.com>
2022-10-06  8:45 ` [PATCH RFC] hw/cxl: type 3 devices can now present volatile or persistent memory Jonathan Cameron
2022-10-06  8:50   ` Jonathan Cameron
2022-10-06 15:52     ` Gregory Price
2022-10-06 16:42       ` Jonathan Cameron
2022-10-06 17:29         ` Gregory Price
2022-10-10 14:43           ` Jonathan Cameron
2022-10-10 15:20             ` Gregory Price
2022-10-10 16:26               ` Jonathan Cameron
2022-10-10 16:32             ` Jonathan Cameron
2022-10-10 17:18             ` Davidlohr Bueso
     [not found]           ` <CAD3UvdT1ZHJDaqj05C+n7t4rM7yhjZyM6fooXAfG12rAYnBqmw@mail.gmail.com>
2022-10-10 15:18             ` Jonathan Cameron
2022-10-10 15:25               ` Gregory Price
2022-10-11  1:23                 ` Gregory Price
2022-10-11 17:14                   ` Davidlohr Bueso
2022-10-11 17:22                     ` Gregory Price [this message]
2022-10-11 17:28                       ` Jonathan Cameron
2022-10-07 18:16         ` Davidlohr Bueso
2022-10-07 18:46           ` Gregory Price
2022-10-07 19:55             ` Davidlohr Bueso
2022-10-07 19:52     ` Davidlohr Bueso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y0WmYNcVHhVHeyH+@memverge.com \
    --to=gregory.price@memverge.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=a.manzanares@samsung.com \
    --cc=alison.schofield@intel.com \
    --cc=bwidawsk@kernel.org \
    --cc=dave@stgolabs.net \
    --cc=gourry.memverge@gmail.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox