From: Christoph Hellwig <hch@infradead.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-cxl@vger.kernel.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Dave Jiang <dave.jiang@intel.com>
Subject: Re: [PATCH] cxl/pci: Remove endian confusion
Date: Wed, 7 Dec 2022 09:01:41 -0800 [thread overview]
Message-ID: <Y5DG9X4270iVaRm4@infradead.org> (raw)
In-Reply-To: <167030092025.4045167.10651070153523351093.stgit@dwillia2-xfh.jf.intel.com>
On Mon, Dec 05, 2022 at 08:28:40PM -0800, Dan Williams wrote:
> - status = le32_to_cpu((__force __le32)readl(addr));
> + status = readl(addr);
Those force casts should have been a giant warning flag..
prev parent reply other threads:[~2022-12-07 17:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 4:28 [PATCH] cxl/pci: Remove endian confusion Dan Williams
2022-12-06 6:43 ` Ira Weiny
2022-12-06 9:50 ` Jonathan Cameron
2022-12-06 17:04 ` Dave Jiang
2022-12-07 17:01 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5DG9X4270iVaRm4@infradead.org \
--to=hch@infradead.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-cxl@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox