[PATCH] cxl: Add Support for Get Timestamp

Linux CXL
 help / color / mirror / Atom feed

* [PATCH] cxl: Add Support for Get Timestamp
@ 2023-08-29 15:20 Davidlohr Bueso
  2023-08-30 11:03 ` Jonathan Cameron
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Davidlohr Bueso @ 2023-08-29 15:20 UTC (permalink / raw)
  To: dan.j.williams
  Cc: jonathan.cameron, dave.jiang, alison.schofield, vishal.l.verma,
	ira.weiny, deepak.ukey, sathya.m, d.palani, fan.ni, a.manzanares,
	dave, linux-cxl

Add the call to the UAPI such that userspace may corelate the
timestamps from the device log with system wall time, if, for
example there's any sort of inaccuracy or skew in the device.

Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
---
 drivers/cxl/core/mbox.c      | 1 +
 drivers/cxl/cxlmem.h         | 1 +
 include/uapi/linux/cxl_mem.h | 1 +
 3 files changed, 3 insertions(+)

diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
index ca60bb8114f2..2444faac1e4c 100644
--- a/drivers/cxl/core/mbox.c
+++ b/drivers/cxl/core/mbox.c
@@ -63,6 +63,7 @@ static struct cxl_mem_command cxl_mem_commands[CXL_MEM_COMMAND_ID_MAX] = {
 	CXL_CMD(GET_SHUTDOWN_STATE, 0, 0x1, 0),
 	CXL_CMD(SET_SHUTDOWN_STATE, 0x1, 0, 0),
 	CXL_CMD(GET_SCAN_MEDIA_CAPS, 0x10, 0x4, 0),
+	CXL_CMD(GET_TIMESTAMP, 0, 0x8, 0),
 };
 
 /*
diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h
index 706f8a6d1ef4..ec6dfcc7bb99 100644
--- a/drivers/cxl/cxlmem.h
+++ b/drivers/cxl/cxlmem.h
@@ -500,6 +500,7 @@ enum cxl_opcode {
 	CXL_MBOX_OP_GET_FW_INFO		= 0x0200,
 	CXL_MBOX_OP_TRANSFER_FW		= 0x0201,
 	CXL_MBOX_OP_ACTIVATE_FW		= 0x0202,
+	CXL_MBOX_OP_GET_TIMESTAMP	= 0x0300,
 	CXL_MBOX_OP_SET_TIMESTAMP	= 0x0301,
 	CXL_MBOX_OP_GET_SUPPORTED_LOGS	= 0x0400,
 	CXL_MBOX_OP_GET_LOG		= 0x0401,
diff --git a/include/uapi/linux/cxl_mem.h b/include/uapi/linux/cxl_mem.h
index 14bc6e742148..42066f4eb890 100644
--- a/include/uapi/linux/cxl_mem.h
+++ b/include/uapi/linux/cxl_mem.h
@@ -46,6 +46,7 @@
 	___C(GET_SCAN_MEDIA_CAPS, "Get Scan Media Capabilities"),         \
 	___DEPRECATED(SCAN_MEDIA, "Scan Media"),                          \
 	___DEPRECATED(GET_SCAN_MEDIA, "Get Scan Media Results"),          \
+	___C(GET_TIMESTAMP, "Get Timestamp"),                             \
 	___C(MAX, "invalid / last command")
 
 #define ___C(a, b) CXL_MEM_COMMAND_ID_##a
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] cxl: Add Support for Get Timestamp
  2023-08-29 15:20 [PATCH] cxl: Add Support for Get Timestamp Davidlohr Bueso
@ 2023-08-30 11:03 ` Jonathan Cameron
  2023-08-30 17:37 ` Dave Jiang
  2023-09-28  1:22 ` Davidlohr Bueso
  2 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2023-08-30 11:03 UTC (permalink / raw)
  To: Davidlohr Bueso
  Cc: dan.j.williams, dave.jiang, alison.schofield, vishal.l.verma,
	ira.weiny, deepak.ukey, sathya.m, d.palani, fan.ni, a.manzanares,
	linux-cxl

On Tue, 29 Aug 2023 08:20:14 -0700
Davidlohr Bueso <dave@stgolabs.net> wrote:

> Add the call to the UAPI such that userspace may corelate the
> timestamps from the device log with system wall time, if, for
> example there's any sort of inaccuracy or skew in the device.
> 
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>

Seems sensible to me.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
>  drivers/cxl/core/mbox.c      | 1 +
>  drivers/cxl/cxlmem.h         | 1 +
>  include/uapi/linux/cxl_mem.h | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> index ca60bb8114f2..2444faac1e4c 100644
> --- a/drivers/cxl/core/mbox.c
> +++ b/drivers/cxl/core/mbox.c
> @@ -63,6 +63,7 @@ static struct cxl_mem_command cxl_mem_commands[CXL_MEM_COMMAND_ID_MAX] = {
>  	CXL_CMD(GET_SHUTDOWN_STATE, 0, 0x1, 0),
>  	CXL_CMD(SET_SHUTDOWN_STATE, 0x1, 0, 0),
>  	CXL_CMD(GET_SCAN_MEDIA_CAPS, 0x10, 0x4, 0),
> +	CXL_CMD(GET_TIMESTAMP, 0, 0x8, 0),
>  };
>  
>  /*
> diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h
> index 706f8a6d1ef4..ec6dfcc7bb99 100644
> --- a/drivers/cxl/cxlmem.h
> +++ b/drivers/cxl/cxlmem.h
> @@ -500,6 +500,7 @@ enum cxl_opcode {
>  	CXL_MBOX_OP_GET_FW_INFO		= 0x0200,
>  	CXL_MBOX_OP_TRANSFER_FW		= 0x0201,
>  	CXL_MBOX_OP_ACTIVATE_FW		= 0x0202,
> +	CXL_MBOX_OP_GET_TIMESTAMP	= 0x0300,
>  	CXL_MBOX_OP_SET_TIMESTAMP	= 0x0301,
>  	CXL_MBOX_OP_GET_SUPPORTED_LOGS	= 0x0400,
>  	CXL_MBOX_OP_GET_LOG		= 0x0401,
> diff --git a/include/uapi/linux/cxl_mem.h b/include/uapi/linux/cxl_mem.h
> index 14bc6e742148..42066f4eb890 100644
> --- a/include/uapi/linux/cxl_mem.h
> +++ b/include/uapi/linux/cxl_mem.h
> @@ -46,6 +46,7 @@
>  	___C(GET_SCAN_MEDIA_CAPS, "Get Scan Media Capabilities"),         \
>  	___DEPRECATED(SCAN_MEDIA, "Scan Media"),                          \
>  	___DEPRECATED(GET_SCAN_MEDIA, "Get Scan Media Results"),          \
> +	___C(GET_TIMESTAMP, "Get Timestamp"),                             \
>  	___C(MAX, "invalid / last command")
>  
>  #define ___C(a, b) CXL_MEM_COMMAND_ID_##a


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] cxl: Add Support for Get Timestamp
  2023-08-29 15:20 [PATCH] cxl: Add Support for Get Timestamp Davidlohr Bueso
  2023-08-30 11:03 ` Jonathan Cameron
@ 2023-08-30 17:37 ` Dave Jiang
  2023-09-28  1:22 ` Davidlohr Bueso
  2 siblings, 0 replies; 4+ messages in thread
From: Dave Jiang @ 2023-08-30 17:37 UTC (permalink / raw)
  To: Davidlohr Bueso, dan.j.williams
  Cc: jonathan.cameron, alison.schofield, vishal.l.verma, ira.weiny,
	deepak.ukey, sathya.m, d.palani, fan.ni, a.manzanares, linux-cxl



On 8/29/23 08:20, Davidlohr Bueso wrote:
> Add the call to the UAPI such that userspace may corelate the
> timestamps from the device log with system wall time, if, for
> example there's any sort of inaccuracy or skew in the device.
> 
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>   drivers/cxl/core/mbox.c      | 1 +
>   drivers/cxl/cxlmem.h         | 1 +
>   include/uapi/linux/cxl_mem.h | 1 +
>   3 files changed, 3 insertions(+)
> 
> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> index ca60bb8114f2..2444faac1e4c 100644
> --- a/drivers/cxl/core/mbox.c
> +++ b/drivers/cxl/core/mbox.c
> @@ -63,6 +63,7 @@ static struct cxl_mem_command cxl_mem_commands[CXL_MEM_COMMAND_ID_MAX] = {
>   	CXL_CMD(GET_SHUTDOWN_STATE, 0, 0x1, 0),
>   	CXL_CMD(SET_SHUTDOWN_STATE, 0x1, 0, 0),
>   	CXL_CMD(GET_SCAN_MEDIA_CAPS, 0x10, 0x4, 0),
> +	CXL_CMD(GET_TIMESTAMP, 0, 0x8, 0),
>   };
>   
>   /*
> diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h
> index 706f8a6d1ef4..ec6dfcc7bb99 100644
> --- a/drivers/cxl/cxlmem.h
> +++ b/drivers/cxl/cxlmem.h
> @@ -500,6 +500,7 @@ enum cxl_opcode {
>   	CXL_MBOX_OP_GET_FW_INFO		= 0x0200,
>   	CXL_MBOX_OP_TRANSFER_FW		= 0x0201,
>   	CXL_MBOX_OP_ACTIVATE_FW		= 0x0202,
> +	CXL_MBOX_OP_GET_TIMESTAMP	= 0x0300,
>   	CXL_MBOX_OP_SET_TIMESTAMP	= 0x0301,
>   	CXL_MBOX_OP_GET_SUPPORTED_LOGS	= 0x0400,
>   	CXL_MBOX_OP_GET_LOG		= 0x0401,
> diff --git a/include/uapi/linux/cxl_mem.h b/include/uapi/linux/cxl_mem.h
> index 14bc6e742148..42066f4eb890 100644
> --- a/include/uapi/linux/cxl_mem.h
> +++ b/include/uapi/linux/cxl_mem.h
> @@ -46,6 +46,7 @@
>   	___C(GET_SCAN_MEDIA_CAPS, "Get Scan Media Capabilities"),         \
>   	___DEPRECATED(SCAN_MEDIA, "Scan Media"),                          \
>   	___DEPRECATED(GET_SCAN_MEDIA, "Get Scan Media Results"),          \
> +	___C(GET_TIMESTAMP, "Get Timestamp"),                             \
>   	___C(MAX, "invalid / last command")
>   
>   #define ___C(a, b) CXL_MEM_COMMAND_ID_##a

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] cxl: Add Support for Get Timestamp
  2023-08-29 15:20 [PATCH] cxl: Add Support for Get Timestamp Davidlohr Bueso
  2023-08-30 11:03 ` Jonathan Cameron
  2023-08-30 17:37 ` Dave Jiang
@ 2023-09-28  1:22 ` Davidlohr Bueso
  2 siblings, 0 replies; 4+ messages in thread
From: Davidlohr Bueso @ 2023-09-28  1:22 UTC (permalink / raw)
  To: dan.j.williams
  Cc: jonathan.cameron, dave.jiang, alison.schofield, vishal.l.verma,
	ira.weiny, deepak.ukey, sathya.m, d.palani, fan.ni, a.manzanares,
	linux-cxl

ping? Unless any objections, can this be picked up?

On Tue, 29 Aug 2023, Davidlohr Bueso wrote:

>Add the call to the UAPI such that userspace may corelate the
>timestamps from the device log with system wall time, if, for
>example there's any sort of inaccuracy or skew in the device.
>
>Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
3B>---
> drivers/cxl/core/mbox.c      | 1 +
> drivers/cxl/cxlmem.h         | 1 +
> include/uapi/linux/cxl_mem.h | 1 +
> 3 files changed, 3 insertions(+)
>
>diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
>index ca60bb8114f2..2444faac1e4c 100644
>--- a/drivers/cxl/core/mbox.c
>+++ b/drivers/cxl/core/mbox.c
>@@ -63,6 +63,7 @@ static struct cxl_mem_command cxl_mem_commands[CXL_MEM_COMMAND_ID_MAX] = {
>	CXL_CMD(GET_SHUTDOWN_STATE, 0, 0x1, 0),
>	CXL_CMD(SET_SHUTDOWN_STATE, 0x1, 0, 0),
>	CXL_CMD(GET_SCAN_MEDIA_CAPS, 0x10, 0x4, 0),
>+	CXL_CMD(GET_TIMESTAMP, 0, 0x8, 0),
> };
>
> /*
>diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h
>index 706f8a6d1ef4..ec6dfcc7bb99 100644
>--- a/drivers/cxl/cxlmem.h
>+++ b/drivers/cxl/cxlmem.h
>@@ -500,6 +500,7 @@ enum cxl_opcode {
>	CXL_MBOX_OP_GET_FW_INFO		= 0x0200,
>	CXL_MBOX_OP_TRANSFER_FW		= 0x0201,
>	CXL_MBOX_OP_ACTIVATE_FW		= 0x0202,
>+	CXL_MBOX_OP_GET_TIMESTAMP	= 0x0300,
>	CXL_MBOX_OP_SET_TIMESTAMP	= 0x0301,
>	CXL_MBOX_OP_GET_SUPPORTED_LOGS	= 0x0400,
>	CXL_MBOX_OP_GET_LOG		= 0x0401,
>diff --git a/include/uapi/linux/cxl_mem.h b/include/uapi/linux/cxl_mem.h
>index 14bc6e742148..42066f4eb890 100644
>--- a/include/uapi/linux/cxl_mem.h
>+++ b/include/uapi/linux/cxl_mem.h
>@@ -46,6 +46,7 @@
>	___C(GET_SCAN_MEDIA_CAPS, "Get Scan Media Capabilities"),         \
>	___DEPRECATED(SCAN_MEDIA, "Scan Media"),                          \
>	___DEPRECATED(GET_SCAN_MEDIA, "Get Scan Media Results"),          \
>+	___C(GET_TIMESTAMP, "Get Timestamp"),                             \
>	___C(MAX, "invalid / last command")
>
> #define ___C(a, b) CXL_MEM_COMMAND_ID_##a
>--
>2.41.0
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-09-28  1:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-29 15:20 [PATCH] cxl: Add Support for Get Timestamp Davidlohr Bueso
2023-08-30 11:03 ` Jonathan Cameron
2023-08-30 17:37 ` Dave Jiang
2023-09-28  1:22 ` Davidlohr Bueso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox