Re: [ndctl PATCH 1/2] README.md: add CONFIG_s missing to pass NFIT tests

[Alison Schofield <alison.schofield@intel.com>]

On Wed, May 21, 2025 at 12:26:39AM +0000, marc.herbert@linux.intel.com wrote:
> From: Marc Herbert <marc.herbert@linux.intel.com>
> 
> Found by trial and error. As of kernel v6.15, the CONFIG_s in this
> version are enough to give to ./scripts/kconfig/merge_config.sh and pass
> `meson test --suite=ndctl:ndctl` and `meson test --suite=ndctl:dax`
> 
> This has been manually tested with only `make defconfig ARCH=x86_64` as
> a starting point. This is admittedly incomplete test coverage but still
> a massively better starting point for other ARCHs and a big time
> saver. There's a good chance it's enough for other ARCHs too.

Thanks for doing this Marc! 

I'm wondering about the need to delineate between what is needed to load
and use the cxl-test or nfit-test modules as opposed to what is required to
run all the unit tests.

I believe my environment, and yours, and most other folks using these
environments are doing so in a VM so it's no big deal to load up all the
things.

Maybe just a gentle separator in the list showing required and optional.
I would NOT go so far as to pick apart which ones are needed for which
test because that is a slippery slope. If a user is in test running mode
they need all the things.

> 
> Link: https://lore.kernel.org/nvdimm/aed71134-1029-4b88-ab20-8dfa527a7438@linux.intel.com/
> Signed-off-by: Marc Herbert <marc.herbert@linux.intel.com>
> ---
>  README.md | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/README.md b/README.md
> index db25a9114402..a37991ccefa2 100644
> --- a/README.md
> +++ b/README.md
> @@ -69,10 +69,20 @@ loaded.  To build and install nfit_test.ko:
>     CONFIG_NVDIMM_PFN=y
>     CONFIG_NVDIMM_DAX=y
>     CONFIG_DEV_DAX_PMEM=m
> +   CONFIG_FS_DAX=y
> +   CONFIG_XFS_FS=y
> +   CONFIG_DAX=m
> +   CONFIG_DEV_DAX=m
>     CONFIG_ENCRYPTED_KEYS=y
>     CONFIG_NVDIMM_SECURITY_TEST=y
>     CONFIG_STRICT_DEVMEM=y
>     CONFIG_IO_STRICT_DEVMEM=y
> +   CONFIG_ACPI_NFIT=m
> +   CONFIG_NFIT_SECURITY_DEBUG=y
> +   CONFIG_MEMORY_FAILURE=y
> +   CONFIG_MEMORY_HOTPLUG=y
> +   CONFIG_MEMORY_HOTREMOVE=y
> +   CONFIG_TRANSPARENT_HUGEPAGE=y
>     ```
>  
>  1. Build and install the unit test enabled libnvdimm modules in the
> -- 
> 2.49.0
>