Linux CXL
 help / color / mirror / Atom feed
From: Alison Schofield <alison.schofield@intel.com>
To: Marc Herbert <Marc.Herbert@linux.intel.com>
Cc: <linux-cxl@vger.kernel.org>, <nvdimm@lists.linux.dev>,
	<dan.j.williams@intel.com>
Subject: Re: [ndctl PATCH 1/2] README.md: add CONFIG_s missing to pass NFIT tests
Date: Wed, 28 May 2025 19:44:23 -0700	[thread overview]
Message-ID: <aDfKB3juX-F5Cld5@aschofie-mobl2.lan> (raw)
In-Reply-To: <5c712edf-3cc5-4707-8a5d-472ede773b6f@linux.intel.com>

On Thu, May 22, 2025 at 07:47:56AM -0700, Marc Herbert wrote:
> On 2025-05-21 21:47, Alison Schofield wrote:
> 
> > Thanks for doing this Marc! 
> > 
> > I'm wondering about the need to delineate between what is needed to load
> > and use the cxl-test or nfit-test modules as opposed to what is required to
> > run all the unit tests.
> > 
> > I believe my environment, and yours, and most other folks using these
> > environments are doing so in a VM so it's no big deal to load up all the
> > things.
> > 
> > Maybe just a gentle separator in the list showing required and optional.
> 
> I unfortunately don't know and understand these enough to remember that
> and it would be very time-consuming to re-test them one by one.
> 
> More generally speaking, this sort of list looks deceptively simple but
> it almost never is. That's basically why I initially asked in
> https://lore.kernel.org/nvdimm/aed71134-1029-4b88-ab20-8dfa527a7438@linux.intel.com/
> if someone more knowledgeable could do this (based on the
> run_qemu.git/.github/workflows/*.cfg files) Also, this stuff tends to
> evolve.
> 
> Now that tested versions can be found in run_qemu.bit, it's less
> critical to update this README.md file. The current README.md version is
> inconveniently non working but at least some functional versions can be
> found somewhere else.

Hi Marc,

As you probably just got notified, I went ahead and massaged this one and
applied to pending:
https://github.com/pmem/ndctl/commit/fb2f28cd280c69a978753e54a0f67267e54ffbda

There is clear agreement on the great need for this as we encourage
more folks to join the cxl-test club. My comment about module vs unit
test was a no-op because the README, it turns out, made no mention of
that. I did pause a few times on the README and say to myself, 'oh that
needs updating' but decided to get this out and come back around for
better later.

I'm going to ping Dan directly for an ACK, since he promised :)

If there is any issue on pending I'm happy to fix it up. I'm planning
to make the v82 release June 11-ish.

-- Alison

> 
> Cheers,
> 
> Marc

      reply	other threads:[~2025-05-29  2:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-21  0:26 [ndctl PATCH 1/2] README.md: add CONFIG_s missing to pass NFIT tests marc.herbert
2025-05-21  0:26 ` [ndctl PATCH 2/2] README.md: add CONFIG_s missing to pass CXL tests marc.herbert
2025-05-22  4:47 ` [ndctl PATCH 1/2] README.md: add CONFIG_s missing to pass NFIT tests Alison Schofield
2025-05-22 14:47   ` Marc Herbert
2025-05-29  2:44     ` Alison Schofield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aDfKB3juX-F5Cld5@aschofie-mobl2.lan \
    --to=alison.schofield@intel.com \
    --cc=Marc.Herbert@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox