From: Alison Schofield <alison.schofield@intel.com>
To: <marc.herbert@linux.intel.com>
Cc: <linux-cxl@vger.kernel.org>, <nvdimm@lists.linux.dev>,
Dan Williams <dan.j.williams@intel.com>,
Dave Jiang <dave.jiang@intel.com>
Subject: Re: [ndctl PATCH v2] test: set the $CXL environment variable in meson.build
Date: Tue, 13 May 2025 17:51:10 -0700 [thread overview]
Message-ID: <aCPo_u0wOljHCigP@aschofie-mobl2.lan> (raw)
In-Reply-To: <20250508183142.743047-1-marc.herbert@linux.intel.com>
On Thu, May 08, 2025 at 06:31:42PM +0000, marc.herbert@linux.intel.com wrote:
> From: Marc Herbert <marc.herbert@linux.intel.com>
>
> This fixes the ability to copy and paste the helpful meson output when a
> test fails, in order to re-run a failing test directly outside meson and
> from any current directory.
>
> meson never had that problem because it always switches to a constant
> directory before running the tests.
>
> Fixes: ef85ab79e7a4 ("cxl/test: Add topology enumeration and hotplug test")
>
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> Signed-off-by: Marc Herbert <marc.herbert@linux.intel.com>
Applied to pending, thanks!
https://github.com/pmem/ndctl/tree/pending
> ---
> test/meson.build | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/test/meson.build b/test/meson.build
> index d871e28e17ce..2fd7df5211dd 100644
> --- a/test/meson.build
> +++ b/test/meson.build
> @@ -255,6 +255,7 @@ foreach t : tests
> env : [
> 'NDCTL=@0@'.format(ndctl_tool.full_path()),
> 'DAXCTL=@0@'.format(daxctl_tool.full_path()),
> + 'CXL=@0@'.format(cxl_tool.full_path()),
> 'TEST_PATH=@0@'.format(meson.current_build_dir()),
> 'DATA_PATH=@0@'.format(meson.current_source_dir()),
> ],
> --
> 2.49.0
>
>
prev parent reply other threads:[~2025-05-14 0:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 18:31 [ndctl PATCH v2] test: set the $CXL environment variable in meson.build marc.herbert
2025-05-14 0:51 ` Alison Schofield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aCPo_u0wOljHCigP@aschofie-mobl2.lan \
--to=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=marc.herbert@linux.intel.com \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox