[ndctl PATCH v2] test: set the $CXL environment variable in meson.build

[ndctl PATCH v2] test: set the $CXL environment variable in meson.build

[marc.herbert]

From: Marc Herbert <marc.herbert@linux.intel.com>

This fixes the ability to copy and paste the helpful meson output when a
test fails, in order to re-run a failing test directly outside meson and
from any current directory.

meson never had that problem because it always switches to a constant
directory before running the tests.

Fixes: ef85ab79e7a4 ("cxl/test: Add topology enumeration and hotplug test")

Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Marc Herbert <marc.herbert@linux.intel.com>
---
 test/meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/test/meson.build b/test/meson.build
index d871e28e17ce..2fd7df5211dd 100644
--- a/test/meson.build
+++ b/test/meson.build
@@ -255,6 +255,7 @@ foreach t : tests
     env : [
       'NDCTL=@0@'.format(ndctl_tool.full_path()),
       'DAXCTL=@0@'.format(daxctl_tool.full_path()),
+      'CXL=@0@'.format(cxl_tool.full_path()),
       'TEST_PATH=@0@'.format(meson.current_build_dir()),
       'DATA_PATH=@0@'.format(meson.current_source_dir()),
     ],
-- 
2.49.0

Re: [ndctl PATCH v2] test: set the $CXL environment variable in meson.build

[Alison Schofield]

On Thu, May 08, 2025 at 06:31:42PM +0000, marc.herbert@linux.intel.com wrote:
> From: Marc Herbert <marc.herbert@linux.intel.com>
> 
> This fixes the ability to copy and paste the helpful meson output when a
> test fails, in order to re-run a failing test directly outside meson and
> from any current directory.
> 
> meson never had that problem because it always switches to a constant
> directory before running the tests.
> 
> Fixes: ef85ab79e7a4 ("cxl/test: Add topology enumeration and hotplug test")
> 
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> Signed-off-by: Marc Herbert <marc.herbert@linux.intel.com>

Applied to pending, thanks!
https://github.com/pmem/ndctl/tree/pending


> ---
>  test/meson.build | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/test/meson.build b/test/meson.build
> index d871e28e17ce..2fd7df5211dd 100644
> --- a/test/meson.build
> +++ b/test/meson.build
> @@ -255,6 +255,7 @@ foreach t : tests
>      env : [
>        'NDCTL=@0@'.format(ndctl_tool.full_path()),
>        'DAXCTL=@0@'.format(daxctl_tool.full_path()),
> +      'CXL=@0@'.format(cxl_tool.full_path()),
>        'TEST_PATH=@0@'.format(meson.current_build_dir()),
>        'DATA_PATH=@0@'.format(meson.current_source_dir()),
>      ],
> -- 
> 2.49.0
> 
>