Linux CXL
 help / color / mirror / Atom feed
From: Dave Jiang <dave.jiang@intel.com>
To: Robert Richter <rrichter@amd.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Jonathan Cameron <jonathan.cameron@huawei.com>,
	Alison Schofield <alison.schofield@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Ira Weiny <ira.weiny@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Ben Widawsky <bwidawsk@kernel.org>
Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] cxl/hdm: Fix newline character in dev_err() messages
Date: Fri, 9 Jan 2026 09:16:12 -0700	[thread overview]
Message-ID: <abb4fedd-df10-4993-9567-9be185094d6a@intel.com> (raw)
In-Reply-To: <20260109122952.639231-1-rrichter@amd.com>



On 1/9/26 5:29 AM, Robert Richter wrote:
> The newline character is not placed at the end of the string. This
> causes unintended line wraps, broken log level and unterminated log
> messages. Fix that for all messages.
> 
> Note that the messages are changed to use colons now instead of
> parentheses, which is more common use.
> 
> Fixes: 24b18197184a ("cxl/hdm: Extend DVSEC range register emulation for region enumeration")
> Fixes: 9c57cde0dcbd ("cxl/hdm: Enumerate allocated DPA")
> Signed-off-by: Robert Richter <rrichter@amd.com>
> ---

Applied to cxl/next
4c9922387b35b325a645cc42f8daf9a9e4db690b


>  drivers/cxl/core/hdm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c
> index 031672e92b0b..28611b350cf6 100644
> --- a/drivers/cxl/core/hdm.c
> +++ b/drivers/cxl/core/hdm.c
> @@ -966,7 +966,7 @@ static int cxl_setup_hdm_decoder_from_dvsec(
>  	rc = devm_cxl_dpa_reserve(cxled, *dpa_base, len, 0);
>  	if (rc) {
>  		dev_err(&port->dev,
> -			"decoder%d.%d: Failed to reserve DPA range %#llx - %#llx\n (%d)",
> +			"decoder%d.%d: Failed to reserve DPA range %#llx - %#llx: %d\n",
>  			port->id, cxld->id, *dpa_base, *dpa_base + len - 1, rc);
>  		return rc;
>  	}
> @@ -1117,7 +1117,7 @@ static int init_hdm_decoder(struct cxl_port *port, struct cxl_decoder *cxld,
>  	rc = devm_cxl_dpa_reserve(cxled, *dpa_base + skip, dpa_size, skip);
>  	if (rc) {
>  		dev_err(&port->dev,
> -			"decoder%d.%d: Failed to reserve DPA range %#llx - %#llx\n (%d)",
> +			"decoder%d.%d: Failed to reserve DPA range %#llx - %#llx: %d\n",
>  			port->id, cxld->id, *dpa_base,
>  			*dpa_base + dpa_size + skip - 1, rc);
>  		return rc;
> 
> base-commit: 88c72bab77aaf389beccf762e112828253ca0564
> prerequisite-patch-id: f44102a7b095afa1588a5cac012ec2e0d852c021
> prerequisite-patch-id: c142edda207a3a69ae242182e51e9a8b8d78cf72


  parent reply	other threads:[~2026-01-09 16:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-09 12:29 [PATCH v1] cxl/hdm: Fix newline character in dev_err() messages Robert Richter
2026-01-09 14:14 ` Jonathan Cameron
2026-01-09 16:16 ` Dave Jiang [this message]
2026-01-09 16:21   ` Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abb4fedd-df10-4993-9567-9be185094d6a@intel.com \
    --to=dave.jiang@intel.com \
    --cc=alison.schofield@intel.com \
    --cc=bwidawsk@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=dave@stgolabs.net \
    --cc=ira.weiny@intel.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rrichter@amd.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox