* [PATCH v1] cxl/hdm: Fix newline character in dev_err() messages
@ 2026-01-09 12:29 Robert Richter
2026-01-09 14:14 ` Jonathan Cameron
2026-01-09 16:16 ` Dave Jiang
0 siblings, 2 replies; 4+ messages in thread
From: Robert Richter @ 2026-01-09 12:29 UTC (permalink / raw)
To: Davidlohr Bueso, Jonathan Cameron, Dave Jiang, Alison Schofield,
Vishal Verma, Ira Weiny, Dan Williams, Ben Widawsky
Cc: Robert Richter, Jonathan Cameron, linux-cxl, linux-kernel
The newline character is not placed at the end of the string. This
causes unintended line wraps, broken log level and unterminated log
messages. Fix that for all messages.
Note that the messages are changed to use colons now instead of
parentheses, which is more common use.
Fixes: 24b18197184a ("cxl/hdm: Extend DVSEC range register emulation for region enumeration")
Fixes: 9c57cde0dcbd ("cxl/hdm: Enumerate allocated DPA")
Signed-off-by: Robert Richter <rrichter@amd.com>
---
drivers/cxl/core/hdm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c
index 031672e92b0b..28611b350cf6 100644
--- a/drivers/cxl/core/hdm.c
+++ b/drivers/cxl/core/hdm.c
@@ -966,7 +966,7 @@ static int cxl_setup_hdm_decoder_from_dvsec(
rc = devm_cxl_dpa_reserve(cxled, *dpa_base, len, 0);
if (rc) {
dev_err(&port->dev,
- "decoder%d.%d: Failed to reserve DPA range %#llx - %#llx\n (%d)",
+ "decoder%d.%d: Failed to reserve DPA range %#llx - %#llx: %d\n",
port->id, cxld->id, *dpa_base, *dpa_base + len - 1, rc);
return rc;
}
@@ -1117,7 +1117,7 @@ static int init_hdm_decoder(struct cxl_port *port, struct cxl_decoder *cxld,
rc = devm_cxl_dpa_reserve(cxled, *dpa_base + skip, dpa_size, skip);
if (rc) {
dev_err(&port->dev,
- "decoder%d.%d: Failed to reserve DPA range %#llx - %#llx\n (%d)",
+ "decoder%d.%d: Failed to reserve DPA range %#llx - %#llx: %d\n",
port->id, cxld->id, *dpa_base,
*dpa_base + dpa_size + skip - 1, rc);
return rc;
base-commit: 88c72bab77aaf389beccf762e112828253ca0564
prerequisite-patch-id: f44102a7b095afa1588a5cac012ec2e0d852c021
prerequisite-patch-id: c142edda207a3a69ae242182e51e9a8b8d78cf72
--
2.47.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v1] cxl/hdm: Fix newline character in dev_err() messages
2026-01-09 12:29 [PATCH v1] cxl/hdm: Fix newline character in dev_err() messages Robert Richter
@ 2026-01-09 14:14 ` Jonathan Cameron
2026-01-09 16:16 ` Dave Jiang
1 sibling, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2026-01-09 14:14 UTC (permalink / raw)
To: Robert Richter
Cc: Davidlohr Bueso, Dave Jiang, Alison Schofield, Vishal Verma,
Ira Weiny, Dan Williams, Ben Widawsky, linux-cxl, linux-kernel
On Fri, 9 Jan 2026 13:29:51 +0100
Robert Richter <rrichter@amd.com> wrote:
> The newline character is not placed at the end of the string. This
> causes unintended line wraps, broken log level and unterminated log
> messages. Fix that for all messages.
>
> Note that the messages are changed to use colons now instead of
> parentheses, which is more common use.
>
> Fixes: 24b18197184a ("cxl/hdm: Extend DVSEC range register emulation for region enumeration")
> Fixes: 9c57cde0dcbd ("cxl/hdm: Enumerate allocated DPA")
> Signed-off-by: Robert Richter <rrichter@amd.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
> ---
> drivers/cxl/core/hdm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c
> index 031672e92b0b..28611b350cf6 100644
> --- a/drivers/cxl/core/hdm.c
> +++ b/drivers/cxl/core/hdm.c
> @@ -966,7 +966,7 @@ static int cxl_setup_hdm_decoder_from_dvsec(
> rc = devm_cxl_dpa_reserve(cxled, *dpa_base, len, 0);
> if (rc) {
> dev_err(&port->dev,
> - "decoder%d.%d: Failed to reserve DPA range %#llx - %#llx\n (%d)",
> + "decoder%d.%d: Failed to reserve DPA range %#llx - %#llx: %d\n",
> port->id, cxld->id, *dpa_base, *dpa_base + len - 1, rc);
> return rc;
> }
> @@ -1117,7 +1117,7 @@ static int init_hdm_decoder(struct cxl_port *port, struct cxl_decoder *cxld,
> rc = devm_cxl_dpa_reserve(cxled, *dpa_base + skip, dpa_size, skip);
> if (rc) {
> dev_err(&port->dev,
> - "decoder%d.%d: Failed to reserve DPA range %#llx - %#llx\n (%d)",
> + "decoder%d.%d: Failed to reserve DPA range %#llx - %#llx: %d\n",
> port->id, cxld->id, *dpa_base,
> *dpa_base + dpa_size + skip - 1, rc);
> return rc;
>
> base-commit: 88c72bab77aaf389beccf762e112828253ca0564
> prerequisite-patch-id: f44102a7b095afa1588a5cac012ec2e0d852c021
> prerequisite-patch-id: c142edda207a3a69ae242182e51e9a8b8d78cf72
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1] cxl/hdm: Fix newline character in dev_err() messages
2026-01-09 12:29 [PATCH v1] cxl/hdm: Fix newline character in dev_err() messages Robert Richter
2026-01-09 14:14 ` Jonathan Cameron
@ 2026-01-09 16:16 ` Dave Jiang
2026-01-09 16:21 ` Dave Jiang
1 sibling, 1 reply; 4+ messages in thread
From: Dave Jiang @ 2026-01-09 16:16 UTC (permalink / raw)
To: Robert Richter, Davidlohr Bueso, Jonathan Cameron,
Alison Schofield, Vishal Verma, Ira Weiny, Dan Williams,
Ben Widawsky
Cc: linux-cxl, linux-kernel
On 1/9/26 5:29 AM, Robert Richter wrote:
> The newline character is not placed at the end of the string. This
> causes unintended line wraps, broken log level and unterminated log
> messages. Fix that for all messages.
>
> Note that the messages are changed to use colons now instead of
> parentheses, which is more common use.
>
> Fixes: 24b18197184a ("cxl/hdm: Extend DVSEC range register emulation for region enumeration")
> Fixes: 9c57cde0dcbd ("cxl/hdm: Enumerate allocated DPA")
> Signed-off-by: Robert Richter <rrichter@amd.com>
> ---
Applied to cxl/next
4c9922387b35b325a645cc42f8daf9a9e4db690b
> drivers/cxl/core/hdm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c
> index 031672e92b0b..28611b350cf6 100644
> --- a/drivers/cxl/core/hdm.c
> +++ b/drivers/cxl/core/hdm.c
> @@ -966,7 +966,7 @@ static int cxl_setup_hdm_decoder_from_dvsec(
> rc = devm_cxl_dpa_reserve(cxled, *dpa_base, len, 0);
> if (rc) {
> dev_err(&port->dev,
> - "decoder%d.%d: Failed to reserve DPA range %#llx - %#llx\n (%d)",
> + "decoder%d.%d: Failed to reserve DPA range %#llx - %#llx: %d\n",
> port->id, cxld->id, *dpa_base, *dpa_base + len - 1, rc);
> return rc;
> }
> @@ -1117,7 +1117,7 @@ static int init_hdm_decoder(struct cxl_port *port, struct cxl_decoder *cxld,
> rc = devm_cxl_dpa_reserve(cxled, *dpa_base + skip, dpa_size, skip);
> if (rc) {
> dev_err(&port->dev,
> - "decoder%d.%d: Failed to reserve DPA range %#llx - %#llx\n (%d)",
> + "decoder%d.%d: Failed to reserve DPA range %#llx - %#llx: %d\n",
> port->id, cxld->id, *dpa_base,
> *dpa_base + dpa_size + skip - 1, rc);
> return rc;
>
> base-commit: 88c72bab77aaf389beccf762e112828253ca0564
> prerequisite-patch-id: f44102a7b095afa1588a5cac012ec2e0d852c021
> prerequisite-patch-id: c142edda207a3a69ae242182e51e9a8b8d78cf72
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1] cxl/hdm: Fix newline character in dev_err() messages
2026-01-09 16:16 ` Dave Jiang
@ 2026-01-09 16:21 ` Dave Jiang
0 siblings, 0 replies; 4+ messages in thread
From: Dave Jiang @ 2026-01-09 16:21 UTC (permalink / raw)
To: Robert Richter, Davidlohr Bueso, Jonathan Cameron,
Alison Schofield, Vishal Verma, Ira Weiny, Dan Williams,
Ben Widawsky
Cc: linux-cxl, linux-kernel
On 1/9/26 9:16 AM, Dave Jiang wrote:
>
>
> On 1/9/26 5:29 AM, Robert Richter wrote:
>> The newline character is not placed at the end of the string. This
>> causes unintended line wraps, broken log level and unterminated log
>> messages. Fix that for all messages.
>>
>> Note that the messages are changed to use colons now instead of
>> parentheses, which is more common use.
>>
>> Fixes: 24b18197184a ("cxl/hdm: Extend DVSEC range register emulation for region enumeration")
>> Fixes: 9c57cde0dcbd ("cxl/hdm: Enumerate allocated DPA")
>> Signed-off-by: Robert Richter <rrichter@amd.com>
>> ---
>
> Applied to cxl/next
> 4c9922387b35b325a645cc42f8daf9a9e4db690b
Actually 0db2344eb8a8a9451cf4f7b9b25e7a0247476813. For some reason b4 kept picking up two other patches from you Robert. I didn't notice until I pushed. Had to fix that.
>
>
>> drivers/cxl/core/hdm.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c
>> index 031672e92b0b..28611b350cf6 100644
>> --- a/drivers/cxl/core/hdm.c
>> +++ b/drivers/cxl/core/hdm.c
>> @@ -966,7 +966,7 @@ static int cxl_setup_hdm_decoder_from_dvsec(
>> rc = devm_cxl_dpa_reserve(cxled, *dpa_base, len, 0);
>> if (rc) {
>> dev_err(&port->dev,
>> - "decoder%d.%d: Failed to reserve DPA range %#llx - %#llx\n (%d)",
>> + "decoder%d.%d: Failed to reserve DPA range %#llx - %#llx: %d\n",
>> port->id, cxld->id, *dpa_base, *dpa_base + len - 1, rc);
>> return rc;
>> }
>> @@ -1117,7 +1117,7 @@ static int init_hdm_decoder(struct cxl_port *port, struct cxl_decoder *cxld,
>> rc = devm_cxl_dpa_reserve(cxled, *dpa_base + skip, dpa_size, skip);
>> if (rc) {
>> dev_err(&port->dev,
>> - "decoder%d.%d: Failed to reserve DPA range %#llx - %#llx\n (%d)",
>> + "decoder%d.%d: Failed to reserve DPA range %#llx - %#llx: %d\n",
>> port->id, cxld->id, *dpa_base,
>> *dpa_base + dpa_size + skip - 1, rc);
>> return rc;
>>
>> base-commit: 88c72bab77aaf389beccf762e112828253ca0564
>> prerequisite-patch-id: f44102a7b095afa1588a5cac012ec2e0d852c021
>> prerequisite-patch-id: c142edda207a3a69ae242182e51e9a8b8d78cf72
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-01-09 16:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-09 12:29 [PATCH v1] cxl/hdm: Fix newline character in dev_err() messages Robert Richter
2026-01-09 14:14 ` Jonathan Cameron
2026-01-09 16:16 ` Dave Jiang
2026-01-09 16:21 ` Dave Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox