Re: [NDCTL PATCH v6 4/4] cxl/test: Add test for cxl features device

[Marc Herbert <marc.herbert@linux.intel.com>]

>>>>>  
>>>>> +uuid_dep = dependency('uuid', required: false)
>>>>> +if get_option('fwctl').enabled() and uuid_dep.found()
>>>>> +  fwctl = executable('fwctl', 'fwctl.c',
>>>>> +    dependencies : libcxl_deps,
>>>>> +    include_directories : root_inc,
>>>>> +  )
>>>>> +  cxl_features = find_program('cxl-features.sh')
>>>>> +  tests += [
>>>>> +    [ 'cxl-features.sh',        cxl_features,       'cxl'   ],
>>>>> +  ]
>>>>> +endif
>>>>
>>>> Is the fwctl feature enabled fuss still needed now that the UAPI headers
>>>> are vendored locally?  Seems the test will quickly SKIP if fwctl dev not
>>>> found. I kind of like the idea of seeing a 'SKIP' and knowing the test
>>>> didn't run than seeing nothing at all in the test output.
>>>
>>> This gives the option to disable fwctl if needed. Also there is a libuuid dependency since we use uuid lib calls. 
>>
>> Is it possible to go anywhere without uuid?
>>
>> [snip]
>>
>> It looks like a hard requirement to me.
>>
>> UUIDs are rarely ever "optional". It could be required only
>> by some optional tool but that does not seem to be the case here
> 
> Apparently it's not an requirement for kernel build. As my feature user header caused issues due to lack of libuuid package.

I think I wasn't clear, let me be more explicit: I think you should drop
all the code with "uuid_dep" above. It would not just simplify the code
(uuid_dep.found() is always true), but it would also get rid of
some (unfounded) reader's anxiety about an (im)possible system
configuration where fwctl is not tested without even printing a "SKIP".

It never hurts to express dependencies, but I think it's also bad to
look like you can opt out when you cannot.