Re: [NDCTL PATCH v6 4/4] cxl/test: Add test for cxl features device

[Marc Herbert <Marc.Herbert@linux.intel.com>]

On 2025-05-15 11:28, Dave Jiang wrote:

>>>  
>>> +uuid_dep = dependency('uuid', required: false)
>>> +if get_option('fwctl').enabled() and uuid_dep.found()
>>> +  fwctl = executable('fwctl', 'fwctl.c',
>>> +    dependencies : libcxl_deps,
>>> +    include_directories : root_inc,
>>> +  )
>>> +  cxl_features = find_program('cxl-features.sh')
>>> +  tests += [
>>> +    [ 'cxl-features.sh',        cxl_features,       'cxl'   ],
>>> +  ]
>>> +endif
>>
>> Is the fwctl feature enabled fuss still needed now that the UAPI headers
>> are vendored locally?  Seems the test will quickly SKIP if fwctl dev not
>> found. I kind of like the idea of seeing a 'SKIP' and knowing the test
>> didn't run than seeing nothing at all in the test output.
> 
> This gives the option to disable fwctl if needed. Also there is a libuuid dependency since we use uuid lib calls. 

Is it possible to go anywhere without uuid?

fedora$ sudo dnf remove libuuid-devel
        meson setup build

...
Run-time dependency libkmod found: YES 33
Run-time dependency libudev found: YES 256
Found CMake: /usr/bin/cmake (3.30.8)
Run-time dependency uuid found: NO (tried pkgconfig and cmake)

meson.build:144:0: ERROR: Dependency "uuid" not found, tried pkgconfig and cmake


meson setup --help | grep uuid  # empty
git grep get_option.*uuid       # empty
grep -C 5 uuid meson.build      # does not look optional

It looks like a hard requirement to me.

UUIDs are rarely ever "optional". It could be required only
by some optional tool but that does not seem to be the case here

Fun fact: it's not even possible to remove /usr/include/uuid/uuid.h
on Arch Linux, not without breaking the system.