Re: [PATCH v5 2/7] cxl/region: Warn on user region position mismatch

[Alison Schofield <alison.schofield@intel.com>]

On Wed, Sep 16, 2026 at 02:05:11PM +0200, Robert Richter wrote:
> On 03.09.26 16:23:44, Alison Schofield wrote:
> > User region creation includes a self-test that checks the assigned endpoint
> > positions against the position calculation used by auto region creation.
> > The result, matching or not, is reported with dev_dbg().
> 
> As commented to the doc, the position is clearly defined as the bit
> mask that is striped off by the endpoint. That should be documented in
> the code to describe, what position means in that context, esp. how
> the position in the target list of each level adds to the position.
> That clarity is missing.


Agreed that position could use a clearer definition. Patch 3 updates the
cxl_calc_interleave_pos() documentation, so I'll address this there in v6,
along with the documentation changes discussed in patch 1

-- Alison

> 
> > 
> > Promote that to a dev_warn() that fires only on a mismatch, so bugs in the
> > auto region position calculation are easier to catch as that calculation is
> > extended to support more region configurations.
> 
> dev_warn() change looks good to me.
> 
> > 
> > The matching case no longer prints, so dynamic debug on region.c no longer
> > confirms that the self-test ran.
> > 
> > Signed-off-by: Alison Schofield <alison.schofield@intel.com>
> > Reviewed-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
> 
> Reviewed-by: Robert Richter <rrichter@amd.com>