Re: [PATCH v5 2/7] cxl/region: Warn on user region position mismatch

[Alison Schofield <alison.schofield@intel.com>]

On Thu, Sep 03, 2026 at 04:23:44PM -0700, Alison Schofield wrote:
> User region creation includes a self-test that checks the assigned endpoint
> positions against the position calculation used by auto region creation.
> The result, matching or not, is reported with dev_dbg().
> 
> Promote that to a dev_warn() that fires only on a mismatch, so bugs in the
> auto region position calculation are easier to catch as that calculation is
> extended to support more region configurations.
> 
> The matching case no longer prints, so dynamic debug on region.c no longer
> confirms that the self-test ran.
> 
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>
> Reviewed-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>

DaveJ,

RobertR also tagged this one.

I'm requesting you merge this ahead of the rest of the series.

It is independent of the rest of this work, and landing it sooner
helps me with a unit test that wants that message to always be present.

Thanks for taking a look!

-- Alison


> ---
>  drivers/cxl/core/region.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
> index 27e63e6dab7c..6a698f36aa6d 100644
> --- a/drivers/cxl/core/region.c
> +++ b/drivers/cxl/core/region.c
> @@ -2215,10 +2215,11 @@ static int cxl_region_attach(struct cxl_region *cxlr,
>  		int test_pos;
>  
>  		test_pos = cxl_calc_interleave_pos(target, &cxlr->hpa_range);
> -		dev_dbg(&target->cxld.dev,
> -			"Test cxl_calc_interleave_pos(): %s test_pos:%d target->pos:%d\n",
> -			(test_pos == target->pos) ? "success" : "fail",
> -			test_pos, target->pos);
> +		if (test_pos != target->pos)
> +			dev_warn(&cxlr->dev,
> +				 "%s: position mismatch: calculated:%d assigned:%d\n",
> +				 dev_name(&target->cxld.dev), test_pos,
> +				 target->pos);
>  	}
>  
>  	return 0;
> -- 
> 2.37.3
>