Linux CXL
 help / color / mirror / Atom feed
From: Dave Jiang <dave.jiang@intel.com>
To: Alison Schofield <alison.schofield@intel.com>,
	Guixin Liu <kanie@linux.alibaba.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>,
	Jonathan Cameron <jic23@kernel.org>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Dan Williams <djbw@kernel.org>, Ira Weiny <iweiny@kernel.org>,
	Li Ming <ming.li@zohomail.com>,
	linux-cxl@vger.kernel.org
Subject: Re: [PATCH] cxl/events: Fix event type check for CME counter expiration
Date: Mon, 21 Sep 2026 10:38:32 -0700	[thread overview]
Message-ID: <b19de9d5-ed37-4b55-8aca-0393a8fa6efa@intel.com> (raw)
In-Reply-To: <arFpVVElCIlCqvVb@aschofie-mobl2.lan>



On 9/21/26 10:28 AM, Alison Schofield wrote:
> On Mon, Sep 21, 2026 at 08:09:32PM +0800, Guixin Liu wrote:
> 
> 
> Hi Guixin,
> 
> Agree w DaveJ's commit log suggestion.
> 
> Also, the Subject can be specific, like:
> cxl/events: Test CME counter expiry with equality, not bitwise AND
> 
> You may want to add something like I've appended below to your agent instructions.
> It is intended to better calibrate your agent. Also try giving your agent this
> patch (v1 and v2) as a concrete example in the skill. It's a good one because the
> original one isn't bad, it is actually thorough and technically valid, but it is
> trying to make the commit log serve as the entire bug report, reproduction recipe
> and test report. That's exactly the tendency you want this agent to stop doing.
> 
> Teach your agent (w example):
> 
> For Linux kernel commit messages, be concise and focus on why the change is
> needed, not a detailed narration of the investigation.
> 
> Structure the commit message as:
> 
> 1. Background only when needed to understand the problem.
> 2. Problem: what the current code gets wrong.
> 3. Impact: the meaningful consequence, especially user-visible impact.
> 4. Resolution: what the patch changes and why that addresses the problem.
> 5. Brief "Found by" / "Tested by" information when useful.
> 
> Do not include every example, reproduction step, intermediate observation, or
> possible consequence just because that information is available. Keep only
> details needed to establish the problem and impact.
> 
> For small, obvious fixes, aim for roughly 1-3 short paragraphs plus concise
> testing information. Explain the semantic error. Do not narrate the code diff.
> 
> Subjects should describe the change specifically. Avoid generic "Fix ..."
> subjects when a more descriptive imperative subject is available.
> 
> -- Alison


And if you are uisng an AI agent, please include the following tag:
Assisted-by: LLM

  reply	other threads:[~2026-09-21 17:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21 12:09 [PATCH] cxl/events: Fix event type check for CME counter expiration Guixin Liu
2026-09-21 16:54 ` Dave Jiang
2026-09-22  8:23   ` Guixin Liu
2026-09-21 17:28 ` Alison Schofield
2026-09-21 17:38   ` Dave Jiang [this message]
2026-09-22  8:24   ` Guixin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b19de9d5-ed37-4b55-8aca-0393a8fa6efa@intel.com \
    --to=dave.jiang@intel.com \
    --cc=alison.schofield@intel.com \
    --cc=dave@stgolabs.net \
    --cc=djbw@kernel.org \
    --cc=iweiny@kernel.org \
    --cc=jic23@kernel.org \
    --cc=kanie@linux.alibaba.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=ming.li@zohomail.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox