Linux CXL
 help / color / mirror / Atom feed
From: Dave Jiang <dave.jiang@intel.com>
To: Li Zhijian <lizhijian@fujitsu.com>,
	nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org
Subject: Re: [ndctl PATCH v2 2/2] daxctl: Remove unimplemented create-device options
Date: Fri, 31 May 2024 13:37:06 -0700	[thread overview]
Message-ID: <b3af86b7-b2ce-464b-92b4-70e10a283b15@intel.com> (raw)
In-Reply-To: <20240531062959.881772-2-lizhijian@fujitsu.com>



On 5/30/24 11:29 PM, Li Zhijian wrote:
> RECONFIG_OPTIONS and ZONE_OPTIONS are not implemented for create-device
> and they will be ignored by create-device. Remove them so that the usage
> message is identical to the manual.
> 
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> V2: make the usage match the manual because the usage is wrong.
> ---
>  daxctl/device.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/daxctl/device.c b/daxctl/device.c
> index ffabd6cf5707..781dc4007f83 100644
> --- a/daxctl/device.c
> +++ b/daxctl/device.c
> @@ -98,8 +98,6 @@ OPT_BOOLEAN('\0', "no-movable", &param.no_movable, \
>  static const struct option create_options[] = {
>  	BASE_OPTIONS(),
>  	CREATE_OPTIONS(),
> -	RECONFIG_OPTIONS(),
> -	ZONE_OPTIONS(),
>  	OPT_END(),
>  };
>  

  parent reply	other threads:[~2024-05-31 20:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-31  6:29 [ndctl PATCH v2 1/2] daxctl: Fix create-device parameters parsing Li Zhijian
2024-05-31  6:29 ` [ndctl PATCH v2 2/2] daxctl: Remove unimplemented create-device options Li Zhijian
2024-05-31 20:03   ` Verma, Vishal L
2024-05-31 20:37   ` Dave Jiang [this message]
2024-05-31 21:43   ` Alison Schofield
2024-06-03  1:26     ` Zhijian Li (Fujitsu)
2024-05-31 20:02 ` [ndctl PATCH v2 1/2] daxctl: Fix create-device parameters parsing Verma, Vishal L
2024-05-31 20:36 ` Dave Jiang
2024-05-31 21:32 ` Alison Schofield
2024-06-03  1:12   ` Zhijian Li (Fujitsu)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b3af86b7-b2ce-464b-92b4-70e10a283b15@intel.com \
    --to=dave.jiang@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=lizhijian@fujitsu.com \
    --cc=nvdimm@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox