Re: [PATCH v2] cxl: factor out cxl_await_range_active() and cxl_media_ready()

[Zhi Wang <zhiw@nvidia.com>]

On 12/24/2024 6:16 PM, Jonathan Cameron wrote:
> On Fri, 13 Dec 2024 02:39:06 -0800
> Zhi Wang <zhiw@nvidia.com> wrote:
> 
>> Before accessing the CXL device memory after reset/power-on, the driver
>> needs to ensure the device memory media is ready.
>>
>> However, not every CXL device implements the CXL memory device register
>> groups. E.g. a CXL type-2 device. Thus calling cxl_await_media_ready()
>> on these devcie will lead to a kernel panic. This problem was found when
> 
> Spell check. device

Thanks. I did add checkpatch.pl in my patch sending script since you 
told me last time, but checkpatch.pl cannot catch this one until I 
install codespell and did checkpatch.pl --codespell *.patch.

==== without codespell ====

inno@inno-linux:~/linux$ scripts/checkpatch.pl *.patch
WARNING: The commit message has 'Call Trace:', perhaps it also needs a 
'Fixes:' tag?

total: 0 errors, 1 warnings, 54 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
       mechanically convert to the typical style using --fix or 
--fix-inplace.

0001-cxl-factor-out-cxl_await_range_active-and-cxl_media_.patch has 
style problems, please review.

NOTE: If any of the errors are false positives, please report
       them to the maintainer, see CHECKPATCH in MAINTAINERS.

==== with codespell ====

inno@inno-linux:~/linux$ scripts/checkpatch.pl *.patch --codespell
WARNING: 'devcie' may be misspelled - perhaps 'device'?
#12:
on these devcie will lead to a kernel panic. This problem was found when
          ^^^^^^
...

> I've no problem with the change, but would prefer to see it as part of
> a series making use of the newly exported split.
> 

It started as a fix when I was working on QEMU type-2 device emulation 
[1]. Guess the near coming user should be the sample CXL type-2 driver 
and VFIO CXL.

[1] https://lore.kernel.org/all/20241212130422.69380-2-zhiw@nvidia.com/T/

> Assuming one comes along.
> Reviewed-by; Jonathan Cameron <Jonathan.Cameron@huawei.com>
>