Re: [RFC PATCH 1/6] PCI/RCEC: Introduce pcie_walk_rcec_all()

[Terry Bowman <Terry.Bowman@amd.com>]

Hi Li,

I added comments below.

On 3/13/24 03:35, Li Ming wrote:
> PCIe RCEC core only provides pcie_walk_rcec() to walk all RCiEP devices
> associating with RCEC, but CXL subsystem needs a helper function which
> can walk all devices in RCEC associated bus range other than RCiEPs for
> below RAS error case.
> 
> CXL r3.1 section 12.2.2 mentions that the CXL.cachemem protocol errors
> detected by a CXL root port could be logged in RCEC AER Extended
> Capability. The recommendation solution from CXL r3.1 section 9.18.1.5
> is:
> 
> 	"Probe all CXL Downstream Ports and determine whether they have
> 	logged an error in the CXL.io or CXL.cachemem status registers."
> 
> The new helper function called pcie_walk_rcec_all(), CXL RAS error
> handler can use it to locate all CXL root ports or CXL devices in RCEC
> associated bus range.

The RCEC-root port relation you mention is new to me. Typically, not in 
all cases, RCH-RCD has a RCEC. And a VH mode system has a root port 
instead. The RCH RCEC and VH root port are both bound to the PCIeport 
bus driver that supports handling and logging AER. This allows the PCIe 
port bus driver to handle AER in a RCEC and root port AER using the same 
procedure and accesses to the AER capability registers. 

This is oversimplified but are you looking to handle root port AER error 
in the RCEC from the below diagram? 

RCEC <--> CXL root port (bridge) <--> Endpoint

> 
> Signed-off-by: Li Ming <ming4.li@intel.com>
> ---
>  drivers/pci/pci.h       |  6 ++++++
>  drivers/pci/pcie/rcec.c | 44 +++++++++++++++++++++++++++++++++++++++--
>  2 files changed, 48 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
> index 5ecbcf041179..a068f2d7dd28 100644
> --- a/drivers/pci/pci.h
> +++ b/drivers/pci/pci.h
> @@ -444,6 +444,9 @@ void pcie_link_rcec(struct pci_dev *rcec);
>  void pcie_walk_rcec(struct pci_dev *rcec,
>  		    int (*cb)(struct pci_dev *, void *),
>  		    void *userdata);
> +void pcie_walk_rcec_all(struct pci_dev *rcec,
> +			int (*cb)(struct pci_dev *, void *),
> +			void *userdata);
>  #else
>  static inline void pci_rcec_init(struct pci_dev *dev) { }
>  static inline void pci_rcec_exit(struct pci_dev *dev) { }
> @@ -451,6 +454,9 @@ static inline void pcie_link_rcec(struct pci_dev *rcec) { }
>  static inline void pcie_walk_rcec(struct pci_dev *rcec,
>  				  int (*cb)(struct pci_dev *, void *),
>  				  void *userdata) { }
> +static inline void pcie_walk_rcec_all(struct pci_dev *rcec,
> +				      int (*cb)(struct pci_dev *, void *),
> +				      void *userdata) { }
>  #endif
>  
>  #ifdef CONFIG_PCI_ATS
> diff --git a/drivers/pci/pcie/rcec.c b/drivers/pci/pcie/rcec.c
> index d0bcd141ac9c..189de280660c 100644
> --- a/drivers/pci/pcie/rcec.c
> +++ b/drivers/pci/pcie/rcec.c
> @@ -65,6 +65,15 @@ static int walk_rcec_helper(struct pci_dev *dev, void *data)
>  	return 0;
>  }
>  
> +static int walk_rcec_all_helper(struct pci_dev *dev, void *data)
> +{
> +	struct walk_rcec_data *rcec_data = data;
> +
> +	rcec_data->user_callback(dev, rcec_data->user_data);
> +
> +	return 0;
> +}
> +
>  static void walk_rcec(int (*cb)(struct pci_dev *dev, void *data),
>  		      void *userdata)
>  {
> @@ -83,7 +92,7 @@ static void walk_rcec(int (*cb)(struct pci_dev *dev, void *data),
>  	nextbusn = rcec->rcec_ea->nextbusn;
>  	lastbusn = rcec->rcec_ea->lastbusn;
>  
> -	/* All RCiEP devices are on the same bus as the RCEC */
> +	/* All devices are on the same bus as the RCEC */

RCiEPs are not guaranteed to be on same bus as RCEC. Details for associated 
next and last busses:

"This register does not indicate association between an Event Collector and 
any Function on the same Bus Number as the Event Collector itself, however 
it is permitted for the Association Bus Range to include the Bus Number of 
the Root Complex Event Collector."[1]

[1] PCI Spec 6.0 - RCEC Associated Bus Numbers Register 9Ofset 08h)


>  	if (nextbusn == 0xff && lastbusn == 0x00)
>  		return;
>  
> @@ -96,7 +105,7 @@ static void walk_rcec(int (*cb)(struct pci_dev *dev, void *data),
>  		if (!bus)
>  			continue;
>  
> -		/* Find RCiEP devices on the given bus ranges */
> +		/* Find devices on the given bus ranges */
>  		pci_walk_bus(bus, cb, rcec_data);
>  	}
>  }
> @@ -146,6 +155,37 @@ void pcie_walk_rcec(struct pci_dev *rcec, int (*cb)(struct pci_dev *, void *),
>  	walk_rcec(walk_rcec_helper, &rcec_data);
>  }
>  
> +/**
> + * pcie_walk_rcec_all - Walk all devices in RCEC's bus range.
> + * @rcec:	RCEC whose devices should be walked
> + * @cb:		Callback to be called for each device found
> + * @userdata:	Arbitrary pointer to be passed to callback
> + *
> + * It is implemented only for CXL cases.
> + * Per CXL r3.1 section 12.2.2, CXL protocol errors detected by
> + * CXL root port could be logged in an RCEC's AER Extended Capability.
> + * And per CXL r3.1 section 9.18.1.5, the recommendation is that probing
> + * all CXL root ports to determine whether they have logged an error.
> + * So provide this function for CXL to walk the given RCEC, CXL driver
> + * will figure out which CXL root ports detected errors.
> + *
> + * If @cb returns anything other than 0, break out.
> + */
> +void pcie_walk_rcec_all(struct pci_dev *rcec, int (*cb)(struct pci_dev *, void *),
> +			void *userdata)
> +{

Is this identical to pcie_walk_rcec()? Is this addition necessary?

Regards,
Terry

> +	struct walk_rcec_data rcec_data;
> +
> +	if (!rcec->rcec_ea)
> +		return;
> +
> +	rcec_data.rcec = rcec;
> +	rcec_data.user_callback = cb;
> +	rcec_data.user_data = userdata;
> +
> +	walk_rcec(walk_rcec_all_helper, &rcec_data);
> +}
> +
>  void pci_rcec_init(struct pci_dev *dev)
>  {
>  	struct rcec_ea *rcec_ea;