* [PATCH] libdaxctl: Add accurate check for daxctl_memory_op(MEM_GET_ZONE)
@ 2023-10-09 10:35 Xiao Yang
2023-10-13 22:27 ` Dave Jiang
0 siblings, 1 reply; 2+ messages in thread
From: Xiao Yang @ 2023-10-09 10:35 UTC (permalink / raw)
To: dave.jiang, nvdimm; +Cc: linux-cxl, Xiao Yang
The return number of daxctl_memory_op(MEM_GET_ZONE) indicates
how many memory blocks have the same memory zone. So It's wrong
to compare mem->zone and zone only when zero is returned.
Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
---
daxctl/lib/libdaxctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/daxctl/lib/libdaxctl.c b/daxctl/lib/libdaxctl.c
index b27a8af..4f9aba0 100644
--- a/daxctl/lib/libdaxctl.c
+++ b/daxctl/lib/libdaxctl.c
@@ -1616,7 +1616,7 @@ static int daxctl_memory_online_with_zone(struct daxctl_memory *mem,
*/
mem->zone = 0;
rc = daxctl_memory_op(mem, MEM_GET_ZONE);
- if (rc)
+ if (rc < 0)
return rc;
if (mem->zone != zone) {
err(ctx,
--
2.40.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libdaxctl: Add accurate check for daxctl_memory_op(MEM_GET_ZONE)
2023-10-09 10:35 [PATCH] libdaxctl: Add accurate check for daxctl_memory_op(MEM_GET_ZONE) Xiao Yang
@ 2023-10-13 22:27 ` Dave Jiang
0 siblings, 0 replies; 2+ messages in thread
From: Dave Jiang @ 2023-10-13 22:27 UTC (permalink / raw)
To: Xiao Yang, nvdimm; +Cc: linux-cxl
On 10/9/23 03:35, Xiao Yang wrote:
> The return number of daxctl_memory_op(MEM_GET_ZONE) indicates
> how many memory blocks have the same memory zone. So It's wrong
> to compare mem->zone and zone only when zero is returned.
>
> Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
You are correct. Thanks.
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> daxctl/lib/libdaxctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/daxctl/lib/libdaxctl.c b/daxctl/lib/libdaxctl.c
> index b27a8af..4f9aba0 100644
> --- a/daxctl/lib/libdaxctl.c
> +++ b/daxctl/lib/libdaxctl.c
> @@ -1616,7 +1616,7 @@ static int daxctl_memory_online_with_zone(struct daxctl_memory *mem,
> */
> mem->zone = 0;
> rc = daxctl_memory_op(mem, MEM_GET_ZONE);
> - if (rc)
> + if (rc < 0)
> return rc;
> if (mem->zone != zone) {
> err(ctx,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-13 22:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-09 10:35 [PATCH] libdaxctl: Add accurate check for daxctl_memory_op(MEM_GET_ZONE) Xiao Yang
2023-10-13 22:27 ` Dave Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox