Re: [PATCH v15 00/22] Type2 device basic support

[Dave Jiang <dave.jiang@intel.com>]

On 5/13/25 1:12 AM, Alejandro Lucero Palau wrote:
> 
> On 5/12/25 23:36, Dave Jiang wrote:
>>
>> On 5/12/25 9:10 AM, alejandro.lucero-palau@amd.com wrote:
>>> From: Alejandro Lucero <alucerop@amd.com>
>>>
>>> v15 changes:
>>>   - remove reference to unused header file (Jonathan Cameron)
>>>   - add proper kernel docs to exported functions (Alison Schofield)
>>>   - using an array to map the enums to strings (Alison Schofield)
>>>   - clarify comment when using bitmap_subset (Jonathan Cameron)
>>>   - specify link to type2 support in all patches (Alison Schofield)
>>>
>>>    Patches changed (minor): 4, 11
>>>
>> Hi Alejandro,
>> Tried to pull this series using b4. Noticed couple things.
>> 1. Can you run checkpatch on the entire series and fix any issues?
>> 2. Can you rebase against v6.15-rc4? I think there are some conflicts against the fixes went in rc4.
>>
>> Thanks!
>>   
> 
> 
> Hi Dave, I'm afraid I do not know what you mean with b4. Tempted to say it was a typo, but in any case, better if you can clarify.

I use the tool b4 to pull patches off the mailing list. As you can see, your series fail on rc4 apply for patch 18. 

✔ ~/git/cxl-for-next [for-6.16/cxl-type2 L|…138] 
08:08 $ git reset --hard v6.15-rc4
HEAD is now at b4432656b36e Linux 6.15-rc4
✔ ~/git/cxl-for-next [for-6.16/cxl-type2 L|…138] 
08:08 $ b4 shazam -sltSk https://lore.kernel.org/linux-cxl/20250512161055.4100442-1-alejandro.lucero-palau@amd.com/T/#m25a578eb83108678737bf14fdba0d2e5da7f76bd
Grabbing thread from lore.kernel.org/all/20250512161055.4100442-1-alejandro.lucero-palau@amd.com/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 25 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Analyzing 955 code-review messages
Checking attestation on all messages, may take a moment...
---
  [PATCH v15 1/22] cxl: Add type2 device basic support
    + Link: https://patch.msgid.link/20250512161055.4100442-2-alejandro.lucero-palau@amd.com
    + Signed-off-by: Dave Jiang <dave.jiang@intel.com>
    ● checkpatch.pl: 563: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
    ● checkpatch.pl: 773: ERROR: trailing whitespace
  [PATCH v15 2/22] sfc: add cxl support
    + Link: https://patch.msgid.link/20250512161055.4100442-3-alejandro.lucero-palau@amd.com
    + Signed-off-by: Dave Jiang <dave.jiang@intel.com>
    ● checkpatch.pl: 213: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
  [PATCH v15 3/22] cxl: Move pci generic code
    + Acked-by: Edward Cree <ecree.xilinx@gmail.com>
    + Link: https://patch.msgid.link/20250512161055.4100442-4-alejandro.lucero-palau@amd.com
    + Signed-off-by: Dave Jiang <dave.jiang@intel.com>
    ● checkpatch.pl: passed all checks
  [PATCH v15 4/22] cxl: Move register/capability check to driver
    + Link: https://patch.msgid.link/20250512161055.4100442-5-alejandro.lucero-palau@amd.com
    + Signed-off-by: Dave Jiang <dave.jiang@intel.com>
    ● checkpatch.pl: passed all checks
  [PATCH v15 5/22] cxl: Add function for type2 cxl regs setup
    + Link: https://patch.msgid.link/20250512161055.4100442-6-alejandro.lucero-palau@amd.com
    + Signed-off-by: Dave Jiang <dave.jiang@intel.com>
    ● checkpatch.pl: passed all checks
  [PATCH v15 6/22] sfc: make regs setup with checking and set media ready
    + Link: https://patch.msgid.link/20250512161055.4100442-7-alejandro.lucero-palau@amd.com
    + Signed-off-by: Dave Jiang <dave.jiang@intel.com>
    ● checkpatch.pl: passed all checks
  [PATCH v15 7/22] cxl: Support dpa initialization without a mailbox
    + Link: https://patch.msgid.link/20250512161055.4100442-8-alejandro.lucero-palau@amd.com
    + Signed-off-by: Dave Jiang <dave.jiang@intel.com>
    ● checkpatch.pl: passed all checks
  [PATCH v15 8/22] sfc: initialize dpa
    + Link: https://patch.msgid.link/20250512161055.4100442-9-alejandro.lucero-palau@amd.com
    + Signed-off-by: Dave Jiang <dave.jiang@intel.com>
    ● checkpatch.pl: passed all checks
  [PATCH v15 9/22] cxl: Prepare memdev creation for type2
    + Acked-by: Edward Cree <ecree.xilinx@gmail.com>
    + Link: https://patch.msgid.link/20250512161055.4100442-10-alejandro.lucero-palau@amd.com
    + Signed-off-by: Dave Jiang <dave.jiang@intel.com>
    ● checkpatch.pl: passed all checks
  [PATCH v15 10/22] sfc: create type2 cxl memdev
    + Link: https://patch.msgid.link/20250512161055.4100442-11-alejandro.lucero-palau@amd.com
    + Signed-off-by: Dave Jiang <dave.jiang@intel.com>
    ● checkpatch.pl: passed all checks
  [PATCH v15 11/22] cxl: Define a driver interface for HPA free space enumeration
    + Link: https://patch.msgid.link/20250512161055.4100442-12-alejandro.lucero-palau@amd.com
    + Signed-off-by: Dave Jiang <dave.jiang@intel.com>
    ● checkpatch.pl: 133: WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
  [PATCH v15 12/22] sfc: obtain root decoder with enough HPA free space
    + Link: https://patch.msgid.link/20250512161055.4100442-13-alejandro.lucero-palau@amd.com
    + Signed-off-by: Dave Jiang <dave.jiang@intel.com>
    ● checkpatch.pl: passed all checks
  [PATCH v15 13/22] cxl: Define a driver interface for DPA allocation
    + Link: https://patch.msgid.link/20250512161055.4100442-14-alejandro.lucero-palau@amd.com
    + Signed-off-by: Dave Jiang <dave.jiang@intel.com>
    ● checkpatch.pl: 127: WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
  [PATCH v15 14/22] sfc: get endpoint decoder
    + Link: https://patch.msgid.link/20250512161055.4100442-15-alejandro.lucero-palau@amd.com
    + Signed-off-by: Dave Jiang <dave.jiang@intel.com>
    ● checkpatch.pl: passed all checks
  [PATCH v15 15/22] cxl: Make region type based on endpoint type
    + Acked-by: Edward Cree <ecree.xilinx@gmail.com>
    + Link: https://patch.msgid.link/20250512161055.4100442-16-alejandro.lucero-palau@amd.com
    + Signed-off-by: Dave Jiang <dave.jiang@intel.com>
    ● checkpatch.pl: passed all checks
  [PATCH v15 16/22] cxl/region: Factor out interleave ways setup
    + Acked-by: Edward Cree <ecree.xilinx@gmail.com>
    + Link: https://patch.msgid.link/20250512161055.4100442-17-alejandro.lucero-palau@amd.com
    + Signed-off-by: Dave Jiang <dave.jiang@intel.com>
    ● checkpatch.pl: passed all checks
  [PATCH v15 17/22] cxl/region: Factor out interleave granularity setup
    + Acked-by: Edward Cree <ecree.xilinx@gmail.com>
    + Link: https://patch.msgid.link/20250512161055.4100442-18-alejandro.lucero-palau@amd.com
    + Signed-off-by: Dave Jiang <dave.jiang@intel.com>
    ● checkpatch.pl: passed all checks
  [PATCH v15 18/22] cxl: Allow region creation by type2 drivers
    + Link: https://patch.msgid.link/20250512161055.4100442-19-alejandro.lucero-palau@amd.com
    + Signed-off-by: Dave Jiang <dave.jiang@intel.com>
    ● checkpatch.pl: 126: WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
  [PATCH v15 19/22] cxl: Add region flag for precluding a device memory to be used for dax
    + Acked-by: Edward Cree <ecree.xilinx@gmail.com>
    + Link: https://patch.msgid.link/20250512161055.4100442-20-alejandro.lucero-palau@amd.com
    + Signed-off-by: Dave Jiang <dave.jiang@intel.com>
    ● checkpatch.pl: passed all checks
  [PATCH v15 20/22] sfc: create cxl region
    + Link: https://patch.msgid.link/20250512161055.4100442-21-alejandro.lucero-palau@amd.com
    + Signed-off-by: Dave Jiang <dave.jiang@intel.com>
    ● checkpatch.pl: passed all checks
  [PATCH v15 21/22] cxl: Add function for obtaining region range
    + Link: https://patch.msgid.link/20250512161055.4100442-22-alejandro.lucero-palau@amd.com
    + Signed-off-by: Dave Jiang <dave.jiang@intel.com>
    ● checkpatch.pl: passed all checks
  [PATCH v15 22/22] sfc: support pio mapping based on cxl
    + Link: https://patch.msgid.link/20250512161055.4100442-23-alejandro.lucero-palau@amd.com
    + Signed-off-by: Dave Jiang <dave.jiang@intel.com>
    ● checkpatch.pl: 219: CHECK: Unbalanced braces around else statement
  ---
  NOTE: install dkimpy for DKIM signature verification
---
Total patches: 22
---
 Base: using specified base-commit a223ce195741ca4f1a0e1a44f3e75ce5662b6c06
Applying: cxl: Add type2 device basic support
Applying: sfc: add cxl support
Applying: cxl: Move pci generic code
Applying: cxl: Move register/capability check to driver
Applying: cxl: Add function for type2 cxl regs setup
Applying: sfc: make regs setup with checking and set media ready
Applying: cxl: Support dpa initialization without a mailbox
Applying: sfc: initialize dpa
Applying: cxl: Prepare memdev creation for type2
Applying: sfc: create type2 cxl memdev
Applying: cxl: Define a driver interface for HPA free space enumeration
Applying: sfc: obtain root decoder with enough HPA free space
Applying: cxl: Define a driver interface for DPA allocation
Applying: sfc: get endpoint decoder
Applying: cxl: Make region type based on endpoint type
Applying: cxl/region: Factor out interleave ways setup
Applying: cxl/region: Factor out interleave granularity setup
Applying: cxl: Allow region creation by type2 drivers
Patch failed at 0018 cxl: Allow region creation by type2 drivers
/home/djiang5/git/linux-kernel/.git/worktrees/cxl-for-next/rebase-apply/patch:644: trailing whitespace.
 * @type: CXL device type 
warning: 1 line adds whitespace errors.
error: patch failed: drivers/cxl/core/region.c:3607
error: drivers/cxl/core/region.c: patch does not apply
error: patch failed: drivers/cxl/port.c:33
error: drivers/cxl/port.c: patch does not apply
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"


> 
> 
> The patchset is against the last cxl-next commit as it it stated at the end, and that is based on v6.15.0-rc4. I had to solve some issues from v14 as last changes in core/region.c from Robert Richter required so.
> 
> 
> About checkpatch, I did so but I have just done it again for being sure before this email, and I do not seen any issue except a trailing space in patch 1. That same patch has also warnings I do not think are a problem. Some are related to moved code and other on the new macro. FWIW, I'm running those with "checkpatch --strict".
> 
> 
>>>
>>>
>>> base-commit: a223ce195741ca4f1a0e1a44f3e75ce5662b6c06
>>