From: sashiko-bot@kernel.org
To: "Gregory Price (Meta)" <gourry@gourry.net>,
"Yury Norov" <yury.norov@gmail.com>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"David Hildenbrand" <david@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
"Vlastimil Babka" <vbabka@kernel.org>,
"Mike Rapoport" <rppt@kernel.org>,
"Michal Hocko" <mhocko@suse.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Oscar Salvador" <osalvador@suse.de>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Suren Baghdasaryan" <surenb@google.com>,
"Brendan Jackman" <brendan.jackman@linux.dev>,
"Zi Yan" <ziy@nvidia.com>, "Jonathan Corbet" <corbet@lwn.net>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Johan Hovold" <johan@kernel.org>,
"Joshua Hahn" <joshua.hahnjy@gmail.com>,
"Rakie Kim" <rakie.kim@sk.com>,
"Ying Huang" <ying.huang@linux.alibaba.com>,
"Matthew Brost" <matthew.brost@intel.com>,
"Byungchul Park" <byungchul@sk.com>,
"Alistair Popple" <apopple@nvidia.com>, "SJ Park" <sj@kernel.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Juri Lelli" <juri.lelli@redhat.com>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Dietmar Eggemann" <dietmar.eggemann@arm.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Ben Segall" <bsegall@google.com>, "Mel Gorman" <mgorman@suse.de>,
"Valentin Schneider" <vschneid@redhat.com>,
"K Prateek Nayak" <kprateek.nayak@amd.com>,
"Kees Cook" <kees@kernel.org>, "Kairui Song" <kasong@tencent.com>,
"Barry Song" <baohua@kernel.org>, "Qi Zheng" <qi.zheng@linux.dev>,
"Shakeel Butt" <shakeel.butt@linux.dev>,
"Axel Rasmussen" <axelrasmussen@google.com>,
"Yuanchu Xie" <yuanchu@google.com>, "Wei Xu" <weixugc@google.com>,
"Baoquan He" <baoquan.he@linux.dev>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Michal Hocko" <mhocko@kernel.org>,
"David Rientjes" <rientjes@google.com>,
"Pavel Machek" <pavel@kernel.org>, "Len Brown" <lenb@kernel.org>,
"Nico Pache" <nico.pache@linux.dev>,
"Ryan Roberts" <ryan.roberts@arm.com>,
"Dev Jain" <dev.jain@arm.com>,
"Lance Yang" <lance.yang@linux.dev>,
"Usama Arif" <usama.arif@linux.dev>,
"Kiryl Shutsemau" <kas@kernel.org>, "Xu Xin" <xu.xin@linux.dev>,
"Chengming Zhou" <chengming.zhou@linux.dev>,
"Lorenzo Stoakes" <ljs@kernel.org>,
"Pedro Falcato" <pfalcato@suse.de>,
"Jann Horn" <jannh@google.com>, "Chris Li" <chrisl@kernel.org>,
"Kemeng Shi" <shikemeng@huaweicloud.com>,
"Nhat Pham" <nphamcs@gmail.com>,
"Youngjun Park" <youngjun.park@lge.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
"Jan Kara" <jack@suse.cz>, "Waiman Long" <longman@redhat.com>,
"Ridong Chen" <ridong.chen@linux.dev>,
"Tejun Heo" <tj@kernel.org>, "Michal Koutný" <mkoutny@suse.com>,
"Dan Williams" <djbw@kernel.org>,
"Vishal Verma" <vishal.l.verma@intel.com>,
"Dave Jiang" <dave.jiang@intel.com>,
"Alison Schofield" <alison.schofield@intel.com>,
"Shuah Khan" <shuah@kernel.org>
Cc: linux-mm@kvack.org, linux-cxl@vger.kernel.org,
damon@lists.linux.dev, nvdimm@lists.linux.dev
Subject: Re: [PATCH 53/60] mm/mempolicy: add MPOL_F_PRIVATE_NODES for private node bindings
Date: Fri, 20 Nov 2026 18:44:59 +0000 [thread overview]
Message-ID: <sashiko-outbox-225868@kernel.org> (raw)
In-Reply-To: <20261120-private_nodes_v6-v1-53-74f5f9a115c2@gourry.net>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] mm/mempolicy: incomplete suspension of private bindings in
alloc_pages_mpol()
--
commit ca3f7c695f126ea25e293faadb9871a86c3c7899
Author: Gregory Price (Meta) <gourry@gourry.net>
mm/mempolicy: add MPOL_F_PRIVATE_NODES for private node bindings
This commit adds the MPOL_F_PRIVATE_NODES mode flag for mbind() to explicitly
bind a VMA with MPOL_BIND to a single private memory node in
N_MEMORY_MEMPOLICY.
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 9d2e56017ebe5..cb5419cb7ee84 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
[ ... ]
> @@ -2495,10 +2539,20 @@ static struct page *alloc_pages_preferred_many(gfp_t gfp, unsigned int order,
> static struct page *alloc_pages_mpol(gfp_t gfp, unsigned int order,
> struct mempolicy *pol, pgoff_t ilx, int nid)
> {
> + unsigned int alloc_flags = ALLOC_DEFAULT;
> nodemask_t *nodemask;
> struct page *page;
>
> nodemask = policy_nodemask(gfp, pol, ilx, &nid);
> + if (nodemask && (pol->flags & MPOL_F_PRIVATE_NODES)) {
> + int private_nid = first_node(*nodemask);
> +
> + if (node_state(private_nid, N_MEMORY_MEMPOLICY) &&
> + node_state(private_nid, N_MEMORY_PRIVATE)) {
> + nid = private_nid;
> + alloc_flags = ALLOC_ZONELIST_PRIVATE;
> + }
> + }
>
> if (pol->mode == MPOL_PREFERRED_MANY)
> return alloc_pages_preferred_many(gfp, order, nid, nodemask);
> @@ -2520,24 +2574,26 @@ static struct page *alloc_pages_mpol(gfp_t gfp, unsigned int order,
> pol->mode != MPOL_WEIGHTED_INTERLEAVE &&
> (!nodemask || node_isset(nid, *nodemask))) {
> /*
> - * First, try to allocate THP only on local node, but
> + * First, try to allocate THP only on the selected node, but
> * don't reclaim unnecessarily, just compact.
> */
> page = __alloc_frozen_pages_noprof(
> gfp | __GFP_THISNODE | __GFP_NORETRY, order,
> - nid, NULL, ALLOC_DEFAULT);
> + nid, (alloc_flags & ALLOC_ZONELIST_PRIVATE) ?
> + nodemask : NULL, alloc_flags);
> if (page || !(gfp & __GFP_DIRECT_RECLAIM))
> return page;
> /*
> * If hugepage allocations are configured to always
> * synchronous compact or the vma has been madvised
> * to prefer hugepage backing, retry allowing remote
> - * memory with both reclaim and compact as well.
> + * memory with both reclaim and compact as well. A
> + * private binding stays on its local zonelist.
> */
> }
> }
>
> - page = __alloc_frozen_pages_noprof(gfp, order, nid, nodemask, ALLOC_DEFAULT);
> + page = __alloc_frozen_pages_noprof(gfp, order, nid, nodemask, alloc_flags);
[Severity: High]
Does alloc_pages_mpol() fail to suspend a private binding to common memory
when private_nid becomes ineligible without returning as N_MEMORY_COMMON?
When private_nid is not in both N_MEMORY_MEMPOLICY and N_MEMORY_PRIVATE,
alloc_pages_mpol() leaves nodemask set to &pol->nodes with alloc_flags =
ALLOC_DEFAULT instead of clearing nodemask to NULL when
!node_state(private_nid, N_MEMORY_COMMON).
If private_nid is offlined, node_clear_memory_state() clears N_MEMORY_PRIVATE
and N_HIGH_MEMORY, so apply_policy_zone() still accepts ZONE_MOVABLE faults.
When CONFIG_CPUSETS=n (or before cpuset hotplug work updates
current->mems_allowed), policy_nodemask() still returns &pol->nodes. Passing
nodemask = &pol->nodes with ALLOC_DEFAULT finds no zones in ZONELIST_FALLBACK,
and in __alloc_pages_slowpath() alloc_is_private() returns false because
ALLOC_ZONELIST_PRIVATE is not set and N_MEMORY_PRIVATE was already cleared:
mm/page_alloc.c:alloc_is_private() {
if (ac->alloc_flags & ALLOC_ZONELIST_PRIVATE)
return true;
return ac->nodemask &&
nodes_intersects(*ac->nodemask, node_states[N_MEMORY_PRIVATE]);
}
As a result, relax_private_alloc() does not relax ac->nodemask, the fault
fails without setting current->private_alloc_failed, and handle_mm_fault()
returns VM_FAULT_OOM and invokes the global OOM killer instead of falling
back to common memory. Likewise, if private_nid stays online in
N_MEMORY_PRIVATE without N_MEMORY_MEMPOLICY, leaving nodemask = &pol->nodes
with ALLOC_DEFAULT misses the fastpath on every fault and forces every
allocation through __alloc_pages_slowpath() and relax_private_alloc().
In addition, if set_mempolicy_home_node() was used to set pol->home_node to
private_nid, policy_nodemask() unconditionally sets *nid = pol->home_node
even when the private binding is suspended:
mm/mempolicy.c:policy_nodemask() {
...
case MPOL_BIND:
if (apply_policy_zone(pol, gfp_zone(current_gfp_context(gfp))) &&
cpuset_nodemask_valid_mems_allowed(&pol->nodes))
nodemask = &pol->nodes;
if (pol->home_node != NUMA_NO_NODE)
*nid = pol->home_node;
break;
...
}
On the PMD THP branch in alloc_pages_mpol(), __alloc_frozen_pages_noprof() is
then called with __GFP_THISNODE, nid = private_nid, and ALLOC_DEFAULT, which
selects private_nid's empty ZONELIST_NOFALLBACK and causes
GFP_TRANSHUGE_LIGHT allocations (!(gfp & __GFP_DIRECT_RECLAIM)) to return
NULL instead of allocating from common memory.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-private_nodes_v6-v1-0-74f5f9a115c2@gourry.net?part=53
next prev parent reply other threads:[~2026-11-20 18:45 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 18:08 [PATCH 00/60] Private NUMA nodes Gregory Price via B4 Relay
2026-11-20 18:08 ` [PATCH 01/60] nodemask: add node-state iterators Gregory Price via B4 Relay
2026-11-20 18:08 ` [PATCH 02/60] mm: publish and clear node memory states via helpers Gregory Price via B4 Relay
2026-11-20 18:08 ` [PATCH 03/60] mm: introduce the common-memory node state Gregory Price via B4 Relay
2026-11-20 18:08 ` [PATCH 04/60] mm/page_alloc: build zonelists from common memory Gregory Price via B4 Relay
2026-11-20 18:08 ` [PATCH 05/60] mm/mempolicy: keep interleave and tmpfs mount policies on " Gregory Price via B4 Relay
2026-11-20 18:08 ` [PATCH 06/60] mm/memory_hotplug: migrate offlined pages to " Gregory Price via B4 Relay
2026-11-20 18:08 ` [PATCH 07/60] mm/memory-tiers: restrict demotion topology " Gregory Price via B4 Relay
2026-11-20 18:08 ` [PATCH 08/60] mm/migrate: reject move_pages() destinations outside " Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 09/60] mm/damon: reject migration " Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 10/60] sched/numa: restrict NUMA migration targets to " Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 11/60] fork: check cached stack locality only on common memory nodes Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 12/60] mm/vmscan: restrict reclaim to common memory Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 13/60] mm/compaction: restrict compaction " Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 14/60] mm: base hash distribution on common memory nodes Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 15/60] mm/page_alloc: count common memory nodes for kswapd recovery Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 16/60] mm/oom_kill: compare OOM constraints against common memory Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 17/60] PM: hibernate: size the image from " Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 18/60] mm/khugepaged: base the recommended min_free_kbytes on " Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 19/60] mm: add folio_is_common_memory() and page_is_common_memory() Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 20/60] mm/ksm: restrict merging to common memory Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 21/60] mm/khugepaged: restrict collapse " Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 22/60] mm/mempolicy: don't NUMA-hint folios outside " Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 23/60] mm/damon: restrict DAMON-native folio operations to " Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 24/60] mm/madvise: restrict reclaim advice " Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 25/60] mm/mempolicy: queue only common memory for mbind() and migrate_pages() Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 26/60] mm/migrate: leave pages outside common memory in move_pages() Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 27/60] mm: add the private-memory node state Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 28/60] mm: select memory features per node Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 29/60] mm: keep private memory out of the system memory totals Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 30/60] mm/memory_hotplug: keep private memory out of the auto-movable ratio Gregory Price via B4 Relay
2026-11-20 18:33 ` sashiko-bot
2026-11-20 18:09 ` [PATCH 31/60] cgroup/cpuset: inherit common memory when a nodemask is private only Gregory Price via B4 Relay
2026-11-20 18:43 ` sashiko-bot
2026-11-20 18:09 ` [PATCH 32/60] cgroup/cpuset: keep spread page cache off private nodes Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 33/60] cgroup/cpuset: ignore private nodes when matching OOM victims Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 34/60] mm/mempolicy: don't rebind policies onto private nodes Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 35/60] mm/mempolicy: keep private nodes out of migrate_pages() destinations Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 36/60] mm: refuse explicit reclaim and compaction of private nodes Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 37/60] mm/page_alloc: keep private memory out of reclaim reserves Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 38/60] mm/page_alloc: refuse contiguous allocation from private memory Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 39/60] mm/page_alloc: add a private-node zonelist Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 40/60] mm/page_alloc: let MM callers select the local private zonelist Gregory Price via B4 Relay
2026-11-20 18:46 ` sashiko-bot
2026-11-20 18:09 ` [PATCH 41/60] mm/page_alloc: relax a private request whose node becomes ineligible Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 42/60] mm: fail private placement on exhaustion instead of OOM killing Gregory Price via B4 Relay
2026-11-20 18:40 ` sashiko-bot
2026-11-20 18:09 ` [PATCH 43/60] mm/page_alloc: fall back when a bind policy's nodes become private Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 44/60] mm: add N_MEMORY_COMPACTION node state Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 45/60] mm/compaction: restrict compaction to N_MEMORY_COMPACTION Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 46/60] mm: add N_MEMORY_RECLAIM node state Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 47/60] mm/vmscan: restrict reclaim to N_MEMORY_RECLAIM instead of N_MEMORY_COMMON Gregory Price via B4 Relay
2026-11-20 18:38 ` sashiko-bot
2026-11-20 18:41 ` Gregory Price (Meta)
2026-11-20 18:09 ` [PATCH 48/60] mm/madvise: restrict reclaim advice to reclaim-capable memory Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 49/60] mm/vmscan: reclaim private nodes for memcg Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 50/60] mm: add N_MEMORY_MEMPOLICY node state Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 51/60] mm: restrict explicit migration to N_MEMORY_MEMPOLICY Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 52/60] mm: count memory with userspace placement as general purpose Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 53/60] mm/mempolicy: add MPOL_F_PRIVATE_NODES for private node bindings Gregory Price via B4 Relay
2026-11-20 18:44 ` sashiko-bot [this message]
2026-11-20 18:09 ` [PATCH 54/60] mm/migrate: route explicit NUMA migration to private nodes Gregory Price via B4 Relay
2026-11-20 18:42 ` sashiko-bot
2026-11-20 18:56 ` Gregory Price (Meta)
2026-11-20 18:09 ` [PATCH 55/60] mm/memory_hotplug: online and offline private memory nodes Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 56/60] dax/kmem: add a private memory mode Gregory Price via B4 Relay
2026-11-20 18:09 ` [PATCH 57/60] selftests/dax: test private kmem devices and services Gregory Price via B4 Relay
2026-11-20 18:42 ` sashiko-bot
2026-11-20 18:09 ` [PATCH 58/60] selftests/dax: test memory policy on private nodes Gregory Price via B4 Relay
2026-11-20 18:35 ` sashiko-bot
2026-11-20 18:09 ` [PATCH 59/60] selftests/dax: test cpuset interaction with " Gregory Price via B4 Relay
2026-11-20 18:35 ` sashiko-bot
2026-11-20 18:09 ` [PATCH 60/60] Documentation/mm: describe private memory nodes Gregory Price via B4 Relay
2026-11-20 18:59 ` [PATCH 00/60] Private NUMA nodes Gregory Price (Meta)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-225868@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alison.schofield@intel.com \
--cc=apopple@nvidia.com \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=baoquan.he@linux.dev \
--cc=brendan.jackman@linux.dev \
--cc=bsegall@google.com \
--cc=byungchul@sk.com \
--cc=chengming.zhou@linux.dev \
--cc=chrisl@kernel.org \
--cc=corbet@lwn.net \
--cc=dakr@kernel.org \
--cc=damon@lists.linux.dev \
--cc=dave.jiang@intel.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=djbw@kernel.org \
--cc=gourry@gourry.net \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=jannh@google.com \
--cc=johan@kernel.org \
--cc=joshua.hahnjy@gmail.com \
--cc=juri.lelli@redhat.com \
--cc=kas@kernel.org \
--cc=kasong@tencent.com \
--cc=kees@kernel.org \
--cc=kprateek.nayak@amd.com \
--cc=lance.yang@linux.dev \
--cc=lenb@kernel.org \
--cc=liam@infradead.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=ljs@kernel.org \
--cc=longman@redhat.com \
--cc=matthew.brost@intel.com \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=mkoutny@suse.com \
--cc=nico.pache@linux.dev \
--cc=nphamcs@gmail.com \
--cc=nvdimm@lists.linux.dev \
--cc=osalvador@suse.de \
--cc=pavel@kernel.org \
--cc=peterz@infradead.org \
--cc=pfalcato@suse.de \
--cc=qi.zheng@linux.dev \
--cc=rafael@kernel.org \
--cc=rakie.kim@sk.com \
--cc=rdunlap@infradead.org \
--cc=ridong.chen@linux.dev \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=shikemeng@huaweicloud.com \
--cc=shuah@kernel.org \
--cc=sj@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=surenb@google.com \
--cc=tj@kernel.org \
--cc=usama.arif@linux.dev \
--cc=vbabka@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vishal.l.verma@intel.com \
--cc=vschneid@redhat.com \
--cc=weixugc@google.com \
--cc=willy@infradead.org \
--cc=xu.xin@linux.dev \
--cc=ying.huang@linux.alibaba.com \
--cc=youngjun.park@lge.com \
--cc=yuanchu@google.com \
--cc=yury.norov@gmail.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox