From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Imran Shaik <imran.shaik@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney@redhat.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: Ajit Pandey <ajit.pandey@oss.qualcomm.com>,
Taniya Das <taniya.das@oss.qualcomm.com>,
Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/4] clk: qcom: Add Audio Core clock controller support on Qualcomm Shikra SoC
Date: Thu, 11 Jun 2026 13:22:56 +0200 [thread overview]
Message-ID: <02a767ef-0d6e-476e-a535-52b55d082b65@oss.qualcomm.com> (raw)
In-Reply-To: <20260605-shikra-audiocorecc-v1-3-7ee6b5f2d928@oss.qualcomm.com>
On 6/5/26 1:26 PM, Imran Shaik wrote:
> Add support for Audio Core Clock Controller (AUDIOCORECC) on Qualcomm
> Shikra SoC. The AUDIOCORECC clocks and resets support differs based on
> Audio subsystem enablement. In the CQM variant, both clocks and resets
> are required as Audio is on APPS, while in the CQS variant only reset
> control is required since Audio is handled on Modem. Handle these
> requirements using variant specific compatibles.
>
> Signed-off-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
> ---
[...]
> +static int audio_core_cc_shikra_probe(struct platform_device *pdev)
> +{
> + int ret;
> +
> + ret = qcom_cc_probe_by_index(pdev, 1, &audio_core_cc_shikra_reset_desc);
> + if (ret)
> + return ret;
> +
> + if (device_is_compatible(&pdev->dev, "qcom,shikra-cqs-audiocorecc"))
> + return 0;
> +
> + return qcom_cc_probe(pdev, &audio_core_cc_shikra_desc);
> +}
If the clock list is complete and you pinky-promise to never extend it,
we can simply go with a single compatible and use protected-clocks in DT
to avoid accessing any of these registers (sorta like kodiak GCC), removing
the complexity
Konrad
next prev parent reply other threads:[~2026-06-11 11:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 11:26 [PATCH 0/4] clk: qcom: Add Audio Core clock controller support on Qualcomm Shikra SoC Imran Shaik
2026-06-05 11:26 ` [PATCH 1/4] clk: qcom: common: Register reset controller only when resets are present Imran Shaik
2026-06-05 11:26 ` [PATCH 2/4] dt-bindings: clock: qcom: Add Qualcomm Shikra Audio Core Clock Controller Imran Shaik
2026-06-07 11:18 ` Dmitry Baryshkov
2026-06-29 5:21 ` Imran Shaik
2026-06-08 10:49 ` Krzysztof Kozlowski
2026-06-29 5:28 ` Imran Shaik
2026-06-05 11:26 ` [PATCH 3/4] clk: qcom: Add Audio Core clock controller support on Qualcomm Shikra SoC Imran Shaik
2026-06-11 11:22 ` Konrad Dybcio [this message]
2026-06-11 11:27 ` Konrad Dybcio
2026-06-29 5:19 ` Imran Shaik
2026-06-05 11:26 ` [PATCH 4/4] arm64: dts: qcom: shikra: Add support for AudioCoreCC node Imran Shaik
2026-06-11 11:25 ` Konrad Dybcio
2026-06-29 5:20 ` Imran Shaik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02a767ef-0d6e-476e-a535-52b55d082b65@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=ajit.pandey@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imran.shaik@oss.qualcomm.com \
--cc=jagadeesh.kona@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=taniya.das@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox