Devicetree
 help / color / mirror / Atom feed
From: E Shattow <e@freeshell.de>
To: Yixun Lan <dlan@kernel.org>,
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	"Martin K. Petersen" <mkp@kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Avri Altman <avri.altman@sandisk.com>,
	Bart Van Assche <bvanassche@acm.org>,
	Bean Huo <beanhuo@micron.com>,
	Stanley Jhu <stanleyjhu@google.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>,
	Jennifer Berringer <jberring@redhat.com>,
	Trevor Gamblin <tgamblin@baylibre.com>,
	linux-scsi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Subject: Re: [PATCH v8 0/2] Add UFS Host driver support for SpacemiT K3 SoC
Date: Wed, 18 Nov 2026 23:38:01 -0800	[thread overview]
Message-ID: <053b55fe-47d0-4cc7-ba53-c560fc9c1d1b@freeshell.de> (raw)
In-Reply-To: <avyusx36U534Bpu9@aurel32.net>

Hi Yixun, and Aurelien,

On 11/17/26 11:44, Aurelien Jarno wrote:
> Hi,
> 
> On 2026-11-16 17:15, E Shattow wrote:
>> Hi Yixun,
>>
>> On 11/15/26 19:46, Yixun Lan wrote:
>>> This series try to add UFS support for SpacemiT K3 SoC, the controller
>>> components consists of System Bus Interface Unit, UFS Host Controller
>>> Interface, UFS Transport Protocol Layer, UFS Host Registers, Device
>>> Management Entity (DME), Transport Layer, Network Layer, Data Link
>>> Layer, PHY Adapter Layer, and M-PHY Interface. A more detail functional
>>> block diagram can be found in SpacemiT website, chapter 9.7.3 [1]
>>>
>>> The DTS patch has been dropped in this series [2], and will send
>>> in separate series once this patch accepted. For people who want to
>>> test UFS driver, please grab the DT patch from version v5 [3].
>>>
>>> Enable UFSHCD_CAP_KEEP_AUTO_BKOPS_ENABLED_EXCEPT_SUSPEND,
>>> This allows the device auto-bkops to be always enabled except
>>> during suspend (both runtime and suspend), with this feature,
>>> the BKOPS interrupt (log below) isn't reported anymore.
>>>
>>> [  806.710763] ufshcd-spacemit c0e00000.ufshc: ufshcd_bkops_exception_event_handler: device raised urgent BKOPS exception for bkops status 1
>>>
>>> Link: https://spacemit.com/community/document/info?nodepath=hardware/key_stone/k3/k3_docs/k3_usermanual/09_memory_storage.md&lang=en [1]
>>> Link: https://lore.kernel.org/all/20260918-belligerent-succinct-kraken-7fa592@quoll/ [2]
>>> Link: https://lore.kernel.org/all/20260916-08-k3-ufs-support-v5-3-1f5d71f1027d@kernel.org/ [3]
>>> Signed-off-by: Yixun Lan <dlan@kernel.org>
>>> ---
>>> Changes in v8:
>>> - enable UFSHCD_CAP_KEEP_AUTO_BKOPS_ENABLED_EXCEPT_SUSPEND
>>> - rename to "ref_clk", see explanation in patch
>>> - add delay between enable clk & deassert reset
>>> - respect bRefClkGatingWaitTime, add wait delay
>>> - drop comment of ufs_hba_spacemit_vops, which got CI complaint
>>> - rebase to v7.4-rc1
>>> - Link to v7: https://patch.msgid.link/20261002-08-k3-ufs-support-v7-0-bb39007ff9ae@kernel.org
>>>
>>> Changes in v7:
>>> - check err return value of ufs_spacemit_quirk_host_pa_saveconfigtime()
>>> - Link to v6: https://patch.msgid.link/20260921-08-k3-ufs-support-v6-0-3479768a2299@kernel.org
>>>
>>> Changes in v6:
>>> - drop unused macro and dev_req_params
>>> - use global PX_xx macros
>>> - fix axi clock name
>>> - drop dts patch
>>> - collect tags
>>> - Link to v5: https://patch.msgid.link/20260916-08-k3-ufs-support-v5-0-1f5d71f1027d@kernel.org
>>>
>>> Changes in v5:
>>> - adjust clock names
>>> - add runtime power support
>>> - collect tags
>>> - Link to v4: https://patch.msgid.link/20260908-08-k3-ufs-support-v4-0-22aa2bd97d3b@kernel.org
>>>
>>> Changes in v4:
>>> - fix clock and reset settings
>>> - drop function which retrieve value of tx_lanes
>>> - propagate return error of ufs_spacemit_dme_set()
>>> - check return value ufs_spacemit_check_hibern8()
>>> - drop call to ufshcd_vops_phy_initialization()
>>> - handle compiling warning if CONFIG_OF not enabled
>>>  add __maybe_unused to ufs_spacemit_of_match
>>> - Link to v3: https://patch.msgid.link/20260806-08-k3-ufs-support-v3-0-037fb322acdb@kernel.org
>>>
>>> Changes in v3:
>>> - collect tags
>>> - fix dt-binding warning reported-by sashiko
>>> - fix low freq in opp-2 table
>>> - fix err checking in check_hibern8()
>>> - propagate err code in link_startup_notify()
>>> - update documents for event_notify()
>>> - ufs clock driver is merged into v7.3-rc1, update cover letter
>>> - Link to v2: https://patch.msgid.link/20260725-08-k3-ufs-support-v2-0-45036a2a2418@kernel.org
>>>
>>> Changes in v2:
>>> - fix missing interrupts property
>>> - move ufs node to k3-com260.dtsi
>>> - convert freq-table-hz to operating-points-v2
>>> - rework reset_control, fix header and drop global variable
>>> - drop dump_host_regs() debug interface
>>> - converge and refactor dme_set() operations
>>> - massive reduce of busy delay() loops
>>> - drop vendor specific hce_enable_notify(), fallback to default
>>> - drop unused member from struct ufs_spacemit_host
>>> - add COMPILE_TEST support to Kconfig
>>> - comment style fix
>>> - Link to v1: https://patch.msgid.link/20260702-08-k3-ufs-support-v1-0-1a64a3ab128f@kernel.org
>>>
>>> ---
>>> Yixun Lan (2):
>>>       scsi: ufs: spacemit: dt-bindings: Add UFS controller for K3 SoC
>>>       scsi: ufs: spacemit: k3: Add UFS Host Controller driver
>>>
>>>  .../devicetree/bindings/ufs/spacemit,k3-ufshc.yaml |  56 ++
>>>  drivers/ufs/host/Kconfig                           |  12 +
>>>  drivers/ufs/host/Makefile                          |   1 +
>>>  drivers/ufs/host/ufs-spacemit.c                    | 655 +++++++++++++++++++++
>>>  drivers/ufs/host/ufs-spacemit.h                    |  77 +++
>>>  5 files changed, 801 insertions(+)
>>> ---
>>> base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
>>> change-id: 20260605-08-k3-ufs-support-c8b308e415e2
>>>
>>> Best regards,
>>> --  
>>> Yixun Lan <dlan@kernel.org>
>>>
>>>
>>> _______________________________________________
>>> linux-riscv mailing list
>>> linux-riscv@lists.infradead.org
>>> http://lists.infradead.org/mailman/listinfo/linux-riscv
>>
>> Tested v7 and v8 successfully on Sipeed K3 Pico-ITX (32GiB DRAM / 128GiB
>> UFS model). Build and test methodology:
>>
>> ### build chimera debian-installer with patched mainline kernel
>> ### assume fresh Debian testing "forky" build environment
>>
>> apt update
>> apt install -y b4 bc bison ca-certificates cpio \
>>  crossbuild-essential-riscv64 curl debhelper fakeroot flex kmod \
>>  libdw-dev libssl-dev libssl-dev:riscv64 linux-config-7.2:riscv64 \
>>  python3 rsync
>>
>> curl -L \
>>  https://git.kernel.org/torvalds/t/linux-7.4-rc3.tar.gz \
>>  | tar xz
>>
>> pushd linux-7.4-rc3
>> b4 am -v1 -o- \
>>  https://lore.kernel.org/all/20261115195112.32120-1-e@freeshell.de/ \
>>  | patch -p1
>> b4 am -v5 -P3 -o- \
>>  https://lore.kernel.org/all/20260916-08-k3-ufs-support-v5-0-1f5d71f1027d@kernel.org/ \
>>  | patch -p1
> 
> After applying that patch, you also need to change:
>   clock-names = "axi", "ref";
> into
>   clock-names = "axi", "ref_clk";
> to match the change done in the code in v8.
> 
> [...]
>

I was missing this detail previously. For testing again of v8 I have now
inserted a sed pipe to change this as suggested for the dts application
step of the build procedure:

b4 am -v5 -P3 -o- \
 https://lore.kernel.org/all/20260916-08-k3-ufs-support-v5-0-1f5d71f1027d@kernel.org/ \
 | sed -z 's%\(clock-names = "axi", "\)ref\(";\)%\1ref_clk\2%' \
 | patch -p1

Additionally to the build procedure, since Debian testing now features
linux-config-7.3 and no longer linux-config-7.2, I now substitute
accordingly from linux-config-7.2 to linux-config-7.3

>> I do notice some UFS-related warnings and errors in dmesg:
>>
>> journalctl --dmesg | grep ufshcd
>> ufshcd-spacemit c0e00000.ufshc: freq-table-hz property not specified
>> ufshcd-spacemit c0e00000.ufshc: ufshcd_populate_vreg: Unable to find
>> vdd-hba-supply regulator, assuming enabled
>> ufshcd-spacemit c0e00000.ufshc: ufshcd_populate_vreg: Unable to find
>> vcc-supply regulator, assuming enabled
>> ufshcd-spacemit c0e00000.ufshc: ufshcd_populate_vreg: Unable to find
>> vccq-supply regulator, assuming enabled
>> ufshcd-spacemit c0e00000.ufshc: ufshcd_populate_vreg: Unable to find
>> vccq2-supply regulator, assuming enabled
>> scsi host0: ufshcd
>> ufshcd-spacemit c0e00000.ufshc: ufshcd_scsi_add_wlus: BOOT WLUN not found
> 
> I do have all those messages, I think they are just harmless.
> 
>> ufshcd-spacemit c0e00000.ufshc: DL error event, INT errors:0x4,
>> DL_ERR:0x80000020
> 
> This one looks more worrying. I do not have it when testing. Does it 
> happens immediately or after a while? under load?
> 
> Regards
> Aurelien
> 

$ journalctl --dmesg | grep ufshcd
ufshcd-spacemit c0e00000.ufshc: freq-table-hz property not specified
ufshcd-spacemit c0e00000.ufshc: ufshcd_populate_vreg: Unable to find
vdd-hba-supply regulator, assuming enabled
ufshcd-spacemit c0e00000.ufshc: ufshcd_populate_vreg: Unable to find
vcc-supply regulator, assuming enabled
ufshcd-spacemit c0e00000.ufshc: ufshcd_populate_vreg: Unable to find
vccq-supply regulator, assuming enabled
ufshcd-spacemit c0e00000.ufshc: ufshcd_populate_vreg: Unable to find
vccq2-supply regulator, assuming enabled
scsi host0: ufshcd
ufshcd-spacemit c0e00000.ufshc: ufshcd_scsi_add_wlus: BOOT WLUN not found

I did not again see the DL error event. However, the first attempt to
build Linux does fail:

make[7]: *** [scripts/Makefile.build:572: drivers/gpu/drm] Error 2
make[6]: *** [scripts/Makefile.build:572: drivers/gpu] Error 2
...
make[5]: *** [scripts/Makefile.build:572: drivers] Error 2
make[4]: *** [Makefile:2244: .] Error 2
make[3]: *** [debian/rules:80: build-arch] Error 2
dpkg-buildpackage: error: make -f debian/rules binary subprocess failed
with exit status 2
make[2]: *** [scripts/Makefile.package:126: bindeb-pkg] Error 2
make[1]: *** [/home/es/linux-7.4-rc3/Makefile:1852: bindeb-pkg] Error 2
make: *** [Makefile:248: __sub-make] Error 2

real    188m48.844s
user    1415m17.363s
sys     66m11.932s

Linux is running on the K3 SoC here without clocks preparation from the
bootloader; it is quite slow by comparison to a Linux kernel that
follows clock preparations by the vendor BSP bootloader. Simply
re-running the same "make ..." build command is successful in the same
system without any changes:

  DEPMOD  debian/linux-image-7.4.0-rc3-k3ufs/lib/modules/7.4.0-rc3-k3ufs
...
dpkg-deb: building package 'linux-image-7.4.0-rc3-k3ufs' in
'../linux-image-7.4.0-rc3-k3ufs_7.4.0~rc3-2_riscv64.deb'.
...
real    34m56.794s
user    241m15.511s
sys     18m4.532s

Similar build failures occasionally happen when the root filesystem is
on USB microSD adapter-connected microSD storage. I assume the build
failures with default clocks configuration are not constrained to just
the UFS support series here.

-E

  reply	other threads:[~2026-11-19  7:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  3:46 [PATCH v8 0/2] Add UFS Host driver support for SpacemiT K3 SoC Yixun Lan
2026-11-16  3:46 ` [PATCH v8 1/2] scsi: ufs: spacemit: dt-bindings: Add UFS controller for " Yixun Lan
2026-11-16  3:46 ` [PATCH v8 2/2] scsi: ufs: spacemit: k3: Add UFS Host Controller driver Yixun Lan
2026-11-16  4:16   ` sashiko-bot
2026-11-17 19:44   ` Aurelien Jarno
2026-11-17  1:15 ` [PATCH v8 0/2] Add UFS Host driver support for SpacemiT K3 SoC E Shattow
2026-11-17  3:17   ` Yixun Lan
2026-11-17 19:44   ` Aurelien Jarno
2026-11-19  7:38     ` E Shattow [this message]
2026-11-19 16:55       ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=053b55fe-47d0-4cc7-ba53-c560fc9c1d1b@freeshell.de \
    --to=e@freeshell.de \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=alex@ghiti.fr \
    --cc=alim.akhtar@samsung.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=asrinivasan@oss.tenstorrent.com \
    --cc=avri.altman@sandisk.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@kernel.org \
    --cc=jberring@redhat.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mkp@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=spacemit@lists.linux.dev \
    --cc=stanleyjhu@google.com \
    --cc=tgamblin@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox