From: Tao Ren <taoren@fb.com>
To: Joel Stanley <joel@jms.id.au>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree <devicetree@vger.kernel.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
Andrew Jeffery <andrew@aj.id.au>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: aspeed: Add Facebook Wedge100 BMC
Date: Fri, 2 Aug 2019 03:56:11 +0000 [thread overview]
Message-ID: <0862C896-35D3-4032-8DA8-E4B7632CC333@fb.com> (raw)
In-Reply-To: <CACPK8XdS4m9+74oxK0-ed3ZLr_QCh--AsFgGcF-OpLw24v9g4Q@mail.gmail.com>
On 8/1/19, 8:02 PM, "Joel Stanley" <joel@jms.id.au> wrote:
> On Fri, 2 Aug 2019 at 01:02, Tao Ren <taoren@fb.com> wrote:
>> +
>> + chosen {
>> + stdout-path = &uart3;
>> + bootargs = "debug console=ttyS2,9600n8 root=/dev/ram rw";
>
> Are you sure you want 'debug' in your boot arguments?
>
> The rest lgtm. I can remove debug when applying, or leave it there if
> it was intentional.
Ahh, I copied bootargs from "/proc/cmdline" on my machine (running old kernel) but I don't think I need it.
Thank you for pointing it out. Let me send out v2 patches in a few minutes (so you could apply without extra changes).
Cheers,
Tao
prev parent reply other threads:[~2019-08-02 3:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 1:01 [PATCH] ARM: dts: aspeed: Add Facebook Wedge100 BMC Tao Ren
2019-08-02 2:55 ` Andrew Jeffery
2019-08-02 3:02 ` Joel Stanley
2019-08-02 3:56 ` Tao Ren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0862C896-35D3-4032-8DA8-E4B7632CC333@fb.com \
--to=taoren@fb.com \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox