Devicetree
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: renesas: r9a09g011: Add missing space in compatible
@ 2023-11-25 23:32 Niklas Söderlund
  2023-11-26 12:42 ` Krzysztof Kozlowski
  2023-11-27 14:08 ` Geert Uytterhoeven
  0 siblings, 2 replies; 5+ messages in thread
From: Niklas Söderlund @ 2023-11-25 23:32 UTC (permalink / raw)
  To: Geert Uytterhoeven, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-renesas-soc, devicetree, Niklas Söderlund

Add missing space in compatible property and align style with rest of
the file.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 arch/arm64/boot/dts/renesas/r9a09g011.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi
index 33f2ecf42441..50ed66d42a24 100644
--- a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi
@@ -163,7 +163,7 @@ usb3peri: usb3peri@85070000 {
 		};
 
 		avb: ethernet@a3300000 {
-			compatible = "renesas,etheravb-r9a09g011","renesas,etheravb-rzv2m";
+			compatible = "renesas,etheravb-r9a09g011", "renesas,etheravb-rzv2m";
 			reg = <0 0xa3300000 0 0x800>;
 			interrupts = <GIC_SPI 251 IRQ_TYPE_LEVEL_HIGH>, /* ch0: Rx0 BE */
 				     <GIC_SPI 252 IRQ_TYPE_LEVEL_HIGH>, /* ch1: Rx1 NC */
-- 
2.42.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm64: dts: renesas: r9a09g011: Add missing space in compatible
  2023-11-25 23:32 [PATCH] arm64: dts: renesas: r9a09g011: Add missing space in compatible Niklas Söderlund
@ 2023-11-26 12:42 ` Krzysztof Kozlowski
  2023-11-26 13:04   ` Niklas Söderlund
  2023-11-27 14:08 ` Geert Uytterhoeven
  1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-26 12:42 UTC (permalink / raw)
  To: Niklas Söderlund, Geert Uytterhoeven, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-renesas-soc, devicetree

On 26/11/2023 00:32, Niklas Söderlund wrote:
> Add missing space in compatible property and align style with rest of
> the file.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

These are trivialities. Squash per subsystem please.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm64: dts: renesas: r9a09g011: Add missing space in compatible
  2023-11-26 12:42 ` Krzysztof Kozlowski
@ 2023-11-26 13:04   ` Niklas Söderlund
  2023-11-27  7:05     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 5+ messages in thread
From: Niklas Söderlund @ 2023-11-26 13:04 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Geert Uytterhoeven, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-renesas-soc, devicetree

On 2023-11-26 13:42:34 +0100, Krzysztof Kozlowski wrote:
> On 26/11/2023 00:32, Niklas Söderlund wrote:
> > Add missing space in compatible property and align style with rest of
> > the file.
> > 
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> 
> These are trivialities. Squash per subsystem please.

Happy to do so, but could not figure out a good patch subject to match 
current style to hit both ARM and arm64. Would "dts: renesas: Add 
missing space in compatibles" be appropriate?

> 
> Best regards,
> Krzysztof
> 

-- 
Kind Regards,
Niklas Söderlund

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm64: dts: renesas: r9a09g011: Add missing space in compatible
  2023-11-26 13:04   ` Niklas Söderlund
@ 2023-11-27  7:05     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-27  7:05 UTC (permalink / raw)
  To: Niklas Söderlund
  Cc: Geert Uytterhoeven, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-renesas-soc, devicetree

On 26/11/2023 14:04, Niklas Söderlund wrote:
> On 2023-11-26 13:42:34 +0100, Krzysztof Kozlowski wrote:
>> On 26/11/2023 00:32, Niklas Söderlund wrote:
>>> Add missing space in compatible property and align style with rest of
>>> the file.
>>>
>>> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>>
>> These are trivialities. Squash per subsystem please.
> 
> Happy to do so, but could not figure out a good patch subject to match 
> current style to hit both ARM and arm64. Would "dts: renesas: Add 
> missing space in compatibles" be appropriate?

Ah, I missed the different prefixes. Sorry, it's fine then.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm64: dts: renesas: r9a09g011: Add missing space in compatible
  2023-11-25 23:32 [PATCH] arm64: dts: renesas: r9a09g011: Add missing space in compatible Niklas Söderlund
  2023-11-26 12:42 ` Krzysztof Kozlowski
@ 2023-11-27 14:08 ` Geert Uytterhoeven
  1 sibling, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2023-11-27 14:08 UTC (permalink / raw)
  To: Niklas Söderlund
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-renesas-soc,
	devicetree

On Sun, Nov 26, 2023 at 12:32 AM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> Add missing space in compatible property and align style with rest of
> the file.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.8.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-11-27 14:09 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-25 23:32 [PATCH] arm64: dts: renesas: r9a09g011: Add missing space in compatible Niklas Söderlund
2023-11-26 12:42 ` Krzysztof Kozlowski
2023-11-26 13:04   ` Niklas Söderlund
2023-11-27  7:05     ` Krzysztof Kozlowski
2023-11-27 14:08 ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox