From: Andrew Davis <afd@ti.com>
To: Nishanth Menon <nm@ti.com>, Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>, David Airlie <airlied@gmail.com>,
Maxime Ripard <mripard@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Neil Armstrong <neil.armstrong@linaro.org>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
Robert Nelson <robertcnelson@gmail.com>,
Jason Kridner <jkridner@beagleboard.org>,
<tomi.valkeinen@ideasonboard.com>, <devarsht@ti.com>
Subject: Re: [PATCH V3 2/4] drm/bridge: it66121: Drop ftrace like dev_dbg() prints
Date: Fri, 15 Aug 2025 08:50:32 -0500 [thread overview]
Message-ID: <08eec1de-1c92-44ce-8caa-2dc43a67c514@ti.com> (raw)
In-Reply-To: <20250815034105.1276548-3-nm@ti.com>
On 8/14/25 10:41 PM, Nishanth Menon wrote:
> Drop the ftrace like dev_dbg() that checkpatch --strict complains about:
>
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> + dev_dbg(dev, "%s\n", __func__);
>
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> + dev_dbg(dev, "%s\n", __func__);
>
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> + dev_dbg(dev, "%s\n", __func__);
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
Reviewed-by: Andrew Davis <afd@ti.com>
> Changes in V3:
> * New patch
>
> drivers/gpu/drm/bridge/ite-it66121.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
> index aa7b1dcc5d70..9b8ed2fae2f4 100644
> --- a/drivers/gpu/drm/bridge/ite-it66121.c
> +++ b/drivers/gpu/drm/bridge/ite-it66121.c
> @@ -1384,8 +1384,6 @@ static int it66121_audio_startup(struct device *dev, void *data)
> int ret;
> struct it66121_ctx *ctx = dev_get_drvdata(dev);
>
> - dev_dbg(dev, "%s\n", __func__);
> -
> mutex_lock(&ctx->lock);
> ret = it661221_audio_output_enable(ctx, true);
> if (ret)
> @@ -1401,8 +1399,6 @@ static void it66121_audio_shutdown(struct device *dev, void *data)
> int ret;
> struct it66121_ctx *ctx = dev_get_drvdata(dev);
>
> - dev_dbg(dev, "%s\n", __func__);
> -
> mutex_lock(&ctx->lock);
> ret = it661221_audio_output_enable(ctx, false);
> if (ret)
> @@ -1479,8 +1475,6 @@ static int it66121_audio_codec_init(struct it66121_ctx *ctx, struct device *dev)
> .no_capture_mute = 1,
> };
>
> - dev_dbg(dev, "%s\n", __func__);
> -
> if (!of_property_present(dev->of_node, "#sound-dai-cells")) {
> dev_info(dev, "No \"#sound-dai-cells\", no audio\n");
> return 0;
next prev parent reply other threads:[~2025-08-15 13:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 3:41 [PATCH V3 0/4] drm/bridge: it66121: Add initial it66122 support Nishanth Menon
2025-08-15 3:41 ` [PATCH V3 1/4] dt-bindings: display: bridge: it66121: Add compatible string for IT66122 Nishanth Menon
2025-08-15 3:41 ` [PATCH V3 2/4] drm/bridge: it66121: Drop ftrace like dev_dbg() prints Nishanth Menon
2025-08-15 13:50 ` Andrew Davis [this message]
2025-08-16 19:23 ` Dmitry Baryshkov
2025-08-15 3:41 ` [PATCH V3 3/4] drm/bridge: it66121: Use vid/pid to detect the type of chip Nishanth Menon
2025-08-15 13:52 ` Andrew Davis
2025-08-15 15:22 ` Nishanth Menon
2025-08-16 19:55 ` Dmitry Baryshkov
2025-08-15 3:41 ` [PATCH V3 4/4] drm/bridge: it66121: Add minimal it66122 support Nishanth Menon
2025-08-15 13:54 ` Andrew Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08eec1de-1c92-44ce-8caa-2dc43a67c514@ti.com \
--to=afd@ti.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jkridner@beagleboard.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nm@ti.com \
--cc=robertcnelson@gmail.com \
--cc=robh@kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox