From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Rob Clark <robdclark@gmail.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Akhil P Oommen <quic_akhilpo@quicinc.com>,
Sean Paul <sean@poorly.run>,
Konrad Dybcio <konradybcio@kernel.org>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Caleb Connolly <caleb.connolly@linaro.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, Jie Zhang <quic_jiezh@quicinc.com>,
Rob Clark <robdclark@chromium.org>
Subject: Re: [PATCH 1/5] drm/msm/a6xx: Fix gpucc register block for A621
Date: Thu, 13 Feb 2025 18:22:24 +0100 [thread overview]
Message-ID: <0c753d83-d49d-43b4-b871-301b8a93797e@oss.qualcomm.com> (raw)
In-Reply-To: <CAF6AEGv6q59dpktR-zR7+4nuz05HMrY7givk8-E4rwCyJ0zNjQ@mail.gmail.com>
On 13.02.2025 6:19 PM, Rob Clark wrote:
> On Thu, Feb 13, 2025 at 8:36 AM Konrad Dybcio
> <konrad.dybcio@oss.qualcomm.com> wrote:
>>
>> On 13.02.2025 5:10 PM, Akhil P Oommen wrote:
>>> From: Jie Zhang <quic_jiezh@quicinc.com>
>>>
>>> Adreno 621 has a different memory map for GPUCC block. So update
>>> a6xx_gpu_state code to dump the correct set of gpucc registers.
>>>
>>> Signed-off-by: Jie Zhang <quic_jiezh@quicinc.com>
>>> Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
>>> ---
>>
>> So GPU_CC is outside what we consider GPU register region upstream..
>>
>> And I've heard voices (+Caleb) lately that we should get some clock register
>> dumping infrastructure..
>>
>> So while I'm not against this patch fixing a bug, perhaps we can get rid of
>> dumping GPU_CC here in the near future
>
> but we'd still want this to end up in the gpu devcoredump...
I suppose if the clock dump is implemented as sysfs, we can export that
func and call it from gpu dump code
Konrad
next prev parent reply other threads:[~2025-02-13 17:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 16:10 [PATCH 0/5] EDITME: Support for Adreno 623 GPU Akhil P Oommen
2025-02-13 16:10 ` [PATCH 1/5] drm/msm/a6xx: Fix gpucc register block for A621 Akhil P Oommen
2025-02-13 16:36 ` Konrad Dybcio
2025-02-13 17:19 ` Rob Clark
2025-02-13 17:22 ` Konrad Dybcio [this message]
2025-02-18 18:22 ` Rob Clark
2025-02-25 6:34 ` Akhil P Oommen
2025-02-13 16:10 ` [PATCH 2/5] drm/msm/a6xx: Add support for Adreno 623 Akhil P Oommen
2025-02-13 16:54 ` Dmitry Baryshkov
2025-02-15 11:49 ` Akhil P Oommen
2025-02-15 15:22 ` Dmitry Baryshkov
2025-02-13 17:21 ` Konrad Dybcio
2025-02-25 6:36 ` Akhil P Oommen
2025-02-13 16:10 ` [PATCH 3/5] dt-bindings: display/msm/gmu: Add Adreno 623 GMU Akhil P Oommen
2025-02-14 8:44 ` Krzysztof Kozlowski
2025-02-13 16:10 ` [PATCH 4/5] arm64: dts: qcom: qcs8300: Add gpu and gmu nodes Akhil P Oommen
2025-02-13 16:56 ` Dmitry Baryshkov
2025-02-13 17:16 ` Akhil P Oommen
2025-02-13 16:10 ` [PATCH 5/5] arm64: dts: qcom: qcs8300-ride: Enable Adreno 623 GPU Akhil P Oommen
2025-02-13 16:57 ` Dmitry Baryshkov
2025-02-13 16:42 ` [PATCH 0/5] EDITME: Support for " Dmitry Baryshkov
2025-02-13 16:56 ` Akhil P Oommen
2025-02-19 0:42 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c753d83-d49d-43b4-b871-301b8a93797e@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_akhilpo@quicinc.com \
--cc=quic_jiezh@quicinc.com \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox